From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4E290352C4F for ; Mon, 3 Aug 2026 14:00:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785765629; cv=none; b=N0AujomMIAhsCIwJmMUQrBE1mVr76TuozwqYzf6mb4+GZQLF2abp8kLSEnzy4KoI+oqoZhoSr/4M+s/S+M1qQH8ouB0fUtyD5/IQJ3tK+IIJdUfxczh9Ht8LaOQWb6y5wjo2UdB1z9q30jcp0+RzgLVzYlnAxNpva3bNwkahjA0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785765629; c=relaxed/simple; bh=RjeFzdCXL+NHFyMq3/xT9cd8LkEcbtMX18oNa+YN0BI=; h=Subject:To:Cc:References:From:Message-ID:Date:MIME-Version: In-Reply-To:Content-Type; b=FbjvHU4ri8PKo7L9AwOhSFMTGI9stQXdQJRxyLpiGjX4CCnOfgcaIF+LD09vPX4KM83Zb8BSCaxSQNEmkIvqKwOHZWOSUM8Ju+hGhktelrJ16fNDgSsvNpzXEOndrJxf/VggAVrb0FO6Lv8G46p0LABAyojepgfptbNNmNhVMks= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=nr7i0/Gd; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=jqM1/Rkg; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="nr7i0/Gd"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="jqM1/Rkg" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 673DRou8739536 for ; Mon, 3 Aug 2026 14:00:27 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= vKfDnl36SXijj5vK7jAVVLNegdlF1dNn5bPXXAHyHOI=; b=nr7i0/GdV00Fgv2s Lp7UPsWwvMlcl2PbGW/rEJf6/yPPdBaB+ABwH/ID6bPVjh945vRDcNjC67MGNv+U B3jgX/60smLpjl5myqKYEnRuee1salsn2bxzkp0Y0EP/1Fv/XrEJMrL/7d/adKhm iux0ELYKYfYp4F4kKTtqvThBzmXt8vc1Gykj3lrhDUuZ8a60Ccs6VkgPLz2uimQw QLHc4wqrbOryBjgEvaZByZHZMp4qYMOhGkrx8LiDf5prEgWer/esrxi/ST6JQ6CD Af9Ownj/skwR4FP/RNwtUCd6W8G5rQAsXTHJRouXJXSPD6NIoIO7ROprc/EUIiUB YNTO0A== Received: from mail-pg1-f198.google.com (mail-pg1-f198.google.com [209.85.215.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ftnvnhu5y-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 03 Aug 2026 14:00:27 +0000 (GMT) Received: by mail-pg1-f198.google.com with SMTP id 41be03b00d2f7-c85798977dcso5759485a12.0 for ; Mon, 03 Aug 2026 07:00:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1785765626; x=1786370426; darn=vger.kernel.org; h=content-transfer-encoding:content-language:content-type:in-reply-to :mime-version:user-agent:date:message-id:from:references:cc:to :subject:from:to:cc:subject:date:message-id:reply-to:content-type; bh=vKfDnl36SXijj5vK7jAVVLNegdlF1dNn5bPXXAHyHOI=; b=jqM1/RkgA8787Sk8VGltgIy86ZwYI4GnvbPp9/xAP+AzqDlzm37Pvga+7X2Qsh3Ckf NvSYKQQci0YcTrsL30q+BsACUgKo/3+VuXhiPd0DeEtxM/0TX4TD0hgsqqpkPjSEin2Z v3CTHbFz4e8lf9fnQyibwHdaqVFsnX8kPvCRSZW9BFEhSXfHBjZE9Sc9UgrxQS8h/Lix WvoOd0BEbmXcAIko2AnefsIZqSogO5XjXblGxewtrMZC2Y+gGeaF7rqKSHSTlvTJ7FJk /efS/paHE54dzjD3SbId/KGRVu8Rn07A/mf4iqaS3GAS6aF49HSGfTrLEBrr1F5Qz+0x Eqhg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785765626; x=1786370426; h=content-transfer-encoding:content-language:content-type:in-reply-to :mime-version:user-agent:date:message-id:from:references:cc:to :subject:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=vKfDnl36SXijj5vK7jAVVLNegdlF1dNn5bPXXAHyHOI=; b=sCFFlnOWM5dEuZLZG+d59FFZSCvT9j/uKcihoyfSGNDwnw4W9HliqU5tD2GLalpiWK maREOWe6hT23d1AKyD2jde0F3cVNC7QtS8Mf6LhlqGM8gUJbxxp5fyLH4zE/Qr6+oykO Sq5IIMDHdcxkm8HtjfyOe2c6hHCnykyGzwU81X444P2JaBbz/Se0PBsQpdsGtfKVIK5X Nq+Y9RJApHH/adlYz4tJWxDXQP6kU5Sg21Ec4VNcxq8QwPSKoUZk1LkJlurO6F3H0tik Gy8zPhBmcU0IJs5Ujoog2MlEVXaDQYfiLhCYGXH+5FluGmspNRRqEBoBEH5aD/uwDHXY l1UA== X-Forwarded-Encrypted: i=1; AHgh+Rpfbm2hHtzg7Sm62AX/BFfxbkJYPgDOQyHTpsIxvF4oX5OPJ/aOqz5ZP54MFaeb75WS3bxVrSMZwn8=@vger.kernel.org X-Gm-Message-State: AOJu0Yyt9Y14ZjgaTPTYpktosvlXgHhl0MK1nQsqJ73T9srBBjyCr6kO OJoM2kVevSG2ODegsm+vVN05+CQjGD30oIVTex4orQdCef/ouSDpXv6igdxpLjkHQAEYIsOiCYy 61s8jHd7Q6XorCFKZpy4xpZ631YqIbjFqqiOmFJgoDlDtrskE0U2J6O2n+fbT7KI= X-Gm-Gg: AR+sD126Apb9NM+pkplAJtqkUhyVWwJiOnWa97HLy89skPm3s9gOIV3nY6S7rgCrw1q aArn+/l8N09aZCLzlMIjxq8eqKQ7E7FjApZW1S8FQFrLlMTWqPOVEEQ7M3XQrZmp0jQNS0qDDHv s58rud4tGjMNMnKih/P2fAcxd11WreDivTQXkkEevIty5kU34a/uazV748MF7RMRdojgYdZtrhN zabET+Z+JpWa/PoKEg3oJ8rR8REOsn9wHeaLkGoCV0stcargiYLq9mXpWas8qL8WQPM3OFB6jWk JEwsRl8E4iO0VyciSns1MQMP8UxeRrTnxxGTu0z7yxnoDPPtETrbJ2f+GZZ7LwQM9ppZmQsHm5V P5CC4p/yjYQRUrPiaP/QGMFT836SaqA== X-Received: by 2002:a05:6a21:4683:b0:3c3:b57b:6455 with SMTP id adf61e73a8af0-3c92a846c3dmr11146519637.49.1785765624303; Mon, 03 Aug 2026 07:00:24 -0700 (PDT) X-Received: by 2002:a05:6a21:4683:b0:3c3:b57b:6455 with SMTP id adf61e73a8af0-3c92a846c3dmr11146165637.49.1785765621378; Mon, 03 Aug 2026 07:00:21 -0700 (PDT) Received: from [192.168.29.77] ([49.43.218.234]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3153e18e107sm43434358eec.27.2026.08.03.07.00.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 03 Aug 2026 07:00:20 -0700 (PDT) Subject: Re: [PATCH v5 2/4] mmc: sdhci-msm: Reprogram crypto keys during host hardware initialization To: Ram Prakash Gupta , Eric Biggers Cc: ulf.hansson@linaro.org, adrian.hunter@intel.com, quic_dmukhopa@quicinc.com, quic_rampraka@quicinc.com, quic_nitirawa@quicinc.com, quic_sachgupt@quicinc.com, quic_bhaskarv@quicinc.com, quic_gaurkash@quicinc.com, quic_sartgarg@quicinc.com, linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org References: <20260730140822.1976635-1-neeraj.soni@oss.qualcomm.com> <20260730140822.1976635-3-neeraj.soni@oss.qualcomm.com> <20260730191823.GD3139@sol> <6c795412-ab63-22f9-0b64-8bc746fc2773@oss.qualcomm.com> <20260731061246.GB57540@sol> <5af5ea26-9cf6-4cce-8cdf-7b5acb773608@oss.qualcomm.com> From: Neeraj Soni Message-ID: <4ca7b3c5-7efc-bf60-4f24-caefd96c391c@oss.qualcomm.com> Date: Mon, 3 Aug 2026 19:30:13 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 Precedence: bulk X-Mailing-List: linux-mmc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 In-Reply-To: <5af5ea26-9cf6-4cce-8cdf-7b5acb773608@oss.qualcomm.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=aoaCzyZV c=1 sm=1 tr=0 ts=6a709efb cx=c_pps a=Qgeoaf8Lrialg5Z894R3/Q==:117 a=9qtqvq33Fd9BUailxVlm8w==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=VwQbUJbxAAAA:8 a=LDBv8-xUAAAA:8 a=COk6AnOGAAAA:8 a=EUspDBNiAAAA:8 a=kJZwEO8prvA8Bnpbhs4A:9 a=QEXdDO2ut3YA:10 a=x9snwWr2DeNwDh03kgHS:22 a=DZeXCJrVpAJBw65Qk4Ds:22 a=TjNXssC_j7lpFel5tvFf:22 X-Proofpoint-GUID: EzoFNpcDyKW8xKW_JanAHm8XUUxDh0TD X-Proofpoint-ORIG-GUID: EzoFNpcDyKW8xKW_JanAHm8XUUxDh0TD X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODAzMDEyNSBTYWx0ZWRfX/kBFa5llRY0a Q8Ek9k+4/ELS+NJBMtshkVDsT1Y//422ASCILWVFeZwUHPexDGb1uHaEsdjQHFScjCrqc2GrI3f /+x7BpKlI7pXS4fPaRxqr/oYGgzMLDBtP30ANJX4v0aj6P7WU75qqq8iROR6lCRHeoLq8MbCMHO Dbx96EYQPTb3XWA7EtEfzPWks88lXJJvZWMQAUae32UGSVffI7brWPM9whU6fXgydzeEXo9aL20 fHYZkseUhJya477Wdz6swlGFmbLxE2CYdtn89VUipZEJYXD2Q17lSwG5qHflMPM0r1H5mMfF9rV 7/+vG3fZIwoAoNvQcGGLtUstQlUQTyMBaYFMz/kFhJpggqtHN7Z0KtcYgkWKjH7USlsDVep23JR ajIS87LY3gqlC5nKKbahQIgJ8rxwSdiN+ZM2ipCSG/Ciq+7VBMYguRrBeJKnj7CVGn5fcNehjGI 3YXNT4ABRDHF9NQi1AA== X-Proofpoint-Spam-Info: AW1haW4tMjYwODAzMDEyNSBTYWx0ZWRfX+8NWAF2U50EF DSeqOLXzjfK0MH4kn0kBUsevtgesXXRiZYNuB8E7bvRP/3Mn3HI0WqVnFbQi+Cz43KJKWGth5BT v7158658BiSQjlVgBIb9usA5su2wswE= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-03_03,2026-08-03_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 bulkscore=0 suspectscore=0 priorityscore=1501 adultscore=0 spamscore=0 lowpriorityscore=0 malwarescore=0 phishscore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608030125 On 7/31/2026 6:14 PM, Ram Prakash Gupta wrote: > > > On 7/31/2026 11:42 AM, Eric Biggers wrote: >> On Fri, Jul 31, 2026 at 11:37:44AM +0530, Neeraj Soni wrote: >>> >>> >>> On 7/31/2026 12:48 AM, Eric Biggers wrote: >>>> On Thu, Jul 30, 2026 at 07:38:20PM +0530, Neeraj Soni wrote: >>>>> Host looses the Inline Crypto Engine (ICE) keys during hardware reset. >>>>> Re-program the keys while intializing ICE to ensure that ICE is available >>>>> in the same state as before the hardware reset. >>>>> >>>>> Also set MMC_CAP2_CRYPTO_NO_REPROG to indicate that re-program of ICE keys >>>>> is not needed during MMC runtime suspend/resume. >>>>> >>>>> Signed-off-by: Seshu Madhavi Puppala >>>>> Co-developed-by: Ram Prakash Gupta >>>>> Signed-off-by: Ram Prakash Gupta >>>>> Co-developed-by: Sarthak Garg >>>>> Signed-off-by: Sarthak Garg >>>>> Signed-off-by: Debraj Mukhopadhyay >>>>> Signed-off-by: Neeraj Soni >>>>> --- >>>>> drivers/mmc/host/sdhci-msm.c | 3 +++ >>>>> 1 file changed, 3 insertions(+) >>>>> >>>>> diff --git a/drivers/mmc/host/sdhci-msm.c b/drivers/mmc/host/sdhci-msm.c >>>>> index 4aff965f0e2e..7d71dc6f388d 100644 >>>>> --- a/drivers/mmc/host/sdhci-msm.c >>>>> +++ b/drivers/mmc/host/sdhci-msm.c >>>>> @@ -1958,7 +1958,10 @@ static int sdhci_msm_ice_init(struct sdhci_msm_host *msm_host, >>>>> cap.sdus_mask * 512; >>>>> } >>>>> >>>>> + blk_crypto_reprogram_all_keys(&mmc->crypto_profile); >>>>> + >>>> >>>> This still does nothing. The crypto profile was just initialized, so no >>>> keyslots are in-use and blk_crypto_reprogram_all_keys() does nothing. >>>> >>> This is needed to address those scenarios where device is running in a >>> stable state and only the host hardware goes for a reset, for example, >>> to recover from an error state or stall. >> >> Nope. Please check the actual code. This is called only at driver >> probe time. Again, the crypto profile was just initialized, and no >> keyslots are in-use. It is a no-op. Maybe you intended it to do >> something else, but that is not what it actually does. >> >> - Eric > > Hi Neeraj, > > earlier change for blk_crypto_reprogram_all_keys() in sdhci_msm_gcc_reset() was required > when .hw_reset from sdhci_ops was overwritten with sdhi_msm_gcc_reset internally for robust > error recovery but this changed after https://lore.kernel.org/all/20220408080045.6497-4-wsa+renesas@sang-engineering.com/ > > we plan to rework recovery soon and we will take care of key reprogramming as part of that. > For time being you can drop this, as Eric pointed out, this is redundant. > Ack. Will fix this in v6. > Thanks, > Ram > Regards Neeraj > > >