From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paul Parsons Subject: Re: [PATCH] MMC: tmio: fix a recent regression: restore .set_ios(MMC_POWER_UP) handling Date: Fri, 22 Apr 2011 05:24:35 +0100 (BST) Message-ID: <504862.26396.qm@web29015.mail.ird.yahoo.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT Return-path: In-Reply-To: Sender: linux-sh-owner@vger.kernel.org To: Guennadi Liakhovetski , Chris Ball Cc: linux-mmc@vger.kernel.org, linux-sh@vger.kernel.org, Magnus Damm , Simon Horman , Ian Molton List-Id: linux-mmc@vger.kernel.org Yes, Guennadi's patch fixes my problem. As far as I can see the expression (ios->clock == 0 && ios->power_mode == MMC_POWER_ON) will only be true if host->f_init == 0 at the time MMC_POWER_ON is invoked in mmc_power_up(). Presumably that case is intentional. --- On Thu, 21/4/11, Chris Ball wrote: > Paul Parsons (CC'd) submitted a similar patch to fix the > same regression. > Paul, please could you check that Guennadi's patch fixes > your problem?