[PATCH 0/2] mmc: core: pre-patch for next eMMC version

[PATCH 0/2] mmc: core: pre-patch for next eMMC version

[Jaehoon Chung]

eMMC card revision have increased more faster than before.
We need to prepare the next eMMC revision(eMMCx.0).
Its revision is 0x7. (eMMC4.5 is 0x6 - can get the information at ext_csd register)

Jaehoon Chung (2):
  mmc: core: prepare the next version of eMMC card
  mmc: core: add the quirk for broken revision

 drivers/mmc/core/mmc.c     |   15 ++++++++++-----
 include/linux/mmc/card.h   |    1 +
 include/linux/mmc/host.h   |    1 +
 5 files changed, 17 insertions(+), 5 deletions(-)

-- 
1.7.4.1

Re: [PATCH 0/2] mmc: core: pre-patch for next eMMC version

[Ulf Hansson]

Hi Jaehoon,

I think this patches as of now does not really make sense. These types
of devices is far from reaching the market and just saying that a
later revision in the ext_csd is supported is too simple. Moreover,
why shall we add a quirk for a problem that does not even exist.

Kind regards
Ulf Hansson

On 24 August 2012 02:23, Jaehoon Chung <jh80.chung@samsung.com> wrote:
> eMMC card revision have increased more faster than before.
> We need to prepare the next eMMC revision(eMMCx.0).
> Its revision is 0x7. (eMMC4.5 is 0x6 - can get the information at ext_csd register)
>
> Jaehoon Chung (2):
>   mmc: core: prepare the next version of eMMC card
>   mmc: core: add the quirk for broken revision
>
>  drivers/mmc/core/mmc.c     |   15 ++++++++++-----
>  include/linux/mmc/card.h   |    1 +
>  include/linux/mmc/host.h   |    1 +
>  5 files changed, 17 insertions(+), 5 deletions(-)
>
> --
> 1.7.4.1
> --
> To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 0/2] mmc: core: pre-patch for next eMMC version

[Jaehoon Chung]

Hi Ulf,

This patch is to support eMMC5.0.(already discussing on eMMC5.0.)
Revision value is defined the 0x7 into ext_csd register.(in eMMC5.0's case)

And case of Quirks is preparation patch to prevent the problem that should exist.
That Quirks can also use for backward compatibility.
(if card is greater version than eMMC4.5 and need to use only eMMC4.5 feature?
 then can use quirks and known_rev.)

Best Regards,
Jaehoon Chung


On 08/27/2012 09:04 PM, Ulf Hansson wrote:
> Hi Jaehoon,
> 
> I think this patches as of now does not really make sense. These types
> of devices is far from reaching the market and just saying that a
> later revision in the ext_csd is supported is too simple. Moreover,
> why shall we add a quirk for a problem that does not even exist.
> 
> Kind regards
> Ulf Hansson
> 
> On 24 August 2012 02:23, Jaehoon Chung <jh80.chung@samsung.com> wrote:
>> eMMC card revision have increased more faster than before.
>> We need to prepare the next eMMC revision(eMMCx.0).
>> Its revision is 0x7. (eMMC4.5 is 0x6 - can get the information at ext_csd register)
>>
>> Jaehoon Chung (2):
>>   mmc: core: prepare the next version of eMMC card
>>   mmc: core: add the quirk for broken revision
>>
>>  drivers/mmc/core/mmc.c     |   15 ++++++++++-----
>>  include/linux/mmc/card.h   |    1 +
>>  include/linux/mmc/host.h   |    1 +
>>  5 files changed, 17 insertions(+), 5 deletions(-)
>>
>> --
>> 1.7.4.1
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> --
> To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

Re: [PATCH 0/2] mmc: core: pre-patch for next eMMC version

[Ulf Hansson]

Hi Jaehoon,

On 28 August 2012 06:33, Jaehoon Chung <jh80.chung@samsung.com> wrote:
> Hi Ulf,
>
> This patch is to support eMMC5.0.(already discussing on eMMC5.0.)
> Revision value is defined the 0x7 into ext_csd register.(in eMMC5.0's case)

Until the spec is really set we should not add some new code for this,
it does not make sense to kind of guess.

>
> And case of Quirks is preparation patch to prevent the problem that should exist.
> That Quirks can also use for backward compatibility.
> (if card is greater version than eMMC4.5 and need to use only eMMC4.5 feature?
>  then can use quirks and known_rev.)

It is just speculations about potential problems with eMMC 5.0. I
think we can leave this to later, if/when we see a need for it.

Kind regards
Ulf Hansson

Re: [PATCH 0/2] mmc: core: pre-patch for next eMMC version

[Kyungmin Park]

Hi Ulf,

On 8/29/12, Ulf Hansson <ulf.hansson@linaro.org> wrote:
> Hi Jaehoon,
>
> On 28 August 2012 06:33, Jaehoon Chung <jh80.chung@samsung.com> wrote:
>> Hi Ulf,
>>
>> This patch is to support eMMC5.0.(already discussing on eMMC5.0.)
>> Revision value is defined the 0x7 into ext_csd register.(in eMMC5.0's
>> case)
>
> Until the spec is really set we should not add some new code for this,
> it does not make sense to kind of guess.
It's not guess. it's determined and will be discussed at JEDEC soon.

Revision 1.7 (for MMC V5.0)

Thank you,
Kyungmin Park
>
>>
>> And case of Quirks is preparation patch to prevent the problem that should
>> exist.
>> That Quirks can also use for backward compatibility.
>> (if card is greater version than eMMC4.5 and need to use only eMMC4.5
>> feature?
>>  then can use quirks and known_rev.)
>
> It is just speculations about potential problems with eMMC 5.0. I
> think we can leave this to later, if/when we see a need for it.
>
> Kind regards
> Ulf Hansson
> --
> To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>

Re: [PATCH 0/2] mmc: core: pre-patch for next eMMC version

[Jaehoon Chung]

Hi Ulf and Chris,

Could you have any opinion?
If you have no more, could you merge the patch for eMMC5.0?

Best Regards,
Jaehoon Chung

On 08/29/2012 08:59 PM, Kyungmin Park wrote:
> Hi Ulf,
> 
> On 8/29/12, Ulf Hansson <ulf.hansson@linaro.org> wrote:
>> Hi Jaehoon,
>>
>> On 28 August 2012 06:33, Jaehoon Chung <jh80.chung@samsung.com> wrote:
>>> Hi Ulf,
>>>
>>> This patch is to support eMMC5.0.(already discussing on eMMC5.0.)
>>> Revision value is defined the 0x7 into ext_csd register.(in eMMC5.0's
>>> case)
>>
>> Until the spec is really set we should not add some new code for this,
>> it does not make sense to kind of guess.
> It's not guess. it's determined and will be discussed at JEDEC soon.
> 
> Revision 1.7 (for MMC V5.0)
> 
> Thank you,
> Kyungmin Park
>>
>>>
>>> And case of Quirks is preparation patch to prevent the problem that should
>>> exist.
>>> That Quirks can also use for backward compatibility.
>>> (if card is greater version than eMMC4.5 and need to use only eMMC4.5
>>> feature?
>>>  then can use quirks and known_rev.)
>>
>> It is just speculations about potential problems with eMMC 5.0. I
>> think we can leave this to later, if/when we see a need for it.
>>
>> Kind regards
>> Ulf Hansson
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

Re: [PATCH 0/2] mmc: core: pre-patch for next eMMC version

[Ulf Hansson]

Hi Jaehoon,

For "mmc: core: prepare the next version of eMMC card" you may have my ack!

But not for "mmc: core: add the quirk for broken revision".
The reason is simply that it is not needed right now and we don't know
if it ever will be. So I suggest to skip this for now and we can get
back to this later.

Kind regards
Ulf Hansson


On 14 September 2012 09:13, Jaehoon Chung <jh80.chung@samsung.com> wrote:
> Hi Ulf and Chris,
>
> Could you have any opinion?
> If you have no more, could you merge the patch for eMMC5.0?
>
> Best Regards,
> Jaehoon Chung
>
> On 08/29/2012 08:59 PM, Kyungmin Park wrote:
>> Hi Ulf,
>>
>> On 8/29/12, Ulf Hansson <ulf.hansson@linaro.org> wrote:
>>> Hi Jaehoon,
>>>
>>> On 28 August 2012 06:33, Jaehoon Chung <jh80.chung@samsung.com> wrote:
>>>> Hi Ulf,
>>>>
>>>> This patch is to support eMMC5.0.(already discussing on eMMC5.0.)
>>>> Revision value is defined the 0x7 into ext_csd register.(in eMMC5.0's
>>>> case)
>>>
>>> Until the spec is really set we should not add some new code for this,
>>> it does not make sense to kind of guess.
>> It's not guess. it's determined and will be discussed at JEDEC soon.
>>
>> Revision 1.7 (for MMC V5.0)
>>
>> Thank you,
>> Kyungmin Park
>>>
>>>>
>>>> And case of Quirks is preparation patch to prevent the problem that should
>>>> exist.
>>>> That Quirks can also use for backward compatibility.
>>>> (if card is greater version than eMMC4.5 and need to use only eMMC4.5
>>>> feature?
>>>>  then can use quirks and known_rev.)
>>>
>>> It is just speculations about potential problems with eMMC 5.0. I
>>> think we can leave this to later, if/when we see a need for it.
>>>
>>> Kind regards
>>> Ulf Hansson
>>> --
>>> To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
>>> the body of a message to majordomo@vger.kernel.org
>>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>>
>

Re: [PATCH 0/2] mmc: core: pre-patch for next eMMC version

[Jaehoon Chung]

Hi Ulf,

I agreed your opinion.

Best Regards,
Jaehoon Chung

On 09/14/2012 06:34 PM, Ulf Hansson wrote:
> Hi Jaehoon,
> 
> For "mmc: core: prepare the next version of eMMC card" you may have my ack!
> 
> But not for "mmc: core: add the quirk for broken revision".
> The reason is simply that it is not needed right now and we don't know
> if it ever will be. So I suggest to skip this for now and we can get
> back to this later.
> 
> Kind regards
> Ulf Hansson
> 
> 
> On 14 September 2012 09:13, Jaehoon Chung <jh80.chung@samsung.com> wrote:
>> Hi Ulf and Chris,
>>
>> Could you have any opinion?
>> If you have no more, could you merge the patch for eMMC5.0?
>>
>> Best Regards,
>> Jaehoon Chung
>>
>> On 08/29/2012 08:59 PM, Kyungmin Park wrote:
>>> Hi Ulf,
>>>
>>> On 8/29/12, Ulf Hansson <ulf.hansson@linaro.org> wrote:
>>>> Hi Jaehoon,
>>>>
>>>> On 28 August 2012 06:33, Jaehoon Chung <jh80.chung@samsung.com> wrote:
>>>>> Hi Ulf,
>>>>>
>>>>> This patch is to support eMMC5.0.(already discussing on eMMC5.0.)
>>>>> Revision value is defined the 0x7 into ext_csd register.(in eMMC5.0's
>>>>> case)
>>>>
>>>> Until the spec is really set we should not add some new code for this,
>>>> it does not make sense to kind of guess.
>>> It's not guess. it's determined and will be discussed at JEDEC soon.
>>>
>>> Revision 1.7 (for MMC V5.0)
>>>
>>> Thank you,
>>> Kyungmin Park
>>>>
>>>>>
>>>>> And case of Quirks is preparation patch to prevent the problem that should
>>>>> exist.
>>>>> That Quirks can also use for backward compatibility.
>>>>> (if card is greater version than eMMC4.5 and need to use only eMMC4.5
>>>>> feature?
>>>>>  then can use quirks and known_rev.)
>>>>
>>>> It is just speculations about potential problems with eMMC 5.0. I
>>>> think we can leave this to later, if/when we see a need for it.
>>>>
>>>> Kind regards
>>>> Ulf Hansson
>>>> --
>>>> To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
>>>> the body of a message to majordomo@vger.kernel.org
>>>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>>>>
>>> --
>>> To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
>>> the body of a message to majordomo@vger.kernel.org
>>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>>>
>>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>