From: Balaji T K <balajitk@ti.com>
To: Daniel Mack <zonque@gmail.com>
Cc: linux-mmc@vger.kernel.org, Venkatraman S <svenkatr@ti.com>,
Chris Ball <cjb@laptop.org>,
Grant Likely <grant.likely@secretlab.ca>,
Rob Herring <rob.herring@calxeda.com>,
linux-omap@vger.kernel.org
Subject: Re: [PATCH 1/4] MMC: omap_hsmmc: set platform data after probe from DT node
Date: Fri, 12 Oct 2012 20:53:21 +0530 [thread overview]
Message-ID: <507835E9.9020200@ti.com> (raw)
In-Reply-To: <507833ED.8060903@gmail.com>
On Friday 12 October 2012 08:44 PM, Daniel Mack wrote:
> On 12.10.2012 16:56, Balaji T K wrote:
>> On Friday 12 October 2012 07:59 PM, Daniel Mack wrote:
>>> On 12.10.2012 12:58, Daniel Mack wrote:
>>>> diff --git a/drivers/mmc/host/omap_hsmmc.c b/drivers/mmc/host/omap_hsmmc.c
>>>> index 19ccb59..4b70823 100644
>>>> --- a/drivers/mmc/host/omap_hsmmc.c
>>>> +++ b/drivers/mmc/host/omap_hsmmc.c
>>>> @@ -1728,6 +1728,7 @@ static int __devinit omap_hsmmc_probe(struct platform_device *pdev)
>>>> const u16 *offsetp = match->data;
>>>> pdata->reg_offset = *offsetp;
>>>> }
>>>> + pdev->dev.platform_data = pdata;
>>>> }
>>>>
>>>> if (pdata == NULL) {
>>>>
>>>
>>> FWIW, this is the Oops I see without this patch:
>> Hi,
>> Shouldn't pdev->dev.platform_data be set to NULL on _remove ?
>
> Why?
To make sure on second insmod it is NULL, When built as module,
So that of_get_hsmmc_pdata is called to create pdata.
>
>> BTW, I posted a patch for the same by accessing saved version from
>> host->pdata
>> http://permalink.gmane.org/gmane.linux.kernel.mmc/16996
>
> Ok, that's another solution. I thought about this too, but then chose
> the easier way :) I don't care which patch is taken, as long as we have
> a fix in mainline.
>
Agree this patch is easiest :-)
>
> Thanks,
> Daniel
>
next prev parent reply other threads:[~2012-10-12 15:23 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-12 10:58 [PATCH 0/4] MMC: some omap_hsmmc fixes Daniel Mack
2012-10-12 10:58 ` [PATCH 1/4] MMC: omap_hsmmc: set platform data after probe from DT node Daniel Mack
2012-10-12 14:29 ` Daniel Mack
2012-10-12 14:56 ` Balaji T K
2012-10-12 15:14 ` Daniel Mack
2012-10-12 15:23 ` Balaji T K [this message]
2012-10-13 0:05 ` Grant Likely
2012-10-13 8:05 ` Daniel Mack
2012-10-13 8:48 ` Grant Likely
2012-10-13 8:53 ` Daniel Mack
2012-10-13 12:37 ` Grant Likely
2012-10-12 10:58 ` [PATCH 2/4] MMC: omap_hsmmc: fix DMA config block Daniel Mack
2012-10-12 11:07 ` Porter, Matt
2012-10-12 11:12 ` Russell King - ARM Linux
2012-10-12 14:19 ` Daniel Mack
2012-10-12 10:58 ` [PATCH 3/4] MMC: omap_hsmmc: claim pinctrl at probe time Daniel Mack
2012-10-12 11:08 ` Linus Walleij
2012-10-12 10:58 ` [PATCH 4/4] MMC: omap_hsmmc: add DT property for max bus frequency Daniel Mack
2012-10-12 15:25 ` Rob Herring
2012-10-12 15:26 ` Daniel Mack
2012-10-13 9:01 ` [PATCH 0/4] MMC: some omap_hsmmc fixes Daniel Mack
2012-10-15 16:07 ` Venkatraman S
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=507835E9.9020200@ti.com \
--to=balajitk@ti.com \
--cc=cjb@laptop.org \
--cc=grant.likely@secretlab.ca \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=rob.herring@calxeda.com \
--cc=svenkatr@ti.com \
--cc=zonque@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox