* [PATCH] mmc: sdhci-pci: fix 'Invalid iomem size' error message condition
@ 2012-10-18 6:54 Adrian Hunter
2012-10-29 21:13 ` Chris Ball
0 siblings, 1 reply; 2+ messages in thread
From: Adrian Hunter @ 2012-10-18 6:54 UTC (permalink / raw)
To: Chris Ball; +Cc: linux-mmc
The SDHCI standard defines a 256 byte register set but a device
that specifies a larger iomem region is not an error. Alter the
message condition accordingly.
Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>
---
drivers/mmc/host/sdhci-pci.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mmc/host/sdhci-pci.c b/drivers/mmc/host/sdhci-pci.c
index 4bb74b0..04936f3 100644
--- a/drivers/mmc/host/sdhci-pci.c
+++ b/drivers/mmc/host/sdhci-pci.c
@@ -1196,7 +1196,7 @@ static struct sdhci_pci_slot * __devinit sdhci_pci_probe_slot(
return ERR_PTR(-ENODEV);
}
- if (pci_resource_len(pdev, bar) != 0x100) {
+ if (pci_resource_len(pdev, bar) < 0x100) {
dev_err(&pdev->dev, "Invalid iomem size. You may "
"experience problems.\n");
}
--
1.7.11.4
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] mmc: sdhci-pci: fix 'Invalid iomem size' error message condition
2012-10-18 6:54 [PATCH] mmc: sdhci-pci: fix 'Invalid iomem size' error message condition Adrian Hunter
@ 2012-10-29 21:13 ` Chris Ball
0 siblings, 0 replies; 2+ messages in thread
From: Chris Ball @ 2012-10-29 21:13 UTC (permalink / raw)
To: Adrian Hunter; +Cc: linux-mmc
Hi,
On Thu, Oct 18 2012, Adrian Hunter wrote:
> The SDHCI standard defines a 256 byte register set but a device
> that specifies a larger iomem region is not an error. Alter the
> message condition accordingly.
>
> Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>
> ---
> drivers/mmc/host/sdhci-pci.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/sdhci-pci.c b/drivers/mmc/host/sdhci-pci.c
> index 4bb74b0..04936f3 100644
> --- a/drivers/mmc/host/sdhci-pci.c
> +++ b/drivers/mmc/host/sdhci-pci.c
> @@ -1196,7 +1196,7 @@ static struct sdhci_pci_slot * __devinit sdhci_pci_probe_slot(
> return ERR_PTR(-ENODEV);
> }
>
> - if (pci_resource_len(pdev, bar) != 0x100) {
> + if (pci_resource_len(pdev, bar) < 0x100) {
> dev_err(&pdev->dev, "Invalid iomem size. You may "
> "experience problems.\n");
> }
Thanks, pushed to mmc-next for 3.8.
- Chris.
--
Chris Ball <cjb@laptop.org> <http://printf.net/>
One Laptop Per Child
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-10-29 21:13 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-10-18 6:54 [PATCH] mmc: sdhci-pci: fix 'Invalid iomem size' error message condition Adrian Hunter
2012-10-29 21:13 ` Chris Ball
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).