From: Jaehoon Chung <jh80.chung@samsung.com>
To: Ulf Hansson <ulf.hansson@linaro.org>
Cc: r66093@freescale.com, linux-mmc@vger.kernel.org,
Jerry Huang <Chang-Ming.Huang@freescale.com>,
Anton Vorontsov <cbouatmailru@gmail.com>,
Chris Ball <cjb@laptop.org>
Subject: Re: [PATCH 1/4 v3] MMC/core: Add f_min to mmc_power_on()
Date: Wed, 31 Oct 2012 13:21:19 +0900 [thread overview]
Message-ID: <5090A73F.2020103@samsung.com> (raw)
In-Reply-To: <CAPDyKFqM0cUkDDadm8MBK=+wHHYOSH3CVEHyiY1ybLkmPqSX7w@mail.gmail.com>
On 10/31/2012 08:08 AM, Ulf Hansson wrote:
> On 30 October 2012 09:12, <r66093@freescale.com> wrote:
>> From: Jerry Huang <Chang-Ming.Huang@freescale.com>
>>
>> When f_init is zero, the SDHC can't work correctly. So f_min will replace
>> f_init, when f_init is zero.
>>
>> Signed-off-by: Jerry Huang <Chang-Ming.Huang@freescale.com>
>> CC: Anton Vorontsov <cbouatmailru@gmail.com>
>> CC: Chris Ball <cjb@laptop.org>
>> ---
>> changes for v2:
>> - add the CC
>> changes for v3:
>> - enalbe the controller clock in platform, instead of core
>>
>> drivers/mmc/core/core.c | 5 ++++-
>> 1 file changed, 4 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/mmc/core/core.c b/drivers/mmc/core/core.c
>> index 06c42cf..9c162cd 100644
>> --- a/drivers/mmc/core/core.c
>> +++ b/drivers/mmc/core/core.c
>> @@ -1319,7 +1319,10 @@ static void mmc_power_up(struct mmc_host *host)
>> */
>> mmc_delay(10);
>>
>> - host->ios.clock = host->f_init;
>> + if (host->f_init)
>> + host->ios.clock = host->f_init;
>> + else
>> + host->ios.clock = host->f_min;
>
> This should not be needed. host->f_init should never become zero, I believe.
I agree for Ulf's comment.
>
>>
>> host->ios.power_mode = MMC_POWER_ON;
>> mmc_set_ios(host);
>> --
>> 1.7.9.5
>>
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
> Kind regards
> Ulf Hansson
> --
> To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
next prev parent reply other threads:[~2012-10-31 4:21 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-30 8:12 [PATCH 1/4 v3] MMC/core: Add f_min to mmc_power_on() r66093
2012-10-30 8:12 ` [PATCH 2/4 v4] MMC/SD: Add callback function to detect card r66093
2012-10-30 8:12 ` [PATCH 3/4 v5] SDHCI: add sdhci_get_cd callback to detect the card r66093
2012-10-30 8:12 ` [PATCH 4/4 v4] ESDHC: add callback esdhc_of_get_cd to detect card r66093
2012-11-19 2:50 ` Huang Changming-R66093
2012-11-19 2:54 ` Anton Vorontsov
2012-11-19 2:50 ` [PATCH 3/4 v5] SDHCI: add sdhci_get_cd callback to detect the card Huang Changming-R66093
2012-11-19 2:58 ` Anton Vorontsov
2012-11-19 3:15 ` Huang Changming-R66093
2012-11-19 3:31 ` Anton Vorontsov
2012-11-19 3:38 ` Huang Changming-R66093
2012-10-30 11:34 ` [PATCH 2/4 v4] MMC/SD: Add callback function to detect card Girish K S
2012-10-31 2:23 ` Huang Changming-R66093
2012-10-31 4:29 ` Jaehoon Chung
2012-10-31 5:52 ` Huang Changming-R66093
2012-11-01 15:57 ` Johan Rudholm
2012-11-02 1:37 ` Huang Changming-R66093
2012-11-02 10:33 ` Johan Rudholm
2012-11-05 3:17 ` Huang Changming-R66093
2012-11-05 14:07 ` Johan Rudholm
2012-11-06 1:55 ` Huang Changming-R66093
2012-11-06 1:55 ` Huang Changming-R66093
2012-11-13 7:50 ` Huang Changming-R66093
2012-11-19 2:48 ` Huang Changming-R66093
2012-11-19 3:05 ` Anton Vorontsov
2012-11-19 3:11 ` Huang Changming-R66093
2012-10-30 23:08 ` [PATCH 1/4 v3] MMC/core: Add f_min to mmc_power_on() Ulf Hansson
2012-10-31 2:23 ` Huang Changming-R66093
2012-10-31 4:21 ` Jaehoon Chung [this message]
-- strict thread matches above, loose matches on Subject: below --
2011-12-09 2:53 r66093
2012-01-13 2:24 ` Huang Changming-R66093
2012-01-13 3:26 ` Aaron Lu
2012-01-13 3:39 ` Huang Changming-R66093
2012-01-13 6:32 ` Aaron Lu
2012-01-13 6:48 ` Huang Changming-R66093
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5090A73F.2020103@samsung.com \
--to=jh80.chung@samsung.com \
--cc=Chang-Ming.Huang@freescale.com \
--cc=cbouatmailru@gmail.com \
--cc=cjb@laptop.org \
--cc=linux-mmc@vger.kernel.org \
--cc=r66093@freescale.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).