From: Jaehoon Chung <jh80.chung@samsung.com>
To: Sergei Trofimovich <slyich@gmail.com>
Cc: Chris Ball <cjb@laptop.org>,
Sergei Trofimovich <slyfox@gentoo.org>,
Thomas Abraham <thomas.abraham@linaro.org>,
Will Newton <will.newton@imgtec.com>,
linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] exynos: mmc: use correct variable for MODULE_DEVICE_TABLE
Date: Wed, 31 Oct 2012 13:33:34 +0900 [thread overview]
Message-ID: <5090AA1E.1040005@samsung.com> (raw)
In-Reply-To: <1351635712-17214-1-git-send-email-slyich@gmail.com>
Looks good to me.
Acked-by: Jaehoon Chung <jh80.chung@samsung.com>
On 10/31/2012 07:21 AM, Sergei Trofimovich wrote:
> From: Sergei Trofimovich <slyfox@gentoo.org>
>
> Found by gcc:
>
> linux-2.6/drivers/mmc/host/dw_mmc-exynos.c: At top level:
> linux-2.6/drivers/mmc/host/dw_mmc-exynos.c:226:1: error: '__mod_of_device_table' aliased to undefined symbol 'dw_mci_pltfm_match'
>
> CC: Chris Ball <cjb@laptop.org>
> CC: Thomas Abraham <thomas.abraham@linaro.org>
> CC: Will Newton <will.newton@imgtec.com>
> CC: linux-mmc@vger.kernel.org
> CC: linux-kernel@vger.kernel.org
> Signed-off-by: Sergei Trofimovich <slyfox@gentoo.org>
> ---
> drivers/mmc/host/dw_mmc-exynos.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/dw_mmc-exynos.c b/drivers/mmc/host/dw_mmc-exynos.c
> index 660bbc5..0147ac3a 100644
> --- a/drivers/mmc/host/dw_mmc-exynos.c
> +++ b/drivers/mmc/host/dw_mmc-exynos.c
> @@ -223,7 +223,7 @@ static const struct of_device_id dw_mci_exynos_match[] = {
> .data = (void *)&exynos5250_drv_data, },
> {},
> };
> -MODULE_DEVICE_TABLE(of, dw_mci_pltfm_match);
> +MODULE_DEVICE_TABLE(of, dw_mci_exynos_match);
>
> int dw_mci_exynos_probe(struct platform_device *pdev)
> {
>
next prev parent reply other threads:[~2012-10-31 4:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-30 22:21 [PATCH] exynos: mmc: use correct variable for MODULE_DEVICE_TABLE Sergei Trofimovich
2012-10-31 4:33 ` Jaehoon Chung [this message]
2012-11-01 10:07 ` Seungwon Jeon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5090AA1E.1040005@samsung.com \
--to=jh80.chung@samsung.com \
--cc=cjb@laptop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=slyfox@gentoo.org \
--cc=slyich@gmail.com \
--cc=thomas.abraham@linaro.org \
--cc=will.newton@imgtec.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox