From: wwang <wei_wang@realsil.com.cn>
To: Chris Ball <cjb@laptop.org>
Cc: "sameo@linux.intel.com" <sameo@linux.intel.com>,
"devel@linuxdriverproject.org" <devel@linuxdriverproject.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"arnd@arndb.de" <arnd@arndb.de>,
"oakad@yahoo.com" <oakad@yahoo.com>,
"bp@alien8.de" <bp@alien8.de>
Subject: Re: [PATCH v2 1/2] mmc/host/rtsx: Configure SD_CFG2 register in sd_rw_multi
Date: Tue, 20 Nov 2012 10:40:14 +0800 [thread overview]
Message-ID: <50AAED8E.4030201@realsil.com.cn> (raw)
In-Reply-To: <87ip91f1zo.fsf@octavius.laptop.org>
于 2012年11月20日 10:21, Chris Ball 写道:
> Hi,
>
> Sorry to be pedantic, but:
>
> On Mon, Nov 19 2012, wei_wang@realsil.com.cn wrote:
>> For Realtek card reader, internal regsiter SD_CFG2 should be configured
>> before transferring data. In the prior version, the value of this register
>> has been calculated, but forgotten to write back to the internal register.
> With what consequences? Was the data transfer failing? Under which
> circumstances?
>
> Thanks,
>
> - Chris.
Hi Chris:
It's about compatibility issue. The default value of SD_CFG2 is proper
for writing data. But for reading sequence, the timing is not good
enough. So in some extreme circumstance, card reader may sample the
response data from the card as good even if the data is wrong. And this
will cause the bad consequence.
Shall I modify the commit and resend the patchset again?
BR,
Wei WANG
next prev parent reply other threads:[~2012-11-20 2:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-20 2:09 [PATCH v2 0/2] rtsx patch for for-next branch in MFD tree wei_wang
2012-11-20 2:09 ` [PATCH v2 1/2] mmc/host/rtsx: Configure SD_CFG2 register in sd_rw_multi wei_wang
2012-11-20 2:21 ` Chris Ball
2012-11-20 2:40 ` wwang [this message]
2012-11-20 3:09 ` Chris Ball
2012-11-20 2:09 ` [PATCH v2 2/2] mmc/host/rtsx: Explicitely include slab.h in rtsx_pci_sdmmc.c wei_wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50AAED8E.4030201@realsil.com.cn \
--to=wei_wang@realsil.com.cn \
--cc=arnd@arndb.de \
--cc=bp@alien8.de \
--cc=cjb@laptop.org \
--cc=devel@linuxdriverproject.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=oakad@yahoo.com \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox