From: Venkatraman S <svenkatr@ti.com>
To: Andreas Fenkart <andreas.fenkart@streamunlimited.com>
Cc: linux-mmc@vger.kernel.org, david.vrabel@csr.com, daniel@zonque.org
Subject: Re: [PATCH 1/3] mmc: omap_hsmmc: NULL pointer upon DTO after CC.
Date: Tue, 20 Nov 2012 13:06:43 +0530 [thread overview]
Message-ID: <50AB330B.1080500@ti.com> (raw)
In-Reply-To: <1353361379-21002-2-git-send-email-andreas.fenkart@streamunlimited.com>
On Tuesday 20 November 2012 03:12 AM, Andreas Fenkart wrote:
> Signed-off-by: Andreas Fenkart <andreas.fenkart@streamunlimited.com>
> ---
> drivers/mmc/host/omap_hsmmc.c | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mmc/host/omap_hsmmc.c b/drivers/mmc/host/omap_hsmmc.c
> index 21ca331..13ef4a0 100644
> --- a/drivers/mmc/host/omap_hsmmc.c
> +++ b/drivers/mmc/host/omap_hsmmc.c
> @@ -991,9 +991,12 @@ static inline void omap_hsmmc_reset_controller_fsm(struct omap_hsmmc_host *host,
> static void hsmmc_command_incomplete(struct omap_hsmmc_host *host, int err)
> {
> omap_hsmmc_reset_controller_fsm(host, SRC);
> - host->cmd->error = err;
> +
> + if (host->cmd)
> + host->cmd->error = err;
>
> if (host->data) {
> + host->data->error = err;
> omap_hsmmc_reset_controller_fsm(host, SRD);
> omap_hsmmc_dma_cleanup(host, err);
> }
> @@ -1022,7 +1025,7 @@ static void omap_hsmmc_do_irq(struct omap_hsmmc_host *host, int status)
> }
> }
>
> - if (end_cmd || ((status & CC) && host->cmd))
> + if ((end_cmd || (status & CC)) && host->cmd)
> omap_hsmmc_cmd_done(host, host->cmd);
> if ((end_trans || (status & TC)) && host->mrq)
> omap_hsmmc_xfer_done(host, data);
Hi Andreas,
Thanks for this, but it's been fixed already with Balaji's patches
which I reposted a few hours ago.
Can you please check if it fixes your issues ?
~V
next prev parent reply other threads:[~2012-11-20 7:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-19 21:42 [PATCH 0/3] mmc: omap_hsmmc: sdio irq am335x Andreas Fenkart
2012-11-19 21:42 ` [PATCH 1/3] mmc: omap_hsmmc: NULL pointer upon DTO after CC Andreas Fenkart
2012-11-20 7:36 ` Venkatraman S [this message]
2012-11-19 21:42 ` [PATCH 2/3] mmc: omap_hsmmc: Enable the use of SDIO card interrupts Andreas Fenkart
2012-11-19 21:42 ` [PATCH 3/3] MMC: omap_hsmmc: add DT property for ti-swakeup-not-implemented Andreas Fenkart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50AB330B.1080500@ti.com \
--to=svenkatr@ti.com \
--cc=andreas.fenkart@streamunlimited.com \
--cc=daniel@zonque.org \
--cc=david.vrabel@csr.com \
--cc=linux-mmc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).