* [PATCH v3 4/4] mmc: dw-mmc: remove complier warning
@ 2012-11-08 8:35 Jaehoon Chung
2012-11-19 12:23 ` James Hogan
0 siblings, 1 reply; 5+ messages in thread
From: Jaehoon Chung @ 2012-11-08 8:35 UTC (permalink / raw)
To: linux-mmc
Cc: Chris Ball, Kyungmin Park, Will Newton, James Hogan,
Seungwon Jeon
drivers/mmc/host/dw_mmc.c: In function 'dw_mci_prepare_command':
drivers/mmc/host/dw_mmc.c:256:37: warning: initialization discards 'const' qualifier from pointer target type [enabled by default]
drivers/mmc/host/dw_mmc.c: In function 'dw_mci_set_ios':
drivers/mmc/host/dw_mmc.c:805:37: warning: initialization discards 'const' qualifier from pointer target type [enabled by default]
drivers/mmc/host/dw_mmc.c: In function 'dw_mci_init_slot':
drivers/mmc/host/dw_mmc.c:1849:37: warning: initialization discards 'const' qualifier from pointer target type [enabled by default]
drivers/mmc/host/dw_mmc.c: In function 'dw_mci_parse_dt':
drivers/mmc/host/dw_mmc.c:2049:37: warning: initialization discards 'const' qualifier from pointer target type [enabled by default]
drivers/mmc/host/dw_mmc.c: In function 'dw_mci_probe':
drivers/mmc/host/dw_mmc.c:2095:37: warning: initialization discards 'const' qualifier from pointer target type [enabled by default]
Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com>
---
drivers/mmc/host/dw_mmc.c | 10 +++++-----
1 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c
index 9704b09..76c21e4 100644
--- a/drivers/mmc/host/dw_mmc.c
+++ b/drivers/mmc/host/dw_mmc.c
@@ -253,7 +253,7 @@ static u32 dw_mci_prepare_command(struct mmc_host *mmc, struct mmc_command *cmd)
{
struct mmc_data *data;
struct dw_mci_slot *slot = mmc_priv(mmc);
- struct dw_mci_drv_data *drv_data = slot->host->drv_data;
+ const struct dw_mci_drv_data *drv_data = slot->host->drv_data;
u32 cmdr;
cmd->error = -EINPROGRESS;
@@ -802,7 +802,7 @@ static void dw_mci_request(struct mmc_host *mmc, struct mmc_request *mrq)
static void dw_mci_set_ios(struct mmc_host *mmc, struct mmc_ios *ios)
{
struct dw_mci_slot *slot = mmc_priv(mmc);
- struct dw_mci_drv_data *drv_data = slot->host->drv_data;
+ const struct dw_mci_drv_data *drv_data = slot->host->drv_data;
u32 regs;
switch (ios->bus_width) {
@@ -1846,7 +1846,7 @@ static int dw_mci_init_slot(struct dw_mci *host, unsigned int id)
{
struct mmc_host *mmc;
struct dw_mci_slot *slot;
- struct dw_mci_drv_data *drv_data = host->drv_data;
+ const struct dw_mci_drv_data *drv_data = host->drv_data;
int ctrl_id, ret;
u8 bus_width;
@@ -2046,7 +2046,7 @@ static struct dw_mci_board *dw_mci_parse_dt(struct dw_mci *host)
struct dw_mci_board *pdata;
struct device *dev = host->dev;
struct device_node *np = dev->of_node;
- struct dw_mci_drv_data *drv_data = host->drv_data;
+ const struct dw_mci_drv_data *drv_data = host->drv_data;
int idx, ret;
pdata = devm_kzalloc(dev, sizeof(*pdata), GFP_KERNEL);
@@ -2092,7 +2092,7 @@ static struct dw_mci_board *dw_mci_parse_dt(struct dw_mci *host)
int dw_mci_probe(struct dw_mci *host)
{
- struct dw_mci_drv_data *drv_data = host->drv_data;
+ const struct dw_mci_drv_data *drv_data = host->drv_data;
int width, i, ret = 0;
u32 fifo_size;
int init_slots = 0;
--
1.7.4.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH v3 4/4] mmc: dw-mmc: remove complier warning
2012-11-08 8:35 [PATCH v3 4/4] mmc: dw-mmc: remove complier warning Jaehoon Chung
@ 2012-11-19 12:23 ` James Hogan
2012-11-19 12:53 ` James Hogan
0 siblings, 1 reply; 5+ messages in thread
From: James Hogan @ 2012-11-19 12:23 UTC (permalink / raw)
To: Jaehoon Chung
Cc: linux-mmc, Chris Ball, Kyungmin Park, Will Newton, Seungwon Jeon
On 08/11/12 08:35, Jaehoon Chung wrote:
> drivers/mmc/host/dw_mmc.c: In function 'dw_mci_prepare_command':
> drivers/mmc/host/dw_mmc.c:256:37: warning: initialization discards 'const' qualifier from pointer target type [enabled by default]
> drivers/mmc/host/dw_mmc.c: In function 'dw_mci_set_ios':
> drivers/mmc/host/dw_mmc.c:805:37: warning: initialization discards 'const' qualifier from pointer target type [enabled by default]
> drivers/mmc/host/dw_mmc.c: In function 'dw_mci_init_slot':
> drivers/mmc/host/dw_mmc.c:1849:37: warning: initialization discards 'const' qualifier from pointer target type [enabled by default]
> drivers/mmc/host/dw_mmc.c: In function 'dw_mci_parse_dt':
> drivers/mmc/host/dw_mmc.c:2049:37: warning: initialization discards 'const' qualifier from pointer target type [enabled by default]
> drivers/mmc/host/dw_mmc.c: In function 'dw_mci_probe':
> drivers/mmc/host/dw_mmc.c:2095:37: warning: initialization discards 'const' qualifier from pointer target type [enabled by default]
>
> Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com>
Acked-by: James Hogan <james.hogan@imgtec.com>
Thanks
James
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v3 4/4] mmc: dw-mmc: remove complier warning
2012-11-19 12:23 ` James Hogan
@ 2012-11-19 12:53 ` James Hogan
2012-11-20 1:40 ` Jaehoon Chung
0 siblings, 1 reply; 5+ messages in thread
From: James Hogan @ 2012-11-19 12:53 UTC (permalink / raw)
To: Chris Ball
Cc: Jaehoon Chung, linux-mmc, Kyungmin Park, Will Newton,
Seungwon Jeon
On 19/11/12 12:23, James Hogan wrote:
> On 08/11/12 08:35, Jaehoon Chung wrote:
>> drivers/mmc/host/dw_mmc.c: In function 'dw_mci_prepare_command':
>> drivers/mmc/host/dw_mmc.c:256:37: warning: initialization discards 'const' qualifier from pointer target type [enabled by default]
>> drivers/mmc/host/dw_mmc.c: In function 'dw_mci_set_ios':
>> drivers/mmc/host/dw_mmc.c:805:37: warning: initialization discards 'const' qualifier from pointer target type [enabled by default]
>> drivers/mmc/host/dw_mmc.c: In function 'dw_mci_init_slot':
>> drivers/mmc/host/dw_mmc.c:1849:37: warning: initialization discards 'const' qualifier from pointer target type [enabled by default]
>> drivers/mmc/host/dw_mmc.c: In function 'dw_mci_parse_dt':
>> drivers/mmc/host/dw_mmc.c:2049:37: warning: initialization discards 'const' qualifier from pointer target type [enabled by default]
>> drivers/mmc/host/dw_mmc.c: In function 'dw_mci_probe':
>> drivers/mmc/host/dw_mmc.c:2095:37: warning: initialization discards 'const' qualifier from pointer target type [enabled by default]
>>
>> Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com>
>
> Acked-by: James Hogan <james.hogan@imgtec.com>
Chris: Is it okay to get this patch into v3.7?
Thanks
James
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v3 4/4] mmc: dw-mmc: remove complier warning
2012-11-19 12:53 ` James Hogan
@ 2012-11-20 1:40 ` Jaehoon Chung
2012-11-20 9:06 ` James Hogan
0 siblings, 1 reply; 5+ messages in thread
From: Jaehoon Chung @ 2012-11-20 1:40 UTC (permalink / raw)
To: James Hogan
Cc: Chris Ball, linux-mmc, Kyungmin Park, Will Newton, Seungwon Jeon
Hi James,
This patch has already merged with Arnd's patch.
He also sent the same patch.
Best Regards,
Jaehoon Chung
On 11/19/2012 09:53 PM, James Hogan wrote:
> On 19/11/12 12:23, James Hogan wrote:
>> On 08/11/12 08:35, Jaehoon Chung wrote:
>>> drivers/mmc/host/dw_mmc.c: In function 'dw_mci_prepare_command':
>>> drivers/mmc/host/dw_mmc.c:256:37: warning: initialization discards 'const' qualifier from pointer target type [enabled by default]
>>> drivers/mmc/host/dw_mmc.c: In function 'dw_mci_set_ios':
>>> drivers/mmc/host/dw_mmc.c:805:37: warning: initialization discards 'const' qualifier from pointer target type [enabled by default]
>>> drivers/mmc/host/dw_mmc.c: In function 'dw_mci_init_slot':
>>> drivers/mmc/host/dw_mmc.c:1849:37: warning: initialization discards 'const' qualifier from pointer target type [enabled by default]
>>> drivers/mmc/host/dw_mmc.c: In function 'dw_mci_parse_dt':
>>> drivers/mmc/host/dw_mmc.c:2049:37: warning: initialization discards 'const' qualifier from pointer target type [enabled by default]
>>> drivers/mmc/host/dw_mmc.c: In function 'dw_mci_probe':
>>> drivers/mmc/host/dw_mmc.c:2095:37: warning: initialization discards 'const' qualifier from pointer target type [enabled by default]
>>>
>>> Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com>
>>
>> Acked-by: James Hogan <james.hogan@imgtec.com>
>
> Chris: Is it okay to get this patch into v3.7?
>
> Thanks
> James
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v3 4/4] mmc: dw-mmc: remove complier warning
2012-11-20 1:40 ` Jaehoon Chung
@ 2012-11-20 9:06 ` James Hogan
0 siblings, 0 replies; 5+ messages in thread
From: James Hogan @ 2012-11-20 9:06 UTC (permalink / raw)
To: Jaehoon Chung
Cc: Chris Ball, linux-mmc, Kyungmin Park, Will Newton, Seungwon Jeon
On 20/11/12 01:40, Jaehoon Chung wrote:
> Hi James,
>
> This patch has already merged with Arnd's patch.
> He also sent the same patch.
Ah yes :-)
Thanks
James
>
> Best Regards,
> Jaehoon Chung
>
> On 11/19/2012 09:53 PM, James Hogan wrote:
>> On 19/11/12 12:23, James Hogan wrote:
>>> On 08/11/12 08:35, Jaehoon Chung wrote:
>>>> drivers/mmc/host/dw_mmc.c: In function 'dw_mci_prepare_command':
>>>> drivers/mmc/host/dw_mmc.c:256:37: warning: initialization discards 'const' qualifier from pointer target type [enabled by default]
>>>> drivers/mmc/host/dw_mmc.c: In function 'dw_mci_set_ios':
>>>> drivers/mmc/host/dw_mmc.c:805:37: warning: initialization discards 'const' qualifier from pointer target type [enabled by default]
>>>> drivers/mmc/host/dw_mmc.c: In function 'dw_mci_init_slot':
>>>> drivers/mmc/host/dw_mmc.c:1849:37: warning: initialization discards 'const' qualifier from pointer target type [enabled by default]
>>>> drivers/mmc/host/dw_mmc.c: In function 'dw_mci_parse_dt':
>>>> drivers/mmc/host/dw_mmc.c:2049:37: warning: initialization discards 'const' qualifier from pointer target type [enabled by default]
>>>> drivers/mmc/host/dw_mmc.c: In function 'dw_mci_probe':
>>>> drivers/mmc/host/dw_mmc.c:2095:37: warning: initialization discards 'const' qualifier from pointer target type [enabled by default]
>>>>
>>>> Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com>
>>>
>>> Acked-by: James Hogan <james.hogan@imgtec.com>
>>
>> Chris: Is it okay to get this patch into v3.7?
>>
>> Thanks
>> James
>>
>>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2012-11-20 9:06 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-11-08 8:35 [PATCH v3 4/4] mmc: dw-mmc: remove complier warning Jaehoon Chung
2012-11-19 12:23 ` James Hogan
2012-11-19 12:53 ` James Hogan
2012-11-20 1:40 ` Jaehoon Chung
2012-11-20 9:06 ` James Hogan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).