* [PATCH v3 2/4] mmc: dw-mmc: remove the duplicated code
@ 2012-11-08 8:35 Jaehoon Chung
2012-11-27 8:01 ` Seungwon Jeon
2012-12-03 19:46 ` Chris Ball
0 siblings, 2 replies; 5+ messages in thread
From: Jaehoon Chung @ 2012-11-08 8:35 UTC (permalink / raw)
To: linux-mmc
Cc: Chris Ball, Kyungmin Park, Will Newton, James Hogan,
Seungwon Jeon
ctype is used 1-bit buswidth mode by default.
Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com>
Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
---
drivers/mmc/host/dw_mmc.c | 9 +++------
1 files changed, 3 insertions(+), 6 deletions(-)
diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c
index a1369aa..0a80b5c 100644
--- a/drivers/mmc/host/dw_mmc.c
+++ b/drivers/mmc/host/dw_mmc.c
@@ -773,19 +773,16 @@ static void dw_mci_set_ios(struct mmc_host *mmc, struct mmc_ios *ios)
struct dw_mci_drv_data *drv_data = slot->host->drv_data;
u32 regs;
- /* set default 1 bit mode */
- slot->ctype = SDMMC_CTYPE_1BIT;
-
switch (ios->bus_width) {
- case MMC_BUS_WIDTH_1:
- slot->ctype = SDMMC_CTYPE_1BIT;
- break;
case MMC_BUS_WIDTH_4:
slot->ctype = SDMMC_CTYPE_4BIT;
break;
case MMC_BUS_WIDTH_8:
slot->ctype = SDMMC_CTYPE_8BIT;
break;
+ default:
+ /* set default 1 bit mode */
+ slot->ctype = SDMMC_CTYPE_1BIT;
}
regs = mci_readl(slot->host, UHS_REG);
--
1.7.4.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* RE: [PATCH v3 2/4] mmc: dw-mmc: remove the duplicated code
2012-11-08 8:35 [PATCH v3 2/4] mmc: dw-mmc: remove the duplicated code Jaehoon Chung
@ 2012-11-27 8:01 ` Seungwon Jeon
2012-11-27 9:41 ` James Hogan
2012-12-03 19:46 ` Chris Ball
1 sibling, 1 reply; 5+ messages in thread
From: Seungwon Jeon @ 2012-11-27 8:01 UTC (permalink / raw)
To: 'Jaehoon Chung', 'linux-mmc'
Cc: 'Chris Ball', 'Kyungmin Park',
'Will Newton', 'James Hogan'
This is minor change.
Acked-by: Seungwon Jeon <tgih.jun@samsung.com>
Thanks,
Seungwon Jeon
On Thursday, November 08, 2012, Jaehoon Chung <jh80.chung@samsung.com> wrote:
> ctype is used 1-bit buswidth mode by default.
>
> Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com>
> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
> ---
> drivers/mmc/host/dw_mmc.c | 9 +++------
> 1 files changed, 3 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c
> index a1369aa..0a80b5c 100644
> --- a/drivers/mmc/host/dw_mmc.c
> +++ b/drivers/mmc/host/dw_mmc.c
> @@ -773,19 +773,16 @@ static void dw_mci_set_ios(struct mmc_host *mmc, struct mmc_ios *ios)
> struct dw_mci_drv_data *drv_data = slot->host->drv_data;
> u32 regs;
>
> - /* set default 1 bit mode */
> - slot->ctype = SDMMC_CTYPE_1BIT;
> -
> switch (ios->bus_width) {
> - case MMC_BUS_WIDTH_1:
> - slot->ctype = SDMMC_CTYPE_1BIT;
> - break;
> case MMC_BUS_WIDTH_4:
> slot->ctype = SDMMC_CTYPE_4BIT;
> break;
> case MMC_BUS_WIDTH_8:
> slot->ctype = SDMMC_CTYPE_8BIT;
> break;
> + default:
> + /* set default 1 bit mode */
> + slot->ctype = SDMMC_CTYPE_1BIT;
> }
>
> regs = mci_readl(slot->host, UHS_REG);
> --
> 1.7.4.1
> --
> To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH v3 2/4] mmc: dw-mmc: remove the duplicated code
2012-11-27 8:01 ` Seungwon Jeon
@ 2012-11-27 9:41 ` James Hogan
2012-11-29 15:03 ` Jae hoon Chung
0 siblings, 1 reply; 5+ messages in thread
From: James Hogan @ 2012-11-27 9:41 UTC (permalink / raw)
To: Seungwon Jeon
Cc: 'Jaehoon Chung', 'linux-mmc',
'Chris Ball', 'Kyungmin Park',
'Will Newton'
On 27/11/12 08:01, Seungwon Jeon wrote:
> This is minor change.
>
> Acked-by: Seungwon Jeon <tgih.jun@samsung.com>
>
> Thanks,
> Seungwon Jeon
Looks good to me too.
Acked-by: James Hogan <james.hogan@imgtec.com>
>
> On Thursday, November 08, 2012, Jaehoon Chung <jh80.chung@samsung.com> wrote:
>> ctype is used 1-bit buswidth mode by default.
>>
>> Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com>
>> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
>> ---
>> drivers/mmc/host/dw_mmc.c | 9 +++------
>> 1 files changed, 3 insertions(+), 6 deletions(-)
>>
>> diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c
>> index a1369aa..0a80b5c 100644
>> --- a/drivers/mmc/host/dw_mmc.c
>> +++ b/drivers/mmc/host/dw_mmc.c
>> @@ -773,19 +773,16 @@ static void dw_mci_set_ios(struct mmc_host *mmc, struct mmc_ios *ios)
>> struct dw_mci_drv_data *drv_data = slot->host->drv_data;
>> u32 regs;
>>
>> - /* set default 1 bit mode */
>> - slot->ctype = SDMMC_CTYPE_1BIT;
>> -
>> switch (ios->bus_width) {
>> - case MMC_BUS_WIDTH_1:
>> - slot->ctype = SDMMC_CTYPE_1BIT;
>> - break;
>> case MMC_BUS_WIDTH_4:
>> slot->ctype = SDMMC_CTYPE_4BIT;
>> break;
>> case MMC_BUS_WIDTH_8:
>> slot->ctype = SDMMC_CTYPE_8BIT;
>> break;
>> + default:
>> + /* set default 1 bit mode */
>> + slot->ctype = SDMMC_CTYPE_1BIT;
>> }
>>
>> regs = mci_readl(slot->host, UHS_REG);
>> --
>> 1.7.4.1
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH v3 2/4] mmc: dw-mmc: remove the duplicated code
2012-11-27 9:41 ` James Hogan
@ 2012-11-29 15:03 ` Jae hoon Chung
0 siblings, 0 replies; 5+ messages in thread
From: Jae hoon Chung @ 2012-11-29 15:03 UTC (permalink / raw)
To: James Hogan
Cc: Seungwon Jeon, Jaehoon Chung, linux-mmc, Chris Ball,
Kyungmin Park, Will Newton
Acked-by: Jaehoon Chung <jh80.chung@samsung.com>
2012/11/27 James Hogan <james.hogan@imgtec.com>:
> On 27/11/12 08:01, Seungwon Jeon wrote:
>> This is minor change.
>>
>> Acked-by: Seungwon Jeon <tgih.jun@samsung.com>
>>
>> Thanks,
>> Seungwon Jeon
>
> Looks good to me too.
> Acked-by: James Hogan <james.hogan@imgtec.com>
>
>>
>> On Thursday, November 08, 2012, Jaehoon Chung <jh80.chung@samsung.com> wrote:
>>> ctype is used 1-bit buswidth mode by default.
>>>
>>> Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com>
>>> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
>>> ---
>>> drivers/mmc/host/dw_mmc.c | 9 +++------
>>> 1 files changed, 3 insertions(+), 6 deletions(-)
>>>
>>> diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c
>>> index a1369aa..0a80b5c 100644
>>> --- a/drivers/mmc/host/dw_mmc.c
>>> +++ b/drivers/mmc/host/dw_mmc.c
>>> @@ -773,19 +773,16 @@ static void dw_mci_set_ios(struct mmc_host *mmc, struct mmc_ios *ios)
>>> struct dw_mci_drv_data *drv_data = slot->host->drv_data;
>>> u32 regs;
>>>
>>> - /* set default 1 bit mode */
>>> - slot->ctype = SDMMC_CTYPE_1BIT;
>>> -
>>> switch (ios->bus_width) {
>>> - case MMC_BUS_WIDTH_1:
>>> - slot->ctype = SDMMC_CTYPE_1BIT;
>>> - break;
>>> case MMC_BUS_WIDTH_4:
>>> slot->ctype = SDMMC_CTYPE_4BIT;
>>> break;
>>> case MMC_BUS_WIDTH_8:
>>> slot->ctype = SDMMC_CTYPE_8BIT;
>>> break;
>>> + default:
>>> + /* set default 1 bit mode */
>>> + slot->ctype = SDMMC_CTYPE_1BIT;
>>> }
>>>
>>> regs = mci_readl(slot->host, UHS_REG);
>>> --
>>> 1.7.4.1
>>> --
>>> To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
>>> the body of a message to majordomo@vger.kernel.org
>>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v3 2/4] mmc: dw-mmc: remove the duplicated code
2012-11-08 8:35 [PATCH v3 2/4] mmc: dw-mmc: remove the duplicated code Jaehoon Chung
2012-11-27 8:01 ` Seungwon Jeon
@ 2012-12-03 19:46 ` Chris Ball
1 sibling, 0 replies; 5+ messages in thread
From: Chris Ball @ 2012-12-03 19:46 UTC (permalink / raw)
To: Jaehoon Chung
Cc: linux-mmc, Kyungmin Park, Will Newton, James Hogan, Seungwon Jeon
Hi,
On Thu, Nov 08 2012, Jaehoon Chung wrote:
> ctype is used 1-bit buswidth mode by default.
>
> Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com>
> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
Thanks, pushed to mmc-next for 3.8.
- Chris.
--
Chris Ball <cjb@laptop.org> <http://printf.net/>
One Laptop Per Child
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2012-12-03 19:46 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-11-08 8:35 [PATCH v3 2/4] mmc: dw-mmc: remove the duplicated code Jaehoon Chung
2012-11-27 8:01 ` Seungwon Jeon
2012-11-27 9:41 ` James Hogan
2012-11-29 15:03 ` Jae hoon Chung
2012-12-03 19:46 ` Chris Ball
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).