linux-mmc.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Konstantin Dorfman <kdorfman@codeaurora.org>
To: "Zhang, YiX X" <yix.x.zhang@intel.com>
Cc: "cjb@laptop.org" <cjb@laptop.org>,
	"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mmc: correct the EXCEPTION_EVENTS_STATUS vaule comment
Date: Tue, 08 Jan 2013 10:22:55 +0200	[thread overview]
Message-ID: <50EBD75F.7050805@codeaurora.org> (raw)
In-Reply-To: <1A230AD7863570458C6CF2BE7CD6618B102BE5CB@SHSMSX102.ccr.corp.intel.com>


May be it is worth to change all this struct comments to be:

u8	raw_exception_status;	/* EXT_CSD_EXP_EVENTS_STATUS */

This will reference actual offset value from "include/linux/mmc/mmc.h"

Thanks,

On 01/08/2013 08:07 AM, Zhang, YiX X wrote:
>  From aaea3405944d844f53679b295d4082584f33d9a3 Mon Sep 17 00:00:00 2001
> From: ZhangYi <yix.x.zhang@intel.com>
> Date: Tue, 8 Jan 2013 13:50:09 +0800
> Subject: [PATCH] mmc: correct the EXCEPTION_EVENTS_STATUS vaule comment
>
> The right value is 54 according to eMMC 4.5 specification.
>
> Signed-off-by: ZhangYi <yix.x.zhang@intel.com>
> ---
>   include/linux/mmc/card.h |    2 +-
>   1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/include/linux/mmc/card.h b/include/linux/mmc/card.h
> index 5c69315..ffde1d3 100644
> --- a/include/linux/mmc/card.h
> +++ b/include/linux/mmc/card.h
> @@ -83,7 +83,7 @@ struct mmc_ext_csd {
>   	unsigned int            data_tag_unit_size;     /* DATA TAG UNIT size */
>   	unsigned int		boot_ro_lock;		/* ro lock support */
>   	bool			boot_ro_lockable;
> -	u8			raw_exception_status;	/* 53 */
> +	u8			raw_exception_status;	/* 54 */
>   	u8			raw_partition_support;	/* 160 */
>   	u8			raw_rpmb_size_mult;	/* 168 */
>   	u8			raw_erased_mem_count;	/* 181 */
>


-- 
Konstantin Dorfman,
QUALCOMM ISRAEL, on behalf of Qualcomm Innovation Center,
Inc. is a member of Code Aurora Forum,
hosted by The Linux Foundation

  reply	other threads:[~2013-01-08  8:23 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-08  6:07 [PATCH] mmc: correct the EXCEPTION_EVENTS_STATUS vaule comment Zhang, YiX X
2013-01-08  8:22 ` Konstantin Dorfman [this message]
2013-01-08 10:14   ` Zhang, YiX X
2013-01-16 14:53   ` [PATCH v2] mmc: correct one comment error of structure mmc_ext_csd yix.x.zhang
2013-01-28 20:56   ` [PATCH] mmc: correct the EXCEPTION_EVENTS_STATUS vaule comment Chris Ball

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50EBD75F.7050805@codeaurora.org \
    --to=kdorfman@codeaurora.org \
    --cc=cjb@laptop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=yix.x.zhang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).