* RE: [PATCH] mmc: correct the EXCEPTION_EVENTS_STATUS vaule comment
2013-01-08 8:22 ` Konstantin Dorfman
@ 2013-01-08 10:14 ` Zhang, YiX X
2013-01-16 14:53 ` [PATCH v2] mmc: correct one comment error of structure mmc_ext_csd yix.x.zhang
2013-01-28 20:56 ` [PATCH] mmc: correct the EXCEPTION_EVENTS_STATUS vaule comment Chris Ball
2 siblings, 0 replies; 5+ messages in thread
From: Zhang, YiX X @ 2013-01-08 10:14 UTC (permalink / raw)
To: Konstantin Dorfman
Cc: cjb@laptop.org, linux-mmc@vger.kernel.org,
linux-kernel@vger.kernel.org
yes, you are right, I will change them later, thanks.
Regards
Zhang,Yi.
-----Original Message-----
From: linux-mmc-owner@vger.kernel.org [mailto:linux-mmc-owner@vger.kernel.org] On Behalf Of Konstantin Dorfman
Sent: Tuesday, January 08, 2013 4:23 PM
To: Zhang, YiX X
Cc: cjb@laptop.org; linux-mmc@vger.kernel.org; linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mmc: correct the EXCEPTION_EVENTS_STATUS vaule comment
May be it is worth to change all this struct comments to be:
u8 raw_exception_status; /* EXT_CSD_EXP_EVENTS_STATUS */
This will reference actual offset value from "include/linux/mmc/mmc.h"
Thanks,
On 01/08/2013 08:07 AM, Zhang, YiX X wrote:
> From aaea3405944d844f53679b295d4082584f33d9a3 Mon Sep 17 00:00:00
> 2001
> From: ZhangYi <yix.x.zhang@intel.com>
> Date: Tue, 8 Jan 2013 13:50:09 +0800
> Subject: [PATCH] mmc: correct the EXCEPTION_EVENTS_STATUS vaule
> comment
>
> The right value is 54 according to eMMC 4.5 specification.
>
> Signed-off-by: ZhangYi <yix.x.zhang@intel.com>
> ---
> include/linux/mmc/card.h | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/include/linux/mmc/card.h b/include/linux/mmc/card.h index
> 5c69315..ffde1d3 100644
> --- a/include/linux/mmc/card.h
> +++ b/include/linux/mmc/card.h
> @@ -83,7 +83,7 @@ struct mmc_ext_csd {
> unsigned int data_tag_unit_size; /* DATA TAG UNIT size */
> unsigned int boot_ro_lock; /* ro lock support */
> bool boot_ro_lockable;
> - u8 raw_exception_status; /* 53 */
> + u8 raw_exception_status; /* 54 */
> u8 raw_partition_support; /* 160 */
> u8 raw_rpmb_size_mult; /* 168 */
> u8 raw_erased_mem_count; /* 181 */
>
--
Konstantin Dorfman,
QUALCOMM ISRAEL, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 5+ messages in thread* [PATCH v2] mmc: correct one comment error of structure mmc_ext_csd
2013-01-08 8:22 ` Konstantin Dorfman
2013-01-08 10:14 ` Zhang, YiX X
@ 2013-01-16 14:53 ` yix.x.zhang
2013-01-28 20:56 ` [PATCH] mmc: correct the EXCEPTION_EVENTS_STATUS vaule comment Chris Ball
2 siblings, 0 replies; 5+ messages in thread
From: yix.x.zhang @ 2013-01-16 14:53 UTC (permalink / raw)
To: cjb; +Cc: linux-mmc, linux-kernel, Zhang, Yi
From: "Zhang, Yi" <yix.x.zhang@gmail.com>
The right value for field raw_exception_status is 54(not 53) according
to eMMC 4.5 specification. Also for more readable, replace all number
values with macro symboles.
Signed-off-by: Zhang, Yi <yix.x.zhang@gmail.com>
---
include/linux/mmc/card.h | 34 +++++++++++++++++-----------------
1 file changed, 17 insertions(+), 17 deletions(-)
diff --git a/include/linux/mmc/card.h b/include/linux/mmc/card.h
index 5c69315..d270392 100644
--- a/include/linux/mmc/card.h
+++ b/include/linux/mmc/card.h
@@ -83,23 +83,23 @@ struct mmc_ext_csd {
unsigned int data_tag_unit_size; /* DATA TAG UNIT size */
unsigned int boot_ro_lock; /* ro lock support */
bool boot_ro_lockable;
- u8 raw_exception_status; /* 53 */
- u8 raw_partition_support; /* 160 */
- u8 raw_rpmb_size_mult; /* 168 */
- u8 raw_erased_mem_count; /* 181 */
- u8 raw_ext_csd_structure; /* 194 */
- u8 raw_card_type; /* 196 */
- u8 out_of_int_time; /* 198 */
- u8 raw_s_a_timeout; /* 217 */
- u8 raw_hc_erase_gap_size; /* 221 */
- u8 raw_erase_timeout_mult; /* 223 */
- u8 raw_hc_erase_grp_size; /* 224 */
- u8 raw_sec_trim_mult; /* 229 */
- u8 raw_sec_erase_mult; /* 230 */
- u8 raw_sec_feature_support;/* 231 */
- u8 raw_trim_mult; /* 232 */
- u8 raw_bkops_status; /* 246 */
- u8 raw_sectors[4]; /* 212 - 4 bytes */
+ u8 raw_exception_status; /* EXT_CSD_EXP_EVENTS_STATUS */
+ u8 raw_partition_support; /* EXT_CSD_PARTITION_SUPPORT */
+ u8 raw_rpmb_size_mult; /* EXT_CSD_RPMB_MULT */
+ u8 raw_erased_mem_count; /* EXT_CSD_ERASED_MEM_CONT */
+ u8 raw_ext_csd_structure; /* EXT_CSD_STRUCTURE */
+ u8 raw_card_type; /* EXT_CSD_CARD_TYPE */
+ u8 out_of_int_time; /* EXT_CSD_OUT_OF_INTERRUPT_TIME */
+ u8 raw_s_a_timeout; /* EXT_CSD_S_A_TIMEOUT */
+ u8 raw_hc_erase_gap_size; /* EXT_CSD_HC_WP_GRP_SIZE */
+ u8 raw_erase_timeout_mult; /* EXT_CSD_ERASE_TIMEOUT_MULT */
+ u8 raw_hc_erase_grp_size; /* EXT_CSD_HC_ERASE_GRP_SIZE */
+ u8 raw_sec_trim_mult; /* EXT_CSD_SEC_TRIM_MULT */
+ u8 raw_sec_erase_mult; /* EXT_CSD_SEC_ERASE_MULT */
+ u8 raw_sec_feature_support;/* EXT_CSD_SEC_FEATURE_SUPPORT */
+ u8 raw_trim_mult; /* EXT_CSD_TRIM_MULT */
+ u8 raw_bkops_status; /* EXT_CSD_BKOPS_STATUS */
+ u8 raw_sectors[4]; /* EXT_CSD_SEC_CNT - 4 bytes */
unsigned int feature_support;
#define MMC_DISCARD_FEATURE BIT(0) /* CMD38 feature */
--
1.7.10.4
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] mmc: correct the EXCEPTION_EVENTS_STATUS vaule comment
2013-01-08 8:22 ` Konstantin Dorfman
2013-01-08 10:14 ` Zhang, YiX X
2013-01-16 14:53 ` [PATCH v2] mmc: correct one comment error of structure mmc_ext_csd yix.x.zhang
@ 2013-01-28 20:56 ` Chris Ball
2 siblings, 0 replies; 5+ messages in thread
From: Chris Ball @ 2013-01-28 20:56 UTC (permalink / raw)
To: Konstantin Dorfman
Cc: Zhang, YiX X, linux-mmc@vger.kernel.org,
linux-kernel@vger.kernel.org
Hi,
On Tue, Jan 08 2013, Konstantin Dorfman wrote:
> May be it is worth to change all this struct comments to be:
>
> u8 raw_exception_status; /* EXT_CSD_EXP_EVENTS_STATUS */
>
> This will reference actual offset value from "include/linux/mmc/mmc.h"
I think I prefer having the literal numbers accessible, even though it
duplicates data, so I've taken Zhang's original patch for now.
Thanks,
- Chris.
--
Chris Ball <cjb@laptop.org> <http://printf.net/>
One Laptop Per Child
^ permalink raw reply [flat|nested] 5+ messages in thread