From: Jaehoon Chung <jh80.chung@samsung.com>
To: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Cc: Joonyoung Shim <jy0922.shim@samsung.com>,
cjb@laptop.org, linux-mmc@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mmc: fix to refer NULL pointer
Date: Mon, 28 Jan 2013 11:14:08 +0900 [thread overview]
Message-ID: <5105DEF0.5000507@samsung.com> (raw)
In-Reply-To: <Pine.LNX.4.64.1301270906270.5137@axis700.grange>
On 01/27/2013 05:10 PM, Guennadi Liakhovetski wrote:
> On Sat, 26 Jan 2013, Joonyoung Shim wrote:
>
>> Check whether host->sdio_irq_thread is NULL before wake_up_process() is
>> called about host->sdio_irq_thread.
>
> Actually, mmc_signal_sdio_irq() shouldn't be called if SDIO IRQ isn't
> used...
Right, But I think that need to check whether the host->sdio_irq_thread is assigned or not.
Best Regards,
Jaehoon Chung
>
> Thanks
> Guennadi
>
>>
>> Signed-off-by: Joonyoung Shim <jy0922.shim@samsung.com>
>> ---
>> Currently the kernel panic to refer NULL pointer about
>> host->sdio_irq_thread are occuring at the trats board using Samsung
>> SDHCI driver.
>>
>> include/linux/mmc/host.h | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/include/linux/mmc/host.h b/include/linux/mmc/host.h
>> index 61a10c1..2950fea 100644
>> --- a/include/linux/mmc/host.h
>> +++ b/include/linux/mmc/host.h
>> @@ -372,7 +372,8 @@ static inline void mmc_signal_sdio_irq(struct mmc_host *host)
>> {
>> host->ops->enable_sdio_irq(host, 0);
>> host->sdio_irq_pending = true;
>> - wake_up_process(host->sdio_irq_thread);
>> + if (host->sdio_irq_thread)
>> + wake_up_process(host->sdio_irq_thread);
>> }
>>
>> #ifdef CONFIG_REGULATOR
>> --
>> 1.7.9.5
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>>
>
> ---
> Guennadi Liakhovetski, Ph.D.
> Freelance Open-Source Software Developer
> http://www.open-technology.de/
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>
prev parent reply other threads:[~2013-01-28 2:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-26 5:19 [PATCH] mmc: fix to refer NULL pointer Joonyoung Shim
2013-01-27 8:10 ` Guennadi Liakhovetski
2013-01-28 2:14 ` Jaehoon Chung [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5105DEF0.5000507@samsung.com \
--to=jh80.chung@samsung.com \
--cc=cjb@laptop.org \
--cc=g.liakhovetski@gmx.de \
--cc=jy0922.shim@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).