From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marek Szyprowski Subject: Re: [PATCH 3/3 RESEND] mmc: sdhci: check voltage range only on regulators aware of voltage value Date: Thu, 14 Feb 2013 09:05:43 +0100 Message-ID: <511C9AD7.6000904@samsung.com> References: <87bobqrcb4.fsf@octavius.laptop.org> <1360656096-1671-1-git-send-email-m.szyprowski@samsung.com> <511B41B8.3060506@samsung.com> <20130213113525.GB5062@opensource.wolfsonmicro.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from mailout4.w1.samsung.com ([210.118.77.14]:40138 "EHLO mailout4.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756160Ab3BNIFr (ORCPT ); Thu, 14 Feb 2013 03:05:47 -0500 In-reply-to: <20130213113525.GB5062@opensource.wolfsonmicro.com> Sender: linux-mmc-owner@vger.kernel.org List-Id: linux-mmc@vger.kernel.org To: Mark Brown Cc: Guennadi Liakhovetski , linux-kernel@vger.kernel.org, linux-mmc@vger.kernel.org, Kyungmin Park , Liam Girdwood , Chris Ball , Kevin Liu On 2/13/2013 12:35 PM, Mark Brown wrote: > On Wed, Feb 13, 2013 at 08:45:56AM +0100, Guennadi Liakhovetski wrote: > > On Wed, 13 Feb 2013, Marek Szyprowski wrote: > > > > BTW, mmc_regulator_get_ocrmask() won't work with continuous range regulators. > > > This seems like a problem, that has to be fixed... > > Indeed, what's the issue? There are probably 2 issues: 1. mmc_regulator_get_ocrmask() works only with regulators which support regulator_count_voltages() and regulator_list_voltage(). Recently support for continuous regulators have been merged. Such regulators doesn't provide regulator_list_voltage() method, but are able to change/set voltage to the given value. I agree that they are not very common, so right now we can probably ignore them until the first board, which uses them arrives. 2. The second issue might be related to the testing of precise voltage values in the ocr mask, not the whole allowed ranges. Such issues in sdhci.c driver has been recently fixed by commit cec2e216f72c6b5ccdadb60aadbe99821d744503 ("mmc: sdhci: Use regulator min/max voltage range according to spec"), but I don't know MMC core code to judge if ocr mask is used for exact voltage checking or only for checking the voltage ranges. However someone with good mmc subsystem knowledge should check it. Best regards -- Marek Szyprowski Samsung Poland R&D Center