[PATCH 1/2] mmc: dw_mmc: Make dw_mci_exynos_probe static

[PATCH 1/2] mmc: dw_mmc: Make dw_mci_exynos_probe static

[Sachin Kamat]

Silences the following sparse warning:
drivers/mmc/host/dw_mmc-exynos.c:218:5: warning:
symbol 'dw_mci_exynos_probe' was not declared. Should it be static?

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
---
 drivers/mmc/host/dw_mmc-exynos.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/mmc/host/dw_mmc-exynos.c b/drivers/mmc/host/dw_mmc-exynos.c
index 72fd0f2..5a09c77 100644
--- a/drivers/mmc/host/dw_mmc-exynos.c
+++ b/drivers/mmc/host/dw_mmc-exynos.c
@@ -215,7 +215,7 @@ static const struct of_device_id dw_mci_exynos_match[] = {
 };
 MODULE_DEVICE_TABLE(of, dw_mci_exynos_match);
 
-int dw_mci_exynos_probe(struct platform_device *pdev)
+static int dw_mci_exynos_probe(struct platform_device *pdev)
 {
 	const struct dw_mci_drv_data *drv_data;
 	const struct of_device_id *match;
-- 
1.7.4.1

[PATCH 2/2] mmc: dw_mmc: exynos: Remove unnecessary use of of_match_ptr()

[Sachin Kamat]

'dw_mci_exynos_match' is always compiled in. Hence of_match_ptr
is not required.

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
---
 drivers/mmc/host/dw_mmc-exynos.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/mmc/host/dw_mmc-exynos.c b/drivers/mmc/host/dw_mmc-exynos.c
index 5a09c77..517a603 100644
--- a/drivers/mmc/host/dw_mmc-exynos.c
+++ b/drivers/mmc/host/dw_mmc-exynos.c
@@ -230,7 +230,7 @@ static struct platform_driver dw_mci_exynos_pltfm_driver = {
 	.remove		= __exit_p(dw_mci_pltfm_remove),
 	.driver		= {
 		.name		= "dwmmc_exynos",
-		.of_match_table	= of_match_ptr(dw_mci_exynos_match),
+		.of_match_table	= dw_mci_exynos_match,
 		.pm		= &dw_mci_pltfm_pmops,
 	},
 };
-- 
1.7.4.1

Re: [PATCH 1/2] mmc: dw_mmc: Make dw_mci_exynos_probe static

[Jaehoon Chung]

Acked-by: Jaehoon Chung <jh80.chung@samsung.com>

On 02/18/2013 05:53 PM, Sachin Kamat wrote:
> Silences the following sparse warning:
> drivers/mmc/host/dw_mmc-exynos.c:218:5: warning:
> symbol 'dw_mci_exynos_probe' was not declared. Should it be static?
> 
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> ---
>  drivers/mmc/host/dw_mmc-exynos.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/mmc/host/dw_mmc-exynos.c b/drivers/mmc/host/dw_mmc-exynos.c
> index 72fd0f2..5a09c77 100644
> --- a/drivers/mmc/host/dw_mmc-exynos.c
> +++ b/drivers/mmc/host/dw_mmc-exynos.c
> @@ -215,7 +215,7 @@ static const struct of_device_id dw_mci_exynos_match[] = {
>  };
>  MODULE_DEVICE_TABLE(of, dw_mci_exynos_match);
>  
> -int dw_mci_exynos_probe(struct platform_device *pdev)
> +static int dw_mci_exynos_probe(struct platform_device *pdev)
>  {
>  	const struct dw_mci_drv_data *drv_data;
>  	const struct of_device_id *match;
> 

RE: [PATCH 1/2] mmc: dw_mmc: Make dw_mci_exynos_probe static

[Seungwon Jeon]

Hi Sachin,

You're right.
'dw_mci_exynos_probe' is only used here.

Acked-by: Seungwon Jeon <tgih.jun@samsung.com>

On Monday, February 18, 2013, Jaehoon Chung wrote:
> Acked-by: Jaehoon Chung <jh80.chung@samsung.com>
> 
> On 02/18/2013 05:53 PM, Sachin Kamat wrote:
> > Silences the following sparse warning:
> > drivers/mmc/host/dw_mmc-exynos.c:218:5: warning:
> > symbol 'dw_mci_exynos_probe' was not declared. Should it be static?
> >
> > Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> > ---
> >  drivers/mmc/host/dw_mmc-exynos.c |    2 +-
> >  1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/drivers/mmc/host/dw_mmc-exynos.c b/drivers/mmc/host/dw_mmc-exynos.c
> > index 72fd0f2..5a09c77 100644
> > --- a/drivers/mmc/host/dw_mmc-exynos.c
> > +++ b/drivers/mmc/host/dw_mmc-exynos.c
> > @@ -215,7 +215,7 @@ static const struct of_device_id dw_mci_exynos_match[] = {
> >  };
> >  MODULE_DEVICE_TABLE(of, dw_mci_exynos_match);
> >
> > -int dw_mci_exynos_probe(struct platform_device *pdev)
> > +static int dw_mci_exynos_probe(struct platform_device *pdev)
> >  {
> >  	const struct dw_mci_drv_data *drv_data;
> >  	const struct of_device_id *match;
> >
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/2] mmc: dw_mmc: Make dw_mci_exynos_probe static

[Sachin Kamat]

Hi Chris,

On 18 February 2013 16:21, Seungwon Jeon <tgih.jun@samsung.com> wrote:
> Hi Sachin,
>
> You're right.
> 'dw_mci_exynos_probe' is only used here.
>
> Acked-by: Seungwon Jeon <tgih.jun@samsung.com>
>
> On Monday, February 18, 2013, Jaehoon Chung wrote:
>> Acked-by: Jaehoon Chung <jh80.chung@samsung.com>
>>
>> On 02/18/2013 05:53 PM, Sachin Kamat wrote:
>> > Silences the following sparse warning:
>> > drivers/mmc/host/dw_mmc-exynos.c:218:5: warning:
>> > symbol 'dw_mci_exynos_probe' was not declared. Should it be static?
>> >
>> > Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>

Can you please review this series?


-- 
With warm regards,
Sachin

Re: [PATCH 1/2] mmc: dw_mmc: Make dw_mci_exynos_probe static

[Sachin Kamat]

On 4 March 2013 10:06, Sachin Kamat <sachin.kamat@linaro.org> wrote:
> Hi Chris,
>
> On 18 February 2013 16:21, Seungwon Jeon <tgih.jun@samsung.com> wrote:
>> Hi Sachin,
>>
>> You're right.
>> 'dw_mci_exynos_probe' is only used here.
>>
>> Acked-by: Seungwon Jeon <tgih.jun@samsung.com>
>>
>> On Monday, February 18, 2013, Jaehoon Chung wrote:
>>> Acked-by: Jaehoon Chung <jh80.chung@samsung.com>
>>>
>>> On 02/18/2013 05:53 PM, Sachin Kamat wrote:
>>> > Silences the following sparse warning:
>>> > drivers/mmc/host/dw_mmc-exynos.c:218:5: warning:
>>> > symbol 'dw_mci_exynos_probe' was not declared. Should it be static?
>>> >
>>> > Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
>
> Can you please review this series?
>

ping Chris.

Re: [PATCH 1/2] mmc: dw_mmc: Make dw_mci_exynos_probe static

[Chris Ball]

Hi,

On Mon, Feb 18 2013, Sachin Kamat wrote:
> Silences the following sparse warning:
> drivers/mmc/host/dw_mmc-exynos.c:218:5: warning:
> symbol 'dw_mci_exynos_probe' was not declared. Should it be static?
>
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> ---
>  drivers/mmc/host/dw_mmc-exynos.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/mmc/host/dw_mmc-exynos.c b/drivers/mmc/host/dw_mmc-exynos.c
> index 72fd0f2..5a09c77 100644
> --- a/drivers/mmc/host/dw_mmc-exynos.c
> +++ b/drivers/mmc/host/dw_mmc-exynos.c
> @@ -215,7 +215,7 @@ static const struct of_device_id dw_mci_exynos_match[] = {
>  };
>  MODULE_DEVICE_TABLE(of, dw_mci_exynos_match);
>  
> -int dw_mci_exynos_probe(struct platform_device *pdev)
> +static int dw_mci_exynos_probe(struct platform_device *pdev)
>  {
>  	const struct dw_mci_drv_data *drv_data;
>  	const struct of_device_id *match;

Thanks, pushed to mmc-next for 3.10.

- Chris.
-- 
Chris Ball   <cjb@laptop.org>   <http://printf.net/>
One Laptop Per Child

Re: [PATCH 1/2] mmc: dw_mmc: Make dw_mci_exynos_probe static

[Sachin Kamat]

>> -int dw_mci_exynos_probe(struct platform_device *pdev)
>> +static int dw_mci_exynos_probe(struct platform_device *pdev)
>>  {
>>       const struct dw_mci_drv_data *drv_data;
>>       const struct of_device_id *match;
>
> Thanks, pushed to mmc-next for 3.10.

Thanks Chris.

There is also another patch in this series [1] that needs your attention.
[1] https://patchwork.kernel.org/patch/2156621/


-- 
With warm regards,
Sachin

Re: [PATCH 1/2] mmc: dw_mmc: Make dw_mci_exynos_probe static

[Chris Ball]

Hi,

On Tue, Mar 12 2013, Sachin Kamat wrote:
> There is also another patch in this series [1] that needs your attention.
> [1] https://patchwork.kernel.org/patch/2156621/

I'd rather have one of the dw_mmc maintainers handle ACKing patches
before I apply them.  If they haven't reviewed it by the time we're
getting ready to merge for 3.10, I can overrule them and apply it.

Thanks,

- Chris.
-- 
Chris Ball   <cjb@laptop.org>   <http://printf.net/>
One Laptop Per Child

Re: [PATCH 1/2] mmc: dw_mmc: Make dw_mci_exynos_probe static

[Sachin Kamat]

On 12 March 2013 20:30, Chris Ball <cjb@laptop.org> wrote:
> Hi,
>
> On Tue, Mar 12 2013, Sachin Kamat wrote:
>> There is also another patch in this series [1] that needs your attention.
>> [1] https://patchwork.kernel.org/patch/2156621/
>
> I'd rather have one of the dw_mmc maintainers handle ACKing patches
> before I apply them.  If they haven't reviewed it by the time we're
> getting ready to merge for 3.10, I can overrule them and apply it.

Thanks Chris.

Seungwon, Jaehoon,
Can you please review this patch?
https://patchwork.kernel.org/patch/2156621/


-- 
With warm regards,
Sachin

Re: [PATCH 1/2] mmc: dw_mmc: Make dw_mci_exynos_probe static

[Jaehoon Chung]

Hi All,

this patch has already got acked-by of Seungwon and me.

Best Regards,
Jaehoon Chung

On 03/13/2013 12:04 AM, Sachin Kamat wrote:
> On 12 March 2013 20:30, Chris Ball <cjb@laptop.org> wrote:
>> Hi,
>>
>> On Tue, Mar 12 2013, Sachin Kamat wrote:
>>> There is also another patch in this series [1] that needs your attention.
>>> [1] https://patchwork.kernel.org/patch/2156621/
>>
>> I'd rather have one of the dw_mmc maintainers handle ACKing patches
>> before I apply them.  If they haven't reviewed it by the time we're
>> getting ready to merge for 3.10, I can overrule them and apply it.
> 
> Thanks Chris.
> 
> Seungwon, Jaehoon,
> Can you please review this patch?
> https://patchwork.kernel.org/patch/2156621/
> 
> 

Re: [PATCH 1/2] mmc: dw_mmc: Make dw_mci_exynos_probe static

[Sachin Kamat]

Hi Jaehoon,

On 13 March 2013 09:50, Jaehoon Chung <jh80.chung@samsung.com> wrote:
> Hi All,
>
> this patch has already got acked-by of Seungwon and me.

It is needed for the second patch of this series
"[PATCH 2/2] mmc: dw_mmc: exynos: Remove unnecessary use of of_match_ptr()"

https://patchwork.kernel.org/patch/2156621/

-- 
With warm regards,
Sachin

Re: [PATCH 2/2] mmc: dw_mmc: exynos: Remove unnecessary use of of_match_ptr()

[Jaehoon Chung]

Acked-by: Jaehoon Chung <jh80.chung@samsung.com>

On 02/18/2013 05:53 PM, Sachin Kamat wrote:
> 'dw_mci_exynos_match' is always compiled in. Hence of_match_ptr
> is not required.
> 
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> ---
>  drivers/mmc/host/dw_mmc-exynos.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/mmc/host/dw_mmc-exynos.c b/drivers/mmc/host/dw_mmc-exynos.c
> index 5a09c77..517a603 100644
> --- a/drivers/mmc/host/dw_mmc-exynos.c
> +++ b/drivers/mmc/host/dw_mmc-exynos.c
> @@ -230,7 +230,7 @@ static struct platform_driver dw_mci_exynos_pltfm_driver = {
>  	.remove		= __exit_p(dw_mci_pltfm_remove),
>  	.driver		= {
>  		.name		= "dwmmc_exynos",
> -		.of_match_table	= of_match_ptr(dw_mci_exynos_match),
> +		.of_match_table	= dw_mci_exynos_match,
>  		.pm		= &dw_mci_pltfm_pmops,
>  	},
>  };
> 

RE: [PATCH 2/2] mmc: dw_mmc: exynos: Remove unnecessary use of of_match_ptr()

[Seungwon Jeon]

On Monday, February 18, 2013, Sachin Kamat wrote:
> 'dw_mci_exynos_match' is always compiled in. Hence of_match_ptr
> is not required.
> 
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>

Acked-by: Seungwon Jeon <tgih.jun@samsung.com>

Re: [PATCH 2/2] mmc: dw_mmc: exynos: Remove unnecessary use of of_match_ptr()

[Sachin Kamat]

Hi Chris,

On 13 March 2013 19:47, Seungwon Jeon <tgih.jun@samsung.com> wrote:
> On Monday, February 18, 2013, Sachin Kamat wrote:
>> 'dw_mci_exynos_match' is always compiled in. Hence of_match_ptr
>> is not required.
>>
>> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
>
> Acked-by: Seungwon Jeon <tgih.jun@samsung.com>


Here are the required Ack's for you to apply the patch :)


-- 
With warm regards,
Sachin

Re: [PATCH 2/2] mmc: dw_mmc: exynos: Remove unnecessary use of of_match_ptr()

[Sachin Kamat]

On 13 March 2013 21:05, Sachin Kamat <sachin.kamat@linaro.org> wrote:
> Hi Chris,
>
> On 13 March 2013 19:47, Seungwon Jeon <tgih.jun@samsung.com> wrote:
>> On Monday, February 18, 2013, Sachin Kamat wrote:
>>> 'dw_mci_exynos_match' is always compiled in. Hence of_match_ptr
>>> is not required.
>>>
>>> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
>>
>> Acked-by: Seungwon Jeon <tgih.jun@samsung.com>
>
>
> Here are the required Ack's for you to apply the patch :)
>

ping Chris.



-- 
With warm regards,
Sachin

Re: [PATCH 2/2] mmc: dw_mmc: exynos: Remove unnecessary use of of_match_ptr()

[Chris Ball]

Hi,

On Wed, Mar 13 2013, Seungwon Jeon wrote:
> On Monday, February 18, 2013, Sachin Kamat wrote:
>> 'dw_mci_exynos_match' is always compiled in. Hence of_match_ptr
>> is not required.
>> 
>> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
>
> Acked-by: Seungwon Jeon <tgih.jun@samsung.com>

Thanks, pushed to mmc-next for 3.10.

- Chris.
-- 
Chris Ball   <cjb@laptop.org>   <http://printf.net/>
One Laptop Per Child