* [PATCH 2/2] mmc: dw-mmc: fix the return value for exynos's setup_clock()
@ 2013-02-18 10:12 Jaehoon Chung
0 siblings, 0 replies; only message in thread
From: Jaehoon Chung @ 2013-02-18 10:12 UTC (permalink / raw)
To: linux-mmc
Cc: 'Chris Ball', Seungwon Jeon, Thomas Abraham,
Kyungmin Park
Before adjusting this patch, always return 0.
Then clock-setup would be always succeed.
In dw-mmc.c, it's checked like below
ret = drv_data->setup_clock(host);
if (ret) {
...
Never entered at here..
}
Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com>
Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
---
drivers/mmc/host/dw_mmc-exynos.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mmc/host/dw_mmc-exynos.c b/drivers/mmc/host/dw_mmc-exynos.c
index 72fd0f2..764ff29 100644
--- a/drivers/mmc/host/dw_mmc-exynos.c
+++ b/drivers/mmc/host/dw_mmc-exynos.c
@@ -99,7 +99,7 @@ static int dw_mci_exynos_setup_clock(struct dw_mci *host)
else if (priv->ctrl_type == DW_MCI_TYPE_EXYNOS4210)
host->bus_hz /= EXYNOS4210_FIXED_CIU_CLK_DIV;
- return 0;
+ return host->bus_hz ? 0 : -EINVAL;
}
static void dw_mci_exynos_prepare_command(struct dw_mci *host, u32 *cmdr)
--
1.7.9.5
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2013-02-18 10:12 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-02-18 10:12 [PATCH 2/2] mmc: dw-mmc: fix the return value for exynos's setup_clock() Jaehoon Chung
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).