Re: [PATCH v2 1/2] mmc: sdhci-pltfm: add calling mmc_of_parse in sdhci_pltfm_register

[Stephen Warren <swarren@wwwdotorg.org>]

n 03/08/2013 09:24 PM, Kevin Liu wrote:
> 2013/3/9 Stephen Warren <swarren@wwwdotorg.org>:
>> On 03/08/2013 08:07 AM, Kevin Liu wrote:
>>> commit 6c56e7a0 provide a function mmc_of_parse for standard MMC
>>> device-tree binding parser centrally. So just call it with
>>> sdhci_get_of_property together in sdhci_pltfm_register.
>>
>>> diff --git a/drivers/mmc/host/sdhci-pltfm.c b/drivers/mmc/host/sdhci-pltfm.c
>>
>>> @@ -212,6 +213,7 @@ int sdhci_pltfm_register(struct platform_device *pdev,
>>>       if (IS_ERR(host))
>>>               return PTR_ERR(host);
>>>
>>> +     mmc_of_parse(host->mmc);
>>
>> A few drivers already call mmc_of_parse() themselves. This change will
>> make that call happen twice. Mostly this won't be an issue, but there
>> are a couple gpio_request() calls in there, the error-handling for which
>> in mmc_of_parse() will spew error messages if attempted twice. I also
>> have a patch in the Tegra tree that adds a call to mmc_of_parse() into
>> the Tegra driver, and that relies on fixing some bugs in the device
>> tree; the CD GPIO polarity was previously specified incorrectly in the DT...
>>
> 
> Stephen,
> 
> I don't think so. I add calling mmc_of_parse in sdhci_pltfm_register
> rather than sdhci_pltfm_init.

Ah yes, you're right. So, there's no issue.

Chris, I do think I'll still send you a pull request to move the Tegra
SDHCI change that's currently in the Tegra tree into the MMC tree, just
in case there do turn out to be any MMC core cleanup/... issues this
kernel cycle. Best to be safe! I suspect that Tegra might be able to be
converted to using sdhci_pltfm_register() rather than sdhci_pltfm_init()
after Kevin's change, but I'll have to investigate more to be certain.