From: Jaehoon Chung <jh80.chung@samsung.com>
To: Seungwon Jeon <tgih.jun@samsung.com>
Cc: linux-mmc@vger.kernel.org, 'Chris Ball' <cjb@laptop.org>,
'Jaehoon Chung' <jh80.chung@samsung.com>
Subject: Re: [PATCH RESEND] mmc: dw_mmc: fix fifo access for 64-bit
Date: Tue, 26 Mar 2013 21:02:59 +0900 [thread overview]
Message-ID: <51518E73.3080604@samsung.com> (raw)
In-Reply-To: <001c01ce292a$54a35a80$fdea0f80$%jun@samsung.com>
Acked-by: Jaehoon Chung <jh80.chung@samsung.com>
On 03/25/2013 04:28 PM, Seungwon Jeon wrote:
> mci_writew causes a failure of fifo access for 64-bit.
> mci_writeq is correct.
>
> Signed-off-by: Seungwon Jeon <tgih.jun@samsung.com>
> ---
> drivers/mmc/host/dw_mmc.c | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c
> index a443820..753c55c 100644
> --- a/drivers/mmc/host/dw_mmc.c
> +++ b/drivers/mmc/host/dw_mmc.c
> @@ -1373,8 +1373,9 @@ static void dw_mci_push_data64(struct dw_mci *host, void *buf, int cnt)
> int len = dw_mci_push_part_bytes(host, buf, cnt);
> buf += len;
> cnt -= len;
> +
> if (host->part_buf_count == 8) {
> - mci_writew(host, DATA(host->data_offset),
> + mci_writeq(host, DATA(host->data_offset),
> host->part_buf);
> host->part_buf_count = 0;
> }
>
next prev parent reply other threads:[~2013-03-26 12:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-25 7:28 [PATCH RESEND] mmc: dw_mmc: fix fifo access for 64-bit Seungwon Jeon
2013-03-26 12:02 ` Jaehoon Chung [this message]
2013-04-04 13:56 ` Chris Ball
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51518E73.3080604@samsung.com \
--to=jh80.chung@samsung.com \
--cc=cjb@laptop.org \
--cc=linux-mmc@vger.kernel.org \
--cc=tgih.jun@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox