Re: mmc: mxs-mmc: add non-removeable property

Re: mmc: mxs-mmc: add non-removeable property

[Marc Kleine-Budde]

[-- Attachment #1.1: Type: text/plain, Size: 1300 bytes --]

On 04/05/2013 02:01 PM, Alexandre Pereira da Silva wrote:
> I just sent a patch to fix the same thing to the list, without seeing
> yours first.
> 
> But in the discussion, I learned that I should be checking for
> broken-cd instead of non-removable.

I'm not subscribed to linux-mmc and on
http://news.gmane.org/gmane.linux.kernel.mmc I just see Marek's
Reviewed-by. Can you point me to the discussion?

In fact my board has an eMMC, which is soldered to the board and the
card detect is not connected...the documentation says:

>   - broken-cd: There is no card detection available; polling must be used.
>   - non-removable: non-removable slot (like eMMC); assume always present.

I see no point in using polling if the card is in deed always present.

> Would you like for me to send a separate patch for broken-cd or do you
> prefer to check on yours when you resubmit?

If your card detect is not connected and the card is removable, you
should use broken-cd and base you patch on mine.

Marc
-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |


[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 263 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: mmc: mxs-mmc: add non-removeable property

[Marc Kleine-Budde]

[-- Attachment #1.1: Type: text/plain, Size: 852 bytes --]

On 04/05/2013 02:31 PM, Alexandre Pereira da Silva wrote:
> On Fri, Apr 5, 2013 at 9:14 AM, Marc Kleine-Budde <mkl@pengutronix.de>
> wrote:
>> I'm not subscribed to linux-mmc and on
>> http://news.gmane.org/gmane.linux.kernel.mmc I just see Marek's
>> Reviewed-by. Can you point me to the discussion?
> 
> http://marc.info/?l=linux-kernel&m=136515344220293&w=2

tnx

>> If your card detect is not connected and the card is removable, you
>> should use broken-cd and base you patch on mine.
> 
> Ok, I will do that.

I've just posted an updated series.

Marc
-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |


[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 263 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel