From: Marc Kleine-Budde <mkl@pengutronix.de>
To: Alexandre Pereira da Silva <aletes.xgr@gmail.com>
Cc: cjb@laptop.org, shawn.guo@linaro.org, marex@denx.de,
fabio.estevam@freescale.com, otavio@ossystems.com.br,
broonie@opensource.wolfsonmicro.com, linux-mmc@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mmc: mxs-mmc: Add broken-cd devicetree property
Date: Sat, 06 Apr 2013 15:58:35 +0200 [thread overview]
Message-ID: <51602A0B.6020405@pengutronix.de> (raw)
In-Reply-To: <1365255828-6416-1-git-send-email-aletes.xgr@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 800 bytes --]
On 04/06/2013 03:43 PM, Alexandre Pereira da Silva wrote:
> In case of broken card detect support, assume the card is non-removable
According to the documentation broken card detect is something different
than non-removable:
> - broken-cd: There is no card detection available; polling must be used.
> - non-removable: non-removable slot (like eMMC); assume always present.
But mxs-mmc set MMC_CAP_NEEDS_POLL unconditionally.
http://lxr.free-electrons.com/source/drivers/mmc/host/mxs-mmc.c#L682
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions | Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 263 bytes --]
next prev parent reply other threads:[~2013-04-06 13:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-06 13:43 [PATCH] mmc: mxs-mmc: Add broken-cd devicetree property Alexandre Pereira da Silva
2013-04-06 13:58 ` Marc Kleine-Budde [this message]
2013-04-06 14:19 ` Alexandre Pereira da Silva
2013-04-06 15:06 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51602A0B.6020405@pengutronix.de \
--to=mkl@pengutronix.de \
--cc=aletes.xgr@gmail.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=cjb@laptop.org \
--cc=fabio.estevam@freescale.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=marex@denx.de \
--cc=otavio@ossystems.com.br \
--cc=shawn.guo@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox