* [PATCH 15/22] mmc: sdhci-acpi: remove unnecessary platform_set_drvdata()
@ 2013-05-06 6:30 Jingoo Han
2013-05-06 9:23 ` Adrian Hunter
0 siblings, 1 reply; 2+ messages in thread
From: Jingoo Han @ 2013-05-06 6:30 UTC (permalink / raw)
To: 'Chris Ball'; +Cc: linux-mmc, Jingoo Han, 'Adrian Hunter'
The driver core clears the driver data to NULL after device_release
or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d
(device-core: Ensure drvdata = NULL when no driver is bound).
Thus, it is not needed to manually clear the device driver data to NULL.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/mmc/host/sdhci-acpi.c | 2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/drivers/mmc/host/sdhci-acpi.c b/drivers/mmc/host/sdhci-acpi.c
index 7bcf74b..8e6c4da 100644
--- a/drivers/mmc/host/sdhci-acpi.c
+++ b/drivers/mmc/host/sdhci-acpi.c
@@ -211,7 +211,6 @@ static int sdhci_acpi_probe(struct platform_device *pdev)
return 0;
err_free:
- platform_set_drvdata(pdev, NULL);
sdhci_free_host(c->host);
return err;
}
@@ -230,7 +229,6 @@ static int sdhci_acpi_remove(struct platform_device *pdev)
dead = (sdhci_readl(c->host, SDHCI_INT_STATUS) == ~0);
sdhci_remove_host(c->host, dead);
- platform_set_drvdata(pdev, NULL);
sdhci_free_host(c->host);
return 0;
--
1.7.2.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 15/22] mmc: sdhci-acpi: remove unnecessary platform_set_drvdata()
2013-05-06 6:30 [PATCH 15/22] mmc: sdhci-acpi: remove unnecessary platform_set_drvdata() Jingoo Han
@ 2013-05-06 9:23 ` Adrian Hunter
0 siblings, 0 replies; 2+ messages in thread
From: Adrian Hunter @ 2013-05-06 9:23 UTC (permalink / raw)
To: Jingoo Han; +Cc: 'Chris Ball', linux-mmc
On 06/05/13 09:30, Jingoo Han wrote:
> The driver core clears the driver data to NULL after device_release
> or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d
> (device-core: Ensure drvdata = NULL when no driver is bound).
> Thus, it is not needed to manually clear the device driver data to NULL.
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Acked-by: Adrian Hunter <adrian.hunter@intel.com>
> ---
> drivers/mmc/host/sdhci-acpi.c | 2 --
> 1 files changed, 0 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mmc/host/sdhci-acpi.c b/drivers/mmc/host/sdhci-acpi.c
> index 7bcf74b..8e6c4da 100644
> --- a/drivers/mmc/host/sdhci-acpi.c
> +++ b/drivers/mmc/host/sdhci-acpi.c
> @@ -211,7 +211,6 @@ static int sdhci_acpi_probe(struct platform_device *pdev)
> return 0;
>
> err_free:
> - platform_set_drvdata(pdev, NULL);
> sdhci_free_host(c->host);
> return err;
> }
> @@ -230,7 +229,6 @@ static int sdhci_acpi_remove(struct platform_device *pdev)
>
> dead = (sdhci_readl(c->host, SDHCI_INT_STATUS) == ~0);
> sdhci_remove_host(c->host, dead);
> - platform_set_drvdata(pdev, NULL);
> sdhci_free_host(c->host);
>
> return 0;
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-05-06 9:18 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-05-06 6:30 [PATCH 15/22] mmc: sdhci-acpi: remove unnecessary platform_set_drvdata() Jingoo Han
2013-05-06 9:23 ` Adrian Hunter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox