From: Jaehoon Chung <jh80.chung@samsung.com>
To: Jingoo Han <jg1.han@samsung.com>
Cc: 'Chris Ball' <cjb@laptop.org>,
linux-mmc@vger.kernel.org, 'Ben Dooks' <ben-linux@fluff.org>,
Jaehoon Chung <jh80.chung@samsung.com>
Subject: Re: [PATCH 18/22] mmc: sdhci-s3c: remove unnecessary platform_set_drvdata()
Date: Tue, 07 May 2013 12:37:33 +0900 [thread overview]
Message-ID: <518876FD.2000207@samsung.com> (raw)
In-Reply-To: <005d01ce4a23$f4a94d90$ddfbe8b0$@samsung.com>
Acked-by: Jaehoon Chung <jh80.chung@samsung.com>
On 05/06/2013 03:35 PM, Jingoo Han wrote:
> The driver core clears the driver data to NULL after device_release
> or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d
> (device-core: Ensure drvdata = NULL when no driver is bound).
> Thus, it is not needed to manually clear the device driver data to NULL.
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
> ---
> drivers/mmc/host/sdhci-s3c.c | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/mmc/host/sdhci-s3c.c b/drivers/mmc/host/sdhci-s3c.c
> index c6f6246..926aaf6 100644
> --- a/drivers/mmc/host/sdhci-s3c.c
> +++ b/drivers/mmc/host/sdhci-s3c.c
> @@ -745,7 +745,6 @@ static int sdhci_s3c_remove(struct platform_device *pdev)
> clk_disable_unprepare(sc->clk_io);
>
> sdhci_free_host(host);
> - platform_set_drvdata(pdev, NULL);
>
> return 0;
> }
>
prev parent reply other threads:[~2013-05-07 3:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-06 6:35 [PATCH 18/22] mmc: sdhci-s3c: remove unnecessary platform_set_drvdata() Jingoo Han
2013-05-07 3:37 ` Jaehoon Chung [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=518876FD.2000207@samsung.com \
--to=jh80.chung@samsung.com \
--cc=ben-linux@fluff.org \
--cc=cjb@laptop.org \
--cc=jg1.han@samsung.com \
--cc=linux-mmc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox