From mboxrd@z Thu Jan 1 00:00:00 1970 From: Veerabhadrarao Badiganti Subject: Re: [PATCH 1/2] dt-bindings: mmc: sdhci-msm: Add flag for restoring dll Date: Thu, 27 Sep 2018 16:50:57 +0530 Message-ID: <5194544b-866a-f0b5-3638-acf6f67fb9c8@codeaurora.org> References: <1537887875-29494-1-git-send-email-vbadigan@codeaurora.org> <1537887875-29494-2-git-send-email-vbadigan@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org To: Evan Green Cc: adrian.hunter@intel.com, Ulf Hansson , robh+dt@kernel.org, asutoshd@codeaurora.org, riteshh@codeaurora.org, stummala@codeaurora.org, sayali , Doug Anderson , mark.rutland@arm.com, linux-mmc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org List-Id: linux-mmc@vger.kernel.org On 9/25/2018 11:08 PM, Evan Green wrote: > On Tue, Sep 25, 2018 at 8:05 AM Veerabhadrarao Badiganti > wrote: >> The dll settings of SDHC controller needs to be restored whenever >> controller clocks are gated. This restoration is needed only on >> few SDHCI-MSM controllers. This dt flag indicates whether dll >> restoration is needed or not. >> >> Signed-off-by: Veerabhadrarao Badiganti >> --- >> Documentation/devicetree/bindings/mmc/sdhci-msm.txt | 4 ++++ >> 1 file changed, 4 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/mmc/sdhci-msm.txt b/Documentation/devicetree/bindings/mmc/sdhci-msm.txt >> index 3720385..207ce36 100644 >> --- a/Documentation/devicetree/bindings/mmc/sdhci-msm.txt >> +++ b/Documentation/devicetree/bindings/mmc/sdhci-msm.txt >> @@ -31,6 +31,8 @@ Optional properties: >> BUS_OFF states in power irq. Should be specified in >> pairs (lpm, hpm), for BUS_OFF and BUS_ON respectively. >> Units uA. >> +- qcom,restore-dll-config - Flag indicates that restoration of dll config after clock gating >> + is needed on given platform. This wouldn't be needed for every MSM. >> Example: >> >> sdhc_1: sdhci@f9824900 { >> @@ -49,6 +51,8 @@ Example: >> >> clocks = <&gcc GCC_SDCC1_APPS_CLK>, <&gcc GCC_SDCC1_AHB_CLK>; >> clock-names = "core", "iface"; >> + >> + qcom,restore-dll-config; > Hi Veera, > I'm not sure this is the best approach. It might be better to key this > behavior off of the compatible string. Actually I'm noticing now that > the binding for this device doesn't include an SoC-specific compatible > string, which I think is now the preferred way (eg > "qcom,sdm845-sdhci", "qcom,sdhci-msm-v5"). I think we should add that > to sdhci-msm.txt, then use the compatible string to enable this > behavior you're adding now. Thanks Evan. I will update this one. > -Evan Thanks, Veera