* [PATCH 1/1] mmc: of_mmc_spi: fix card detect irq
@ 2013-05-26 12:28 Jean-Christophe PLAGNIOL-VILLARD
2013-05-26 19:13 ` Sergei Shtylyov
0 siblings, 1 reply; 4+ messages in thread
From: Jean-Christophe PLAGNIOL-VILLARD @ 2013-05-26 12:28 UTC (permalink / raw)
To: linux-arm-kernel; +Cc: Jean-Christophe PLAGNIOL-VILLARD, linux-mmc
set missing irq type the IRQF_ONESHOT
Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
Cc: stable <stable@vger.kernel.org> # 3.4+
Cc: linux-mmc@vger.kernel.org
---
drivers/mmc/host/of_mmc_spi.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/mmc/host/of_mmc_spi.c b/drivers/mmc/host/of_mmc_spi.c
index d720b5e..cfb2e61 100644
--- a/drivers/mmc/host/of_mmc_spi.c
+++ b/drivers/mmc/host/of_mmc_spi.c
@@ -74,8 +74,8 @@ static int of_mmc_spi_init(struct device *dev,
{
struct of_mmc_spi *oms = to_of_mmc_spi(dev);
- return request_threaded_irq(oms->detect_irq, NULL, irqhandler, 0,
- dev_name(dev), mmc);
+ return request_threaded_irq(oms->detect_irq, NULL, irqhandler,
+ IRQF_ONESHOT, dev_name(dev), mmc);
}
static void of_mmc_spi_exit(struct device *dev, void *mmc)
--
1.7.10.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 1/1] mmc: of_mmc_spi: fix card detect irq
2013-05-26 12:28 [PATCH 1/1] mmc: of_mmc_spi: fix card detect irq Jean-Christophe PLAGNIOL-VILLARD
@ 2013-05-26 19:13 ` Sergei Shtylyov
2013-05-27 14:13 ` Jean-Christophe PLAGNIOL-VILLARD
0 siblings, 1 reply; 4+ messages in thread
From: Sergei Shtylyov @ 2013-05-26 19:13 UTC (permalink / raw)
To: Jean-Christophe PLAGNIOL-VILLARD; +Cc: linux-arm-kernel, linux-mmc
Hello.
On 05/26/2013 04:28 PM, Jean-Christophe PLAGNIOL-VILLARD wrote:
> set missing irq type the IRQF_ONESHOT
>
> Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
> Cc: stable <stable@vger.kernel.org> # 3.4+
> Cc: linux-mmc@vger.kernel.org
> ---
> drivers/mmc/host/of_mmc_spi.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mmc/host/of_mmc_spi.c b/drivers/mmc/host/of_mmc_spi.c
> index d720b5e..cfb2e61 100644
> --- a/drivers/mmc/host/of_mmc_spi.c
> +++ b/drivers/mmc/host/of_mmc_spi.c
> @@ -74,8 +74,8 @@ static int of_mmc_spi_init(struct device *dev,
> {
> struct of_mmc_spi *oms = to_of_mmc_spi(dev);
>
> - return request_threaded_irq(oms->detect_irq, NULL, irqhandler, 0,
> - dev_name(dev), mmc);
> + return request_threaded_irq(oms->detect_irq, NULL, irqhandler,
> + IRQF_ONESHOT, dev_name(dev), mmc);
Please don't change the indentation.
WBR, Sergei
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/1] mmc: of_mmc_spi: fix card detect irq
2013-05-26 19:13 ` Sergei Shtylyov
@ 2013-05-27 14:13 ` Jean-Christophe PLAGNIOL-VILLARD
2013-05-27 18:02 ` Sergei Shtylyov
0 siblings, 1 reply; 4+ messages in thread
From: Jean-Christophe PLAGNIOL-VILLARD @ 2013-05-27 14:13 UTC (permalink / raw)
To: Sergei Shtylyov; +Cc: linux-mmc, linux-arm-kernel
On 23:13 Sun 26 May , Sergei Shtylyov wrote:
> Hello.
>
> On 05/26/2013 04:28 PM, Jean-Christophe PLAGNIOL-VILLARD wrote:
>
> >set missing irq type the IRQF_ONESHOT
> >
> >Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
> >Cc: stable <stable@vger.kernel.org> # 3.4+
> >Cc: linux-mmc@vger.kernel.org
> >---
> > drivers/mmc/host/of_mmc_spi.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> >diff --git a/drivers/mmc/host/of_mmc_spi.c b/drivers/mmc/host/of_mmc_spi.c
> >index d720b5e..cfb2e61 100644
> >--- a/drivers/mmc/host/of_mmc_spi.c
> >+++ b/drivers/mmc/host/of_mmc_spi.c
> >@@ -74,8 +74,8 @@ static int of_mmc_spi_init(struct device *dev,
> > {
> > struct of_mmc_spi *oms = to_of_mmc_spi(dev);
> >- return request_threaded_irq(oms->detect_irq, NULL, irqhandler, 0,
> >- dev_name(dev), mmc);
> >+ return request_threaded_irq(oms->detect_irq, NULL, irqhandler,
> >+ IRQF_ONESHOT, dev_name(dev), mmc);
>
> Please don't change the indentation.
too long > 80
Best Regards,
J.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/1] mmc: of_mmc_spi: fix card detect irq
2013-05-27 14:13 ` Jean-Christophe PLAGNIOL-VILLARD
@ 2013-05-27 18:02 ` Sergei Shtylyov
0 siblings, 0 replies; 4+ messages in thread
From: Sergei Shtylyov @ 2013-05-27 18:02 UTC (permalink / raw)
To: Jean-Christophe PLAGNIOL-VILLARD; +Cc: linux-arm-kernel, linux-mmc
Hello.
On 27-05-2013 18:13, Jean-Christophe PLAGNIOL-VILLARD wrote:
>>> set missing irq type the IRQF_ONESHOT
>>> Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
>>> Cc: stable <stable@vger.kernel.org> # 3.4+
>>> Cc: linux-mmc@vger.kernel.org
>>> ---
>>> drivers/mmc/host/of_mmc_spi.c | 4 ++--
>>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>> diff --git a/drivers/mmc/host/of_mmc_spi.c b/drivers/mmc/host/of_mmc_spi.c
>>> index d720b5e..cfb2e61 100644
>>> --- a/drivers/mmc/host/of_mmc_spi.c
>>> +++ b/drivers/mmc/host/of_mmc_spi.c
>>> @@ -74,8 +74,8 @@ static int of_mmc_spi_init(struct device *dev,
>>> {
>>> struct of_mmc_spi *oms = to_of_mmc_spi(dev);
>>> - return request_threaded_irq(oms->detect_irq, NULL, irqhandler, 0,
>>> - dev_name(dev), mmc);
>>> + return request_threaded_irq(oms->detect_irq, NULL, irqhandler,
>>> + IRQF_ONESHOT, dev_name(dev), mmc);
>> Please don't change the indentation.
> too long > 80
Reflow it then into several lines.
> Best Regards,
> J.
WBR, Sergei
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-05-27 18:02 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-05-26 12:28 [PATCH 1/1] mmc: of_mmc_spi: fix card detect irq Jean-Christophe PLAGNIOL-VILLARD
2013-05-26 19:13 ` Sergei Shtylyov
2013-05-27 14:13 ` Jean-Christophe PLAGNIOL-VILLARD
2013-05-27 18:02 ` Sergei Shtylyov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).