* [PATCHv2] mmc: sdhci-s3c: fix the wrong register value when, clock is disabled
@ 2013-05-27 4:10 Jaehoon Chung
2013-06-07 11:39 ` Jaehoon Chung
2013-06-27 14:53 ` Chris Ball
0 siblings, 2 replies; 4+ messages in thread
From: Jaehoon Chung @ 2013-05-27 4:10 UTC (permalink / raw)
To: linux-mmc@vger.kernel.org; +Cc: 'Chris Ball', Kyungmin Park
When use the QUIRK_NONSTANDARD_CLOCK, then never set to 0 at clock control register.
This patch is fixed this problem.
Signed-off-by: Jaehoon Chung <jh80.chung@samsung.co
Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
---
Changelog v2:
- Rebased at the latest mmc tree
drivers/mmc/host/sdhci-s3c.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/mmc/host/sdhci-s3c.c b/drivers/mmc/host/sdhci-s3c.c
index 926aaf6..ce71f32 100644
--- a/drivers/mmc/host/sdhci-s3c.c
+++ b/drivers/mmc/host/sdhci-s3c.c
@@ -297,8 +297,11 @@ static void sdhci_cmu_set_clock(struct sdhci_host *host, unsigned int clock)
u16 clk = 0;
/* don't bother if the clock is going off */
- if (clock == 0)
+ if (clock == 0) {
+ sdhci_writew(host, 0, SDHCI_CLOCK_CONTROL);
+ host->clock = clock;
return;
+ }
sdhci_s3c_set_clock(host, clock);
--
1.7.9.5
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCHv2] mmc: sdhci-s3c: fix the wrong register value when, clock is disabled
2013-05-27 4:10 [PATCHv2] mmc: sdhci-s3c: fix the wrong register value when, clock is disabled Jaehoon Chung
@ 2013-06-07 11:39 ` Jaehoon Chung
2013-06-27 14:53 ` Chris Ball
1 sibling, 0 replies; 4+ messages in thread
From: Jaehoon Chung @ 2013-06-07 11:39 UTC (permalink / raw)
To: Jaehoon Chung
Cc: linux-mmc@vger.kernel.org, 'Chris Ball', Kyungmin Park
Dear Chris,
If you didn't have any comment, Could you merge this patch, plz?
Best Regards,
Jaehoon Chung
On 05/27/2013 01:10 PM, Jaehoon Chung wrote:
> When use the QUIRK_NONSTANDARD_CLOCK, then never set to 0 at clock control register.
> This patch is fixed this problem.
>
> Signed-off-by: Jaehoon Chung <jh80.chung@samsung.co
> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
> ---
> Changelog v2:
> - Rebased at the latest mmc tree
>
> drivers/mmc/host/sdhci-s3c.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/sdhci-s3c.c b/drivers/mmc/host/sdhci-s3c.c
> index 926aaf6..ce71f32 100644
> --- a/drivers/mmc/host/sdhci-s3c.c
> +++ b/drivers/mmc/host/sdhci-s3c.c
> @@ -297,8 +297,11 @@ static void sdhci_cmu_set_clock(struct sdhci_host *host, unsigned int clock)
> u16 clk = 0;
>
> /* don't bother if the clock is going off */
> - if (clock == 0)
> + if (clock == 0) {
> + sdhci_writew(host, 0, SDHCI_CLOCK_CONTROL);
> + host->clock = clock;
> return;
> + }
>
> sdhci_s3c_set_clock(host, clock);
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCHv2] mmc: sdhci-s3c: fix the wrong register value when, clock is disabled
2013-05-27 4:10 [PATCHv2] mmc: sdhci-s3c: fix the wrong register value when, clock is disabled Jaehoon Chung
2013-06-07 11:39 ` Jaehoon Chung
@ 2013-06-27 14:53 ` Chris Ball
2013-06-28 3:54 ` Jaehoon Chung
1 sibling, 1 reply; 4+ messages in thread
From: Chris Ball @ 2013-06-27 14:53 UTC (permalink / raw)
To: Jaehoon Chung; +Cc: linux-mmc@vger.kernel.org, Kyungmin Park
Hi Jaehoon,
On Mon, May 27 2013, Jaehoon Chung wrote:
> When use the QUIRK_NONSTANDARD_CLOCK, then never set to 0 at clock control register.
> This patch is fixed this problem.
>
> Signed-off-by: Jaehoon Chung <jh80.chung@samsung.co
> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
> ---
> Changelog v2:
> - Rebased at the latest mmc tree
>
> drivers/mmc/host/sdhci-s3c.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/sdhci-s3c.c b/drivers/mmc/host/sdhci-s3c.c
> index 926aaf6..ce71f32 100644
> --- a/drivers/mmc/host/sdhci-s3c.c
> +++ b/drivers/mmc/host/sdhci-s3c.c
> @@ -297,8 +297,11 @@ static void sdhci_cmu_set_clock(struct sdhci_host *host, unsigned int clock)
> u16 clk = 0;
>
> /* don't bother if the clock is going off */
> - if (clock == 0)
> + if (clock == 0) {
> + sdhci_writew(host, 0, SDHCI_CLOCK_CONTROL);
> + host->clock = clock;
> return;
> + }
>
> sdhci_s3c_set_clock(host, clock);
You should change the comment too, since your patch invalidates it.
Thanks,
- Chris.
--
Chris Ball <cjb@laptop.org> <http://printf.net/>
One Laptop Per Child
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCHv2] mmc: sdhci-s3c: fix the wrong register value when, clock is disabled
2013-06-27 14:53 ` Chris Ball
@ 2013-06-28 3:54 ` Jaehoon Chung
0 siblings, 0 replies; 4+ messages in thread
From: Jaehoon Chung @ 2013-06-28 3:54 UTC (permalink / raw)
To: Chris Ball; +Cc: Jaehoon Chung, linux-mmc@vger.kernel.org, Kyungmin Park
Dear Chris,
I will change the comment, and re-send the patch.
Thanks Chris.
Best Regards,
Jaehoon Chung
On 06/27/2013 11:53 PM, Chris Ball wrote:
> Hi Jaehoon,
>
> On Mon, May 27 2013, Jaehoon Chung wrote:
>> When use the QUIRK_NONSTANDARD_CLOCK, then never set to 0 at clock control register.
>> This patch is fixed this problem.
>>
>> Signed-off-by: Jaehoon Chung <jh80.chung@samsung.co
>> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
>> ---
>> Changelog v2:
>> - Rebased at the latest mmc tree
>>
>> drivers/mmc/host/sdhci-s3c.c | 5 ++++-
>> 1 file changed, 4 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/mmc/host/sdhci-s3c.c b/drivers/mmc/host/sdhci-s3c.c
>> index 926aaf6..ce71f32 100644
>> --- a/drivers/mmc/host/sdhci-s3c.c
>> +++ b/drivers/mmc/host/sdhci-s3c.c
>> @@ -297,8 +297,11 @@ static void sdhci_cmu_set_clock(struct sdhci_host *host, unsigned int clock)
>> u16 clk = 0;
>>
>> /* don't bother if the clock is going off */
>> - if (clock == 0)
>> + if (clock == 0) {
>> + sdhci_writew(host, 0, SDHCI_CLOCK_CONTROL);
>> + host->clock = clock;
>> return;
>> + }
>>
>> sdhci_s3c_set_clock(host, clock);
>
> You should change the comment too, since your patch invalidates it.
>
> Thanks,
>
> - Chris.
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-06-28 3:54 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-05-27 4:10 [PATCHv2] mmc: sdhci-s3c: fix the wrong register value when, clock is disabled Jaehoon Chung
2013-06-07 11:39 ` Jaehoon Chung
2013-06-27 14:53 ` Chris Ball
2013-06-28 3:54 ` Jaehoon Chung
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox