From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
Cc: linux-arm-kernel@lists.infradead.org, linux-mmc@vger.kernel.org
Subject: Re: [PATCH 1/1] mmc: of_mmc_spi: fix card detect irq
Date: Mon, 27 May 2013 22:02:00 +0400 [thread overview]
Message-ID: <51A39F98.4010904@cogentembedded.com> (raw)
In-Reply-To: <20130527141306.GS24476@game.jcrosoft.org>
Hello.
On 27-05-2013 18:13, Jean-Christophe PLAGNIOL-VILLARD wrote:
>>> set missing irq type the IRQF_ONESHOT
>>> Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
>>> Cc: stable <stable@vger.kernel.org> # 3.4+
>>> Cc: linux-mmc@vger.kernel.org
>>> ---
>>> drivers/mmc/host/of_mmc_spi.c | 4 ++--
>>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>> diff --git a/drivers/mmc/host/of_mmc_spi.c b/drivers/mmc/host/of_mmc_spi.c
>>> index d720b5e..cfb2e61 100644
>>> --- a/drivers/mmc/host/of_mmc_spi.c
>>> +++ b/drivers/mmc/host/of_mmc_spi.c
>>> @@ -74,8 +74,8 @@ static int of_mmc_spi_init(struct device *dev,
>>> {
>>> struct of_mmc_spi *oms = to_of_mmc_spi(dev);
>>> - return request_threaded_irq(oms->detect_irq, NULL, irqhandler, 0,
>>> - dev_name(dev), mmc);
>>> + return request_threaded_irq(oms->detect_irq, NULL, irqhandler,
>>> + IRQF_ONESHOT, dev_name(dev), mmc);
>> Please don't change the indentation.
> too long > 80
Reflow it then into several lines.
> Best Regards,
> J.
WBR, Sergei
prev parent reply other threads:[~2013-05-27 18:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-26 12:28 [PATCH 1/1] mmc: of_mmc_spi: fix card detect irq Jean-Christophe PLAGNIOL-VILLARD
2013-05-26 19:13 ` Sergei Shtylyov
2013-05-27 14:13 ` Jean-Christophe PLAGNIOL-VILLARD
2013-05-27 18:02 ` Sergei Shtylyov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51A39F98.4010904@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mmc@vger.kernel.org \
--cc=plagnioj@jcrosoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).