From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergei Shtylyov Subject: Re: [PATCH 1/1] mmc: of_mmc_spi: fix card detect irq Date: Mon, 27 May 2013 22:02:00 +0400 Message-ID: <51A39F98.4010904@cogentembedded.com> References: <1369571337-9300-1-git-send-email-plagnioj@jcrosoft.com> <51A25ECA.2060001@cogentembedded.com> <20130527141306.GS24476@game.jcrosoft.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from mail-lb0-f174.google.com ([209.85.217.174]:54808 "EHLO mail-lb0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756075Ab3E0SCE (ORCPT ); Mon, 27 May 2013 14:02:04 -0400 Received: by mail-lb0-f174.google.com with SMTP id u10so6977428lbi.19 for ; Mon, 27 May 2013 11:02:03 -0700 (PDT) In-Reply-To: <20130527141306.GS24476@game.jcrosoft.org> Sender: linux-mmc-owner@vger.kernel.org List-Id: linux-mmc@vger.kernel.org To: Jean-Christophe PLAGNIOL-VILLARD Cc: linux-arm-kernel@lists.infradead.org, linux-mmc@vger.kernel.org Hello. On 27-05-2013 18:13, Jean-Christophe PLAGNIOL-VILLARD wrote: >>> set missing irq type the IRQF_ONESHOT >>> Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD >>> Cc: stable # 3.4+ >>> Cc: linux-mmc@vger.kernel.org >>> --- >>> drivers/mmc/host/of_mmc_spi.c | 4 ++-- >>> 1 file changed, 2 insertions(+), 2 deletions(-) >>> diff --git a/drivers/mmc/host/of_mmc_spi.c b/drivers/mmc/host/of_mmc_spi.c >>> index d720b5e..cfb2e61 100644 >>> --- a/drivers/mmc/host/of_mmc_spi.c >>> +++ b/drivers/mmc/host/of_mmc_spi.c >>> @@ -74,8 +74,8 @@ static int of_mmc_spi_init(struct device *dev, >>> { >>> struct of_mmc_spi *oms = to_of_mmc_spi(dev); >>> - return request_threaded_irq(oms->detect_irq, NULL, irqhandler, 0, >>> - dev_name(dev), mmc); >>> + return request_threaded_irq(oms->detect_irq, NULL, irqhandler, >>> + IRQF_ONESHOT, dev_name(dev), mmc); >> Please don't change the indentation. > too long > 80 Reflow it then into several lines. > Best Regards, > J. WBR, Sergei