From: Adrian Hunter <adrian.hunter@intel.com>
To: Jingoo Han <jg1.han@samsung.com>
Cc: 'Wei Yongjun' <weiyj.lk@gmail.com>,
cjb@laptop.org, rafael.j.wysocki@intel.com,
sonic.zhang@analog.com, yongjun_wei@trendmicro.com.cn,
linux-mmc@vger.kernel.org
Subject: Re: [PATCH] mmc: sdhci-acpi: fix error return code in sdhci_acpi_add_own_cd()
Date: Tue, 28 May 2013 09:27:56 +0300 [thread overview]
Message-ID: <51A44E6C.9070708@intel.com> (raw)
In-Reply-To: <000801ce5b65$28d9f400$7a8ddc00$@samsung.com>
On 28/05/13 08:35, Jingoo Han wrote:
> On Tuesday, May 28, 2013 2:26 PM, Wei Yongjun wrote:
>>
>> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>>
>> Fix to return a negative error code in the gpio_to_irq() error
>> handling case instead of 0, as done elsewhere in this function.
>>
>> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>
> It looks good.
>
> Reviewed-by: Jingoo Han <jg1.han@samsung.com>
Yes, thank you!
Acked-by: Adrian Hunter <adrian.hunter@intel.com>
>
> Best regards,
> Jingoo Han
>
>> ---
>> drivers/mmc/host/sdhci-acpi.c | 4 +++-
>> 1 file changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/mmc/host/sdhci-acpi.c b/drivers/mmc/host/sdhci-acpi.c
>> index a51e603..08a85ec 100644
>> --- a/drivers/mmc/host/sdhci-acpi.c
>> +++ b/drivers/mmc/host/sdhci-acpi.c
>> @@ -189,8 +189,10 @@ static int sdhci_acpi_add_own_cd(struct device *dev, int gpio,
>> goto out;
>>
>> irq = gpio_to_irq(gpio);
>> - if (irq < 0)
>> + if (irq < 0) {
>> + err = irq;
>> goto out_free;
>> + }
>>
>> flags = IRQF_TRIGGER_RISING | IRQF_TRIGGER_FALLING;
>> err = devm_request_irq(dev, irq, sdhci_acpi_sd_cd, flags, "sd_cd", mmc);
>
>
>
next prev parent reply other threads:[~2013-05-28 6:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-28 5:26 [PATCH] mmc: sdhci-acpi: fix error return code in sdhci_acpi_add_own_cd() Wei Yongjun
2013-05-28 5:35 ` Jingoo Han
2013-05-28 6:27 ` Adrian Hunter [this message]
2013-06-10 6:35 ` Adrian Hunter
2013-06-27 14:56 ` Chris Ball
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51A44E6C.9070708@intel.com \
--to=adrian.hunter@intel.com \
--cc=cjb@laptop.org \
--cc=jg1.han@samsung.com \
--cc=linux-mmc@vger.kernel.org \
--cc=rafael.j.wysocki@intel.com \
--cc=sonic.zhang@analog.com \
--cc=weiyj.lk@gmail.com \
--cc=yongjun_wei@trendmicro.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).