From: "Christian Daudt" <csd@broadcom.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: linux-doc@vger.kernel.org,
Jerry Huang <Chang-Ming.Huang@freescale.com>,
Grant Likely <grant.likely@secretlab.ca>,
Wei WANG <wei_wang@realsil.com.cn>,
matt.porter@linaro.org, Kevin Liu <kliu5@marvell.com>,
Lars-Peter Clausen <lars@metafoo.de>,
Stephen Warren <swarren@nvidia.com>,
csd_b@daudt.org, Viresh Kumar <viresh.kumar@linaro.org>,
Chris Ball <cjb@laptop.org>,
plagnioj@jcrosoft.com, devicetree-discuss@lists.ozlabs.org,
Sascha Hauer <s.hauer@pengutronix.de>,
Rob Herring <rob.herring@calxeda.com>,
Bill Pemberton <wfp5p@virginia.edu>,
Haojian Zhuang <haojian.zhuang@gmail.com>,
Russell King <linux@arm.linux.org.uk>,
Anton Vorontsov <avorontsov@ru.mvista.com>,
linux-arm-kernel@lists.infradead.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org,
Ludovic Desroches <ludovic.desroches@atmel.com>,
Rob Landley <rob@land>
Subject: Re: [PATCH V4 2/3] ARM: mmc: bcm281xx SDHCI driver
Date: Tue, 4 Jun 2013 07:19:05 -0700 [thread overview]
Message-ID: <51ADF759.9000607@broadcom.com> (raw)
In-Reply-To: <201306012213.47386.arnd@arndb.de>
On 13-06-01 01:13 PM, Arnd Bergmann wrote:
> On Saturday 01 June 2013, Christian Daudt wrote:
>> I looked into it and it can replace just about everything that our own
>> dt parsing code is doing. The only problem is with cd_gpio. If I call
>> mmc_of_parse, then it will install its own irq handler for cd gpio, and
>> our driver needs a different handler. the mmc irq handler can call a
>> card_event callback, but that is already pointing to sdhci_card_event.
>> So the only way I can use mmc_of_parse that I can see is by adding a
>> flag to it to skip cd_gpio parsing which only this driver will then set
>> to true. Any other ideas ?
> Can't you add a callback handler into sdhci_card_event that can call
> a platform specific function?
>
>
I can add another layer of callbacks. I have to first check if I can
rework our driver to fit into this callback model. I'll update this when
I've tried it.
thanks,
csd
prev parent reply other threads:[~2013-06-04 14:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1369860607-25572-1-git-send-email-csd@broadcom.com>
2013-05-31 15:41 ` [PATCH V4 1/3] mmc: sdhci: Add size for caller in init+register Christian Daudt
[not found] ` <1369860607-25572-2-git-send-email-csd@broadcom.com>
[not found] ` <1369860607-25572-2-git-send-email-csd-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>
2013-05-31 16:15 ` [PATCH V4 2/3] ARM: mmc: bcm281xx SDHCI driver Chris Ball
2013-06-01 0:17 ` Christian Daudt
[not found] ` <51A93DA0.3070909-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>
2013-06-01 20:13 ` Arnd Bergmann
2013-06-04 14:19 ` Christian Daudt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51ADF759.9000607@broadcom.com \
--to=csd@broadcom.com \
--cc=Chang-Ming.Huang@freescale.com \
--cc=arnd@arndb.de \
--cc=avorontsov@ru.mvista.com \
--cc=cjb@laptop.org \
--cc=csd_b@daudt.org \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=grant.likely@secretlab.ca \
--cc=gregkh@linuxfoundation.org \
--cc=haojian.zhuang@gmail.com \
--cc=kliu5@marvell.com \
--cc=lars@metafoo.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=ludovic.desroches@atmel.com \
--cc=matt.porter@linaro.org \
--cc=plagnioj@jcrosoft.com \
--cc=rob.herring@calxeda.com \
--cc=rob@land \
--cc=s.hauer@pengutronix.de \
--cc=swarren@nvidia.com \
--cc=viresh.kumar@linaro.org \
--cc=wei_wang@realsil.com.cn \
--cc=wfp5p@virginia.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).