From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jaehoon Chung Subject: Re: [PATCHv2] mmc: sdhci-s3c: fix the wrong register value when, clock is disabled Date: Fri, 07 Jun 2013 20:39:14 +0900 Message-ID: <51B1C662.3060405@samsung.com> References: <51A2DCC4.2020307@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: Received: from mailout4.samsung.com ([203.254.224.34]:15022 "EHLO mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751424Ab3FGLjQ (ORCPT ); Fri, 7 Jun 2013 07:39:16 -0400 Received: from epcpsbgr2.samsung.com (u142.gpu120.samsung.co.kr [203.254.230.142]) by mailout4.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MO000EHCTPC1T20@mailout4.samsung.com> for linux-mmc@vger.kernel.org; Fri, 07 Jun 2013 20:39:15 +0900 (KST) In-reply-to: <51A2DCC4.2020307@samsung.com> Sender: linux-mmc-owner@vger.kernel.org List-Id: linux-mmc@vger.kernel.org To: Jaehoon Chung Cc: "linux-mmc@vger.kernel.org" , 'Chris Ball' , Kyungmin Park Dear Chris, If you didn't have any comment, Could you merge this patch, plz? Best Regards, Jaehoon Chung On 05/27/2013 01:10 PM, Jaehoon Chung wrote: > When use the QUIRK_NONSTANDARD_CLOCK, then never set to 0 at clock control register. > This patch is fixed this problem. > > Signed-off-by: Jaehoon Chung Signed-off-by: Kyungmin Park > --- > Changelog v2: > - Rebased at the latest mmc tree > > drivers/mmc/host/sdhci-s3c.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/drivers/mmc/host/sdhci-s3c.c b/drivers/mmc/host/sdhci-s3c.c > index 926aaf6..ce71f32 100644 > --- a/drivers/mmc/host/sdhci-s3c.c > +++ b/drivers/mmc/host/sdhci-s3c.c > @@ -297,8 +297,11 @@ static void sdhci_cmu_set_clock(struct sdhci_host *host, unsigned int clock) > u16 clk = 0; > > /* don't bother if the clock is going off */ > - if (clock == 0) > + if (clock == 0) { > + sdhci_writew(host, 0, SDHCI_CLOCK_CONTROL); > + host->clock = clock; > return; > + } > > sdhci_s3c_set_clock(host, clock); > >