From mboxrd@z Thu Jan 1 00:00:00 1970 From: Adrian Hunter Subject: Re: [PATCH] mmc: sdhci-acpi: fix error return code in sdhci_acpi_add_own_cd() Date: Mon, 10 Jun 2013 09:35:18 +0300 Message-ID: <51B573A6.1090400@intel.com> References: <000801ce5b65$28d9f400$7a8ddc00$@samsung.com> <51A44E6C.9070708@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: Received: from mga09.intel.com ([134.134.136.24]:46756 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751106Ab3FJG36 (ORCPT ); Mon, 10 Jun 2013 02:29:58 -0400 In-Reply-To: <51A44E6C.9070708@intel.com> Sender: linux-mmc-owner@vger.kernel.org List-Id: linux-mmc@vger.kernel.org To: cjb@laptop.org Cc: Jingoo Han , 'Wei Yongjun' , sonic.zhang@analog.com, yongjun_wei@trendmicro.com.cn, linux-mmc@vger.kernel.org Hi Chris Please add this to mmc-next. Regards Adrian On 28/05/13 09:27, Adrian Hunter wrote: > On 28/05/13 08:35, Jingoo Han wrote: >> On Tuesday, May 28, 2013 2:26 PM, Wei Yongjun wrote: >>> >>> From: Wei Yongjun >>> >>> Fix to return a negative error code in the gpio_to_irq() error >>> handling case instead of 0, as done elsewhere in this function. >>> >>> Signed-off-by: Wei Yongjun >> >> It looks good. >> >> Reviewed-by: Jingoo Han > > Yes, thank you! > > Acked-by: Adrian Hunter > >> >> Best regards, >> Jingoo Han >> >>> --- >>> drivers/mmc/host/sdhci-acpi.c | 4 +++- >>> 1 file changed, 3 insertions(+), 1 deletion(-) >>> >>> diff --git a/drivers/mmc/host/sdhci-acpi.c b/drivers/mmc/host/sdhci-acpi.c >>> index a51e603..08a85ec 100644 >>> --- a/drivers/mmc/host/sdhci-acpi.c >>> +++ b/drivers/mmc/host/sdhci-acpi.c >>> @@ -189,8 +189,10 @@ static int sdhci_acpi_add_own_cd(struct device *dev, int gpio, >>> goto out; >>> >>> irq = gpio_to_irq(gpio); >>> - if (irq < 0) >>> + if (irq < 0) { >>> + err = irq; >>> goto out_free; >>> + } >>> >>> flags = IRQF_TRIGGER_RISING | IRQF_TRIGGER_FALLING; >>> err = devm_request_irq(dev, irq, sdhci_acpi_sd_cd, flags, "sd_cd", mmc); >> >> >> > > >