RE: [PATCH 0/5] AM33xx: MMC resources from DT without HWMOD data

Fernandes, Joel
2013-06-28T16:56:04Z

> -----Original Message-----
> From: Krishnamoorthy, Balaji T
> Sent: Friday, June 28, 2013 10:49 AM
> To: Fernandes, Joel
> Cc: benoit.cousson-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org; lars-Qo5EllUWu/uELgA04lAiVw@public.gmane.org; Tony Lindgren; Nori, Sekhar;
> Matt Porter; Grant Likely; Rob Herring; Vinod Koul; Mark Brown; Russell King;
> Rob Landley; Andrew Morton; Jason Kridner; Koen Kooi; Chris Ball; Devicetree
> Discuss; Linux OMAP List; Linux ARM Kernel List; Linux DaVinci Kernel List;
> Linux Kernel Mailing List; Linux MMC List; Arnd Bergmann
> Subject: Re: [PATCH 0/5] AM33xx: MMC resources from DT without HWMOD
> data
>
> On Thursday 27 June 2013 11:38 PM, Fernandes, Joel wrote:
> > Hi Balaji,
> >
>
> <snip>
>
> >>> Some patches were squashed and others dropped in the series
> >>> resulting in the single patch above. This patch should be good to
> >>> apply
> >> Hi Joel,
> >>
> >> Before pushing mmc dts support for am335x, Can you please let me know
> >> if below 2 patches [1] are merged/accepted, IIRC these patches are
> >> needed for MMC to work properly.
> >>
> >> I suggest to hold the dts patch until slave_sg_limit gets merged
> >> otherwise it will cause regression in am335x mmc.
> >>
> >> [PATCH v4 1/3] dmaengine: add dma_get_slave_sg_limits() [PATCH v4
> >> 2/3] dma: edma: add device_slave_sg_limits() support
> >
> > Actually this is an independent regression and is currently worked on by Lars-
> Peter Clausen [1].
> >
> > Currently not having the MMC DTS merged is also a regression,
>
> No, Right now mmc support is not added to am335x, so it is not really a
> regression.
>
> > so I suggest lets take it one
> > step at a time and get the DTS merged in first. Also there will be
> > overhead of reposting this DTS patch later again which will not change. What
> do you say?
> >
>
> If it gets enabled via dts, without slave sg limit support, file read/write will fail,
> possibly corrupting file system.

I agree with this. Thank you.

Tony, Benoit, I guess let's just not apply the DTS yet till the slave-sg limits support
is merged as well. Sorry for the noise. Thanks.

-Joel