From: Tuomas Tynkkynen <ttynkkynen@nvidia.com>
To: Ulf Hansson <ulf.hansson@linaro.org>
Cc: "linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
Chris Ball <cjb@laptop.org>,
Stephen Warren <swarren@wwwdotorg.org>,
Jaehoon Chung <jh80.chung@samsung.com>
Subject: Re: [PATCH] mmc: core: Fixup Oops for SDIO shutdown
Date: Tue, 2 Jul 2013 13:58:56 +0300 [thread overview]
Message-ID: <51D2B270.8000603@nvidia.com> (raw)
In-Reply-To: <1372762381-18832-1-git-send-email-ulf.hansson@linaro.org>
On 07/02/2013 01:53 PM, Ulf Hansson wrote:
> Commit "mmc: core: Handle card shutdown from mmc_bus" introduced an
> Oops in the shutdown sequence for SDIO.
>
> The drv pointer, does not exist for SDIO since the probing of the SDIO
> card from the mmc_bus perspective is expected to fail by returning
> -ENODEV.
>
> This patch adds the proper check for the pointer before calling it.
>
> Reported-by: Stephen Warren <swarren@wwwdotorg.org>
> Reported-by: Tuomas Tynkkynen <ttynkkynen@nvidia.com>
> Cc: Jaehoon Chung <jh80.chung@samsung.com>
> Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
> ---
Hi,
That fixes it, thanks.
Tested-by: Tuomas Tynkkynen <ttynkkynen@nvidia.com>
next prev parent reply other threads:[~2013-07-02 10:59 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-02 10:53 [PATCH] mmc: core: Fixup Oops for SDIO shutdown Ulf Hansson
2013-07-02 10:58 ` Jaehoon Chung
2013-07-02 10:58 ` Tuomas Tynkkynen [this message]
2013-07-02 15:15 ` Stephen Warren
2013-07-07 17:15 ` Olof Johansson
2013-07-07 17:25 ` Chris Ball
2013-07-07 17:55 ` Olof Johansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51D2B270.8000603@nvidia.com \
--to=ttynkkynen@nvidia.com \
--cc=cjb@laptop.org \
--cc=jh80.chung@samsung.com \
--cc=linux-mmc@vger.kernel.org \
--cc=swarren@wwwdotorg.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox