Re: [PATCH] mmc: dw_mmc: add missing MFD_SYSCON dependency for SOCFPGA

[Jaehoon Chung <jh80.chung@samsung.com>]

Hi Jingoo,

I checked exynos_defconfig as your comment.
I also found the compiler error. thanks for your effort.

Acked-by: Jaehoon Chung <jh80.chung@samsung.com>

Best Regards,
Jaehoon Chung

On 08/02/2013 08:22 AM, Jingoo Han wrote:
> On Thursday, August 01, 2013 11:59 PM, Dinh Nguyen wrote:
>> On Thu, 2013-08-01 at 23:52 +0900, Jaehoon Chung wrote:
>>> When I used socfpga_defconfig, MFD_SYSCON is enabled.
>>> Which config do you use?
>>>
>>
>> Yes, select MFD_SYSCON is in mach-socfpga/Kconfig. This should have
>> fixed this error.
>>
>> commit 1780db9e2104 ARM: socfpga: Add syscon to be part of socfpga
> 
> +CC Fengguang Wu, Dan Carpenter, Arnd Bergmann
> 
> I used exynos_defconfig, and enabled socfpga mmc driver through menuconfig.
> Also, 'drivers/mmc/host/dw_mmc-socfpga.c' is used by ARCH_SOCFPGA.
> However, even though other configs are used, it should not make build error
> or link error.
> 
> Please look at other drivers using MFD_SYSCON.
> i.mx config also selects MFD_SYSCON; however, it added MFD_SYSCON
> dependency in order to prevent link error.
> 
> (./arch/arm/mach-imx/Kconfig)
> 786: config SOC_IMX6Q
> 804:	select MFD_SYSCON
> 
> 813: config SOC_IMX6SL
> 825:	select MFD_SYSCON
> 
>  (./drivers/regulator/Kconfig)
> 90: config REGULATOR_ANATOP
> 91:    tristate "Freescale i.MX on-chip ANATOP LDO regulators"
> 92:    depends on MFD_SYSCON
> 
> 
> Best regards,
> Jingoo Han
> 
>>
>> Dinh
>>> Best Regards,
>>> Jaehoon Chung
>>>
>>> On 08/01/2013 09:28 AM, Jingoo Han wrote:
>>>> Added missing MFD_SYSCON dependency for SOCFPGA in order to fix
>>>> the following link error.
>>>>
>>>> drivers/mmc/host/dw_mmc-socfpga.c:49: undefined reference to `syscon_regmap_lookup_by_compatible'
>>>>
>>>> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
>>>> ---
>>>>  drivers/mmc/host/Kconfig |    2 +-
>>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>>>
>>>> diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig
>>>> index 8a4c066..84102bc 100644
>>>> --- a/drivers/mmc/host/Kconfig
>>>> +++ b/drivers/mmc/host/Kconfig
>>>> @@ -569,7 +569,7 @@ config MMC_DW_EXYNOS
>>>>
>>>>  config MMC_DW_SOCFPGA
>>>>  	tristate "SOCFPGA specific extensions for Synopsys DW Memory Card Interface"
>>>> -	depends on MMC_DW
>>>> +	depends on MMC_DW && MFD_SYSCON
>>>>  	select MMC_DW_PLTFM
>>>>  	help
>>>>  	  This selects support for Altera SoCFPGA specific extensions to the
>>>>
>>>
>>>
>>
> 
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>