From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Christian Daudt" Subject: Re: [PATCH 1/3] mmc: sdhci-bcm-kona: Remove unneeded version.h inclusion Date: Thu, 22 Aug 2013 10:46:53 -0700 Message-ID: <52164E8D.7070404@broadcom.com> References: <1373263914-18050-1-git-send-email-sachin.kamat@linaro.org> <51E9A207.70306@broadcom.com> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from mms1.broadcom.com ([216.31.210.17]:2743 "EHLO mms1.broadcom.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753333Ab3HVRrF (ORCPT ); Thu, 22 Aug 2013 13:47:05 -0400 In-Reply-To: Sender: linux-mmc-owner@vger.kernel.org List-Id: linux-mmc@vger.kernel.org To: Sachin Kamat Cc: linux-mmc@vger.kernel.org, Chris Ball , Patch Tracking On 13-08-21 11:07 PM, Sachin Kamat wrote: > On 20 July 2013 02:01, Christian Daudt wrote: >> On 13-07-07 11:11 PM, Sachin Kamat wrote: >>> version.h header inclusion is not necessary as detected by >>> versioncheck. >>> >>> Signed-off-by: Sachin Kamat >>> --- >>> drivers/mmc/host/sdhci-bcm-kona.c | 1 - >>> 1 file changed, 1 deletion(-) >>> >>> diff --git a/drivers/mmc/host/sdhci-bcm-kona.c >>> b/drivers/mmc/host/sdhci-bcm-kona.c >>> index 87175f9..bca6d55 100644 >>> --- a/drivers/mmc/host/sdhci-bcm-kona.c >>> +++ b/drivers/mmc/host/sdhci-bcm-kona.c >>> @@ -24,7 +24,6 @@ >>> #include >>> #include >>> #include >>> -#include >>> #include >>> #include "sdhci-pltfm.h" >> Acked-by: Christian Daudt >> >> thanks, >> csd >> >> > Ping Chris.. > > Hi Sachin, I can pull this one into bcm tree, as I already have other patches for that file in there. I'm also pulling in patch 3. Patch 2 was already covered by this commit which is already in my pull request to armsoc so I'll drop it: Author: Markus Mayer Date: Wed Aug 7 15:39:59 2013 -0700 mmc: sdhci-bcm-kona: make linker-section warning go away This change makes the following build warning go away: [...] LINK vmlinux LD vmlinux.o MODPOST vmlinux.o WARNING: modpost: Found 2 section mismatch(es). To see full details build your kernel with: 'make CONFIG_DEBUG_SECTION_MISMATCH=y' Signed-off-by: Markus Mayer Reviewed-by: Christian Daudt Reviewed-by: Matt Porter thanks, csd