* [PATCH 2/3] mmc: sdhci-bcm-kona: Remove redundant use of_match_ptr
2013-07-08 6:11 [PATCH 1/3] mmc: sdhci-bcm-kona: Remove unneeded version.h inclusion Sachin Kamat
@ 2013-07-08 6:11 ` Sachin Kamat
2013-07-19 20:31 ` Christian Daudt
2013-07-08 6:11 ` [PATCH 3/3] mmc: sdhci-bcm-kona: Staticize sdhci_bcm_kona_card_event Sachin Kamat
` (2 subsequent siblings)
3 siblings, 1 reply; 11+ messages in thread
From: Sachin Kamat @ 2013-07-08 6:11 UTC (permalink / raw)
To: linux-mmc; +Cc: csd, cjb, sachin.kamat, patches
sdhci_bcm_kona_of_match structure is always compiled in. Hence
of_match_ptr macro is not necessary.
Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
---
drivers/mmc/host/sdhci-bcm-kona.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mmc/host/sdhci-bcm-kona.c b/drivers/mmc/host/sdhci-bcm-kona.c
index bca6d55..d7a44ae 100644
--- a/drivers/mmc/host/sdhci-bcm-kona.c
+++ b/drivers/mmc/host/sdhci-bcm-kona.c
@@ -335,7 +335,7 @@ static struct platform_driver sdhci_bcm_kona_driver = {
.name = "sdhci-kona",
.owner = THIS_MODULE,
.pm = SDHCI_PLTFM_PMOPS,
- .of_match_table = of_match_ptr(sdhci_bcm_kona_of_match),
+ .of_match_table = sdhci_bcm_kona_of_match,
},
.probe = sdhci_bcm_kona_probe,
.remove = __exit_p(sdhci_bcm_kona_remove),
--
1.7.9.5
^ permalink raw reply related [flat|nested] 11+ messages in thread* Re: [PATCH 2/3] mmc: sdhci-bcm-kona: Remove redundant use of_match_ptr
2013-07-08 6:11 ` [PATCH 2/3] mmc: sdhci-bcm-kona: Remove redundant use of_match_ptr Sachin Kamat
@ 2013-07-19 20:31 ` Christian Daudt
0 siblings, 0 replies; 11+ messages in thread
From: Christian Daudt @ 2013-07-19 20:31 UTC (permalink / raw)
To: Sachin Kamat; +Cc: linux-mmc, cjb, patches
On 13-07-07 11:11 PM, Sachin Kamat wrote:
> sdhci_bcm_kona_of_match structure is always compiled in. Hence
> of_match_ptr macro is not necessary.
>
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> ---
> drivers/mmc/host/sdhci-bcm-kona.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/sdhci-bcm-kona.c b/drivers/mmc/host/sdhci-bcm-kona.c
> index bca6d55..d7a44ae 100644
> --- a/drivers/mmc/host/sdhci-bcm-kona.c
> +++ b/drivers/mmc/host/sdhci-bcm-kona.c
> @@ -335,7 +335,7 @@ static struct platform_driver sdhci_bcm_kona_driver = {
> .name = "sdhci-kona",
> .owner = THIS_MODULE,
> .pm = SDHCI_PLTFM_PMOPS,
> - .of_match_table = of_match_ptr(sdhci_bcm_kona_of_match),
> + .of_match_table = sdhci_bcm_kona_of_match,
> },
> .probe = sdhci_bcm_kona_probe,
> .remove = __exit_p(sdhci_bcm_kona_remove),
Acked-by: Christian Daudt <csd@broadcom.com>
thanks,
csd
^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH 3/3] mmc: sdhci-bcm-kona: Staticize sdhci_bcm_kona_card_event
2013-07-08 6:11 [PATCH 1/3] mmc: sdhci-bcm-kona: Remove unneeded version.h inclusion Sachin Kamat
2013-07-08 6:11 ` [PATCH 2/3] mmc: sdhci-bcm-kona: Remove redundant use of_match_ptr Sachin Kamat
@ 2013-07-08 6:11 ` Sachin Kamat
2013-07-19 20:31 ` Christian Daudt
2013-07-19 11:10 ` [PATCH 1/3] mmc: sdhci-bcm-kona: Remove unneeded version.h inclusion Sachin Kamat
2013-07-19 20:31 ` Christian Daudt
3 siblings, 1 reply; 11+ messages in thread
From: Sachin Kamat @ 2013-07-08 6:11 UTC (permalink / raw)
To: linux-mmc; +Cc: csd, cjb, sachin.kamat, patches
sdhci_bcm_kona_card_event is referenced only in this file.
Make it static.
Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
---
drivers/mmc/host/sdhci-bcm-kona.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mmc/host/sdhci-bcm-kona.c b/drivers/mmc/host/sdhci-bcm-kona.c
index d7a44ae..f59f332 100644
--- a/drivers/mmc/host/sdhci-bcm-kona.c
+++ b/drivers/mmc/host/sdhci-bcm-kona.c
@@ -161,7 +161,7 @@ static int sdhci_bcm_kona_sd_card_emulate(struct sdhci_host *host, int insert)
/*
* SD card interrupt event callback
*/
-void sdhci_bcm_kona_card_event(struct sdhci_host *host)
+static void sdhci_bcm_kona_card_event(struct sdhci_host *host)
{
if (mmc_gpio_get_cd(host->mmc) > 0) {
dev_dbg(mmc_dev(host->mmc),
--
1.7.9.5
^ permalink raw reply related [flat|nested] 11+ messages in thread* Re: [PATCH 3/3] mmc: sdhci-bcm-kona: Staticize sdhci_bcm_kona_card_event
2013-07-08 6:11 ` [PATCH 3/3] mmc: sdhci-bcm-kona: Staticize sdhci_bcm_kona_card_event Sachin Kamat
@ 2013-07-19 20:31 ` Christian Daudt
0 siblings, 0 replies; 11+ messages in thread
From: Christian Daudt @ 2013-07-19 20:31 UTC (permalink / raw)
To: Sachin Kamat; +Cc: linux-mmc, cjb, patches
On 13-07-07 11:11 PM, Sachin Kamat wrote:
> sdhci_bcm_kona_card_event is referenced only in this file.
> Make it static.
>
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> ---
> drivers/mmc/host/sdhci-bcm-kona.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/sdhci-bcm-kona.c b/drivers/mmc/host/sdhci-bcm-kona.c
> index d7a44ae..f59f332 100644
> --- a/drivers/mmc/host/sdhci-bcm-kona.c
> +++ b/drivers/mmc/host/sdhci-bcm-kona.c
> @@ -161,7 +161,7 @@ static int sdhci_bcm_kona_sd_card_emulate(struct sdhci_host *host, int insert)
> /*
> * SD card interrupt event callback
> */
> -void sdhci_bcm_kona_card_event(struct sdhci_host *host)
> +static void sdhci_bcm_kona_card_event(struct sdhci_host *host)
> {
> if (mmc_gpio_get_cd(host->mmc) > 0) {
> dev_dbg(mmc_dev(host->mmc),
Acked-by: Christian Daudt <csd@broadcom.com>
thanks,
csd
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 1/3] mmc: sdhci-bcm-kona: Remove unneeded version.h inclusion
2013-07-08 6:11 [PATCH 1/3] mmc: sdhci-bcm-kona: Remove unneeded version.h inclusion Sachin Kamat
2013-07-08 6:11 ` [PATCH 2/3] mmc: sdhci-bcm-kona: Remove redundant use of_match_ptr Sachin Kamat
2013-07-08 6:11 ` [PATCH 3/3] mmc: sdhci-bcm-kona: Staticize sdhci_bcm_kona_card_event Sachin Kamat
@ 2013-07-19 11:10 ` Sachin Kamat
2013-07-19 20:31 ` Christian Daudt
3 siblings, 0 replies; 11+ messages in thread
From: Sachin Kamat @ 2013-07-19 11:10 UTC (permalink / raw)
To: linux-mmc; +Cc: csd, cjb, sachin.kamat, patches
On 8 July 2013 11:41, Sachin Kamat <sachin.kamat@linaro.org> wrote:
> version.h header inclusion is not necessary as detected by
> versioncheck.
>
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> ---
> drivers/mmc/host/sdhci-bcm-kona.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/mmc/host/sdhci-bcm-kona.c b/drivers/mmc/host/sdhci-bcm-kona.c
> index 87175f9..bca6d55 100644
> --- a/drivers/mmc/host/sdhci-bcm-kona.c
> +++ b/drivers/mmc/host/sdhci-bcm-kona.c
> @@ -24,7 +24,6 @@
> #include <linux/of.h>
> #include <linux/of_device.h>
> #include <linux/of_gpio.h>
> -#include <linux/version.h>
> #include <linux/mmc/slot-gpio.h>
>
> #include "sdhci-pltfm.h"
> --
> 1.7.9.5
>
Ping on this series.
--
With warm regards,
Sachin
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 1/3] mmc: sdhci-bcm-kona: Remove unneeded version.h inclusion
2013-07-08 6:11 [PATCH 1/3] mmc: sdhci-bcm-kona: Remove unneeded version.h inclusion Sachin Kamat
` (2 preceding siblings ...)
2013-07-19 11:10 ` [PATCH 1/3] mmc: sdhci-bcm-kona: Remove unneeded version.h inclusion Sachin Kamat
@ 2013-07-19 20:31 ` Christian Daudt
2013-08-02 8:50 ` Sachin Kamat
2013-08-22 6:07 ` Sachin Kamat
3 siblings, 2 replies; 11+ messages in thread
From: Christian Daudt @ 2013-07-19 20:31 UTC (permalink / raw)
To: Sachin Kamat; +Cc: linux-mmc, cjb, patches
On 13-07-07 11:11 PM, Sachin Kamat wrote:
> version.h header inclusion is not necessary as detected by
> versioncheck.
>
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> ---
> drivers/mmc/host/sdhci-bcm-kona.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/mmc/host/sdhci-bcm-kona.c b/drivers/mmc/host/sdhci-bcm-kona.c
> index 87175f9..bca6d55 100644
> --- a/drivers/mmc/host/sdhci-bcm-kona.c
> +++ b/drivers/mmc/host/sdhci-bcm-kona.c
> @@ -24,7 +24,6 @@
> #include <linux/of.h>
> #include <linux/of_device.h>
> #include <linux/of_gpio.h>
> -#include <linux/version.h>
> #include <linux/mmc/slot-gpio.h>
>
> #include "sdhci-pltfm.h"
Acked-by: Christian Daudt <csd@broadcom.com>
thanks,
csd
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [PATCH 1/3] mmc: sdhci-bcm-kona: Remove unneeded version.h inclusion
2013-07-19 20:31 ` Christian Daudt
@ 2013-08-02 8:50 ` Sachin Kamat
2013-08-22 6:07 ` Sachin Kamat
1 sibling, 0 replies; 11+ messages in thread
From: Sachin Kamat @ 2013-08-02 8:50 UTC (permalink / raw)
To: Chris Ball; +Cc: linux-mmc, patches
On 20 July 2013 02:01, Christian Daudt <csd@broadcom.com> wrote:
> On 13-07-07 11:11 PM, Sachin Kamat wrote:
>>
>> version.h header inclusion is not necessary as detected by
>> versioncheck.
>>
>> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
>> ---
>> drivers/mmc/host/sdhci-bcm-kona.c | 1 -
>> 1 file changed, 1 deletion(-)
>>
>> diff --git a/drivers/mmc/host/sdhci-bcm-kona.c
>> b/drivers/mmc/host/sdhci-bcm-kona.c
>> index 87175f9..bca6d55 100644
>> --- a/drivers/mmc/host/sdhci-bcm-kona.c
>> +++ b/drivers/mmc/host/sdhci-bcm-kona.c
>> @@ -24,7 +24,6 @@
>> #include <linux/of.h>
>> #include <linux/of_device.h>
>> #include <linux/of_gpio.h>
>> -#include <linux/version.h>
>> #include <linux/mmc/slot-gpio.h>
>> #include "sdhci-pltfm.h"
>
> Acked-by: Christian Daudt <csd@broadcom.com>
>
> thanks,
> csd
>
>
Chris,
Can you please check this series?
--
With warm regards,
Sachin
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 1/3] mmc: sdhci-bcm-kona: Remove unneeded version.h inclusion
2013-07-19 20:31 ` Christian Daudt
2013-08-02 8:50 ` Sachin Kamat
@ 2013-08-22 6:07 ` Sachin Kamat
2013-08-22 17:46 ` Christian Daudt
1 sibling, 1 reply; 11+ messages in thread
From: Sachin Kamat @ 2013-08-22 6:07 UTC (permalink / raw)
To: Christian Daudt; +Cc: linux-mmc, Chris Ball, Patch Tracking
On 20 July 2013 02:01, Christian Daudt <csd@broadcom.com> wrote:
> On 13-07-07 11:11 PM, Sachin Kamat wrote:
>>
>> version.h header inclusion is not necessary as detected by
>> versioncheck.
>>
>> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
>> ---
>> drivers/mmc/host/sdhci-bcm-kona.c | 1 -
>> 1 file changed, 1 deletion(-)
>>
>> diff --git a/drivers/mmc/host/sdhci-bcm-kona.c
>> b/drivers/mmc/host/sdhci-bcm-kona.c
>> index 87175f9..bca6d55 100644
>> --- a/drivers/mmc/host/sdhci-bcm-kona.c
>> +++ b/drivers/mmc/host/sdhci-bcm-kona.c
>> @@ -24,7 +24,6 @@
>> #include <linux/of.h>
>> #include <linux/of_device.h>
>> #include <linux/of_gpio.h>
>> -#include <linux/version.h>
>> #include <linux/mmc/slot-gpio.h>
>> #include "sdhci-pltfm.h"
>
> Acked-by: Christian Daudt <csd@broadcom.com>
>
> thanks,
> csd
>
>
Ping Chris..
--
With warm regards,
Sachin
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 1/3] mmc: sdhci-bcm-kona: Remove unneeded version.h inclusion
2013-08-22 6:07 ` Sachin Kamat
@ 2013-08-22 17:46 ` Christian Daudt
2013-08-23 8:44 ` Sachin Kamat
0 siblings, 1 reply; 11+ messages in thread
From: Christian Daudt @ 2013-08-22 17:46 UTC (permalink / raw)
To: Sachin Kamat; +Cc: linux-mmc, Chris Ball, Patch Tracking
On 13-08-21 11:07 PM, Sachin Kamat wrote:
> On 20 July 2013 02:01, Christian Daudt <csd@broadcom.com> wrote:
>> On 13-07-07 11:11 PM, Sachin Kamat wrote:
>>> version.h header inclusion is not necessary as detected by
>>> versioncheck.
>>>
>>> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
>>> ---
>>> drivers/mmc/host/sdhci-bcm-kona.c | 1 -
>>> 1 file changed, 1 deletion(-)
>>>
>>> diff --git a/drivers/mmc/host/sdhci-bcm-kona.c
>>> b/drivers/mmc/host/sdhci-bcm-kona.c
>>> index 87175f9..bca6d55 100644
>>> --- a/drivers/mmc/host/sdhci-bcm-kona.c
>>> +++ b/drivers/mmc/host/sdhci-bcm-kona.c
>>> @@ -24,7 +24,6 @@
>>> #include <linux/of.h>
>>> #include <linux/of_device.h>
>>> #include <linux/of_gpio.h>
>>> -#include <linux/version.h>
>>> #include <linux/mmc/slot-gpio.h>
>>> #include "sdhci-pltfm.h"
>> Acked-by: Christian Daudt <csd@broadcom.com>
>>
>> thanks,
>> csd
>>
>>
> Ping Chris..
>
>
Hi Sachin,
I can pull this one into bcm tree, as I already have other patches for
that file in there. I'm also pulling in patch 3. Patch 2 was already
covered by this commit which is already in my pull request to armsoc so
I'll drop it:
Author: Markus Mayer <markus.mayer@linaro.org>
Date: Wed Aug 7 15:39:59 2013 -0700
mmc: sdhci-bcm-kona: make linker-section warning go away
This change makes the following build warning go away:
[...]
LINK vmlinux
LD vmlinux.o
MODPOST vmlinux.o
WARNING: modpost: Found 2 section mismatch(es).
To see full details build your kernel with:
'make CONFIG_DEBUG_SECTION_MISMATCH=y'
Signed-off-by: Markus Mayer <markus.mayer@linaro.org>
Reviewed-by: Christian Daudt <csd@broadcom.com>
Reviewed-by: Matt Porter <matt.porter@linaro.org>
thanks,
csd
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [PATCH 1/3] mmc: sdhci-bcm-kona: Remove unneeded version.h inclusion
2013-08-22 17:46 ` Christian Daudt
@ 2013-08-23 8:44 ` Sachin Kamat
0 siblings, 0 replies; 11+ messages in thread
From: Sachin Kamat @ 2013-08-23 8:44 UTC (permalink / raw)
To: Christian Daudt; +Cc: linux-mmc, Chris Ball, Patch Tracking
Hi Christian,
On 22 August 2013 23:16, Christian Daudt <csd@broadcom.com> wrote:
> On 13-08-21 11:07 PM, Sachin Kamat wrote:
>>
>> On 20 July 2013 02:01, Christian Daudt <csd@broadcom.com> wrote:
>>>
>>> On 13-07-07 11:11 PM, Sachin Kamat wrote:
>>>>
>>>> version.h header inclusion is not necessary as detected by
>>>> versioncheck.
>>>>
>>>> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
>>>> ---
>>>> drivers/mmc/host/sdhci-bcm-kona.c | 1 -
>>>> 1 file changed, 1 deletion(-)
>>>>
>>>> diff --git a/drivers/mmc/host/sdhci-bcm-kona.c
>>>> b/drivers/mmc/host/sdhci-bcm-kona.c
>>>> index 87175f9..bca6d55 100644
>>>> --- a/drivers/mmc/host/sdhci-bcm-kona.c
>>>> +++ b/drivers/mmc/host/sdhci-bcm-kona.c
>>>> @@ -24,7 +24,6 @@
>>>> #include <linux/of.h>
>>>> #include <linux/of_device.h>
>>>> #include <linux/of_gpio.h>
>>>> -#include <linux/version.h>
>>>> #include <linux/mmc/slot-gpio.h>
>>>> #include "sdhci-pltfm.h"
>>>
>>> Acked-by: Christian Daudt <csd@broadcom.com>
>>>
>>> thanks,
>>> csd
>>>
>>>
>> Ping Chris..
>>
>>
> Hi Sachin,
> I can pull this one into bcm tree, as I already have other patches for that
> file in there. I'm also pulling in patch 3.
Sounds good. Please go ahead. Thanks.
Patch 2 was already covered by
> this commit which is already in my pull request to armsoc so I'll drop it:
> Author: Markus Mayer <markus.mayer@linaro.org>
> Date: Wed Aug 7 15:39:59 2013 -0700
>
> mmc: sdhci-bcm-kona: make linker-section warning go away
>
> This change makes the following build warning go away:
> [...]
> LINK vmlinux
> LD vmlinux.o
> MODPOST vmlinux.o
> WARNING: modpost: Found 2 section mismatch(es).
> To see full details build your kernel with:
> 'make CONFIG_DEBUG_SECTION_MISMATCH=y'
>
> Signed-off-by: Markus Mayer <markus.mayer@linaro.org>
> Reviewed-by: Christian Daudt <csd@broadcom.com>
> Reviewed-by: Matt Porter <matt.porter@linaro.org>
>
>
>
> thanks,
> csd
>
>
--
With warm regards,
Sachin
^ permalink raw reply [flat|nested] 11+ messages in thread