Linux MultiMedia Card development
 help / color / mirror / Atom feed
From: Dirk Behme <dirk.behme@de.bosch.com>
To: Chris Ball <cjb@laptop.org>
Cc: "linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>
Subject: Re: MMC_SWITCH command doesn't update the ext_csd data structure
Date: Tue, 3 Sep 2013 13:34:26 +0200	[thread overview]
Message-ID: <5225C942.3060203@de.bosch.com> (raw)
In-Reply-To: <86mwnub0yb.fsf@void.printf.net>

On 03.09.2013 13:26, Chris Ball wrote:
> Hi,
>
> On Tue, Sep 03 2013, Dirk Behme wrote:
>> +       if ((cmd.opcode == MMC_SWITCH) && ((cmd.arg >> 24) & 0x3)) {
>> +               /* In case the IOCTL has modified the EXT_CSD, update
>> it, i.e. re-read the EXT_CSD */
>> +		mmc_update_ext_csd(card->ext_csd);
>> +       }
>> +
>
> Your analysis looks good, please go ahead and submit a full patch.

The issue here is that something like mmc_update_ext_csd() doesn't 
exist, yet?

So we have to implement a mmc_update_ext_csd() in core/mmc.c and call it 
from mmc_blk_ioctl_cmd() in card/block.c?

Or any better proposal?

Thanks

Dirk

      reply	other threads:[~2013-09-03 11:34 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-03 11:04 MMC_SWITCH command doesn't update the ext_csd data structure Dirk Behme
2013-09-03 11:26 ` Chris Ball
2013-09-03 11:34   ` Dirk Behme [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5225C942.3060203@de.bosch.com \
    --to=dirk.behme@de.bosch.com \
    --cc=cjb@laptop.org \
    --cc=linux-mmc@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox