From: Joel Fernandes <joelf@ti.com>
To: Benoit Cousson <bcousson@baylibre.com>
Cc: Linux OMAP List <linux-omap@vger.kernel.org>,
Linux ARM Kernel List <linux-arm-kernel@lists.infradead.org>,
Linux MMC List <linux-mmc@vger.kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
"swarren@wwwdotorg.org" <swarren@wwwdotorg.org>,
"rob.herring@calxeda.com" <rob.herring@calxeda.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
Pawel Moll <Pawel.Moll@arm.com>
Subject: Re: [PATCH v2 0/9] ARM: dts: DT data for OMAP platforms for v3.13
Date: Fri, 4 Oct 2013 09:50:37 -0500 [thread overview]
Message-ID: <524ED5BD.2060504@ti.com> (raw)
In-Reply-To: <524ECC63.3050303@baylibre.com>
On 10/04/2013 09:10 AM, Benoit Cousson wrote:
> On 04/10/2013 04:00, Joel Fernandes wrote:
>> On 10/03/2013 08:25 AM, Benoit Cousson wrote:
>>> + DT list and DT maintainers.
>>>
>>> Hi Joel,
>>>
>>> Thanks for the update. It looks good to me.
>>>
>>> For the new bindings added below;
>>>
>>>> .../devicetree/bindings/crypto/omap-aes.txt | 34 ++++++++++
>>>> .../devicetree/bindings/crypto/omap-sham.txt | 31 +++++++++
>>>
>>> I will need the acked-by from one of the DT maintainers.
>>
>> Sure. To help with giving Ack for this, I'd like to also mention these patches
>> were due for long time and reposted. The supporting code is already in the
>> kernel.
>>
>> Also bindings were reviewed by Mark Rutland comments in the following thread
>> were addressed:
>> http://www.spinics.net/lists/arm-kernel/msg269006.html
>
> OK, that's good news, at least it was already reviewed by Mark.
>
> I'm fixing and pulling the series, and will add Mark's Acked-by as soon as he
> will send it.
>
> Meanwhile some nits, I'm fixing myself this time :-)
>
> None of your subjects is following the same guideline and the repertory
> guideline...
>
> omap4: dts: Add node for AES
> omap4: dts: Add node for DES3DES module
> am33xx: dts: Fix AES interrupt number
> ARM: am437x: dts: Add AES node for am437x
> ARM: am437x: dts: Add DES node for am437x
>
> It should be ARM: dts: OMAPXXX or AMXXX...
>
> Regards,
> Benoit
>
On 10/04/2013 09:10 AM, Benoit Cousson wrote:> On 04/10/2013 04:00, Joel
Fernandes wrote:
>> On 10/03/2013 08:25 AM, Benoit Cousson wrote:
>>> + DT list and DT maintainers.
>>>
>>> Hi Joel,
>>>
>>> Thanks for the update. It looks good to me.
>>>
>>> For the new bindings added below;
>>>
>>>> .../devicetree/bindings/crypto/omap-aes.txt | 34 ++++++++++
>>>> .../devicetree/bindings/crypto/omap-sham.txt | 31 +++++++++
>>>
>>> I will need the acked-by from one of the DT maintainers.
>>
>> Sure. To help with giving Ack for this, I'd like to also mention these patches
>> were due for long time and reposted. The supporting code is already in the
>> kernel.
>>
>> Also bindings were reviewed by Mark Rutland comments in the following thread
>> were addressed:
>> http://www.spinics.net/lists/arm-kernel/msg269006.html
>
> OK, that's good news, at least it was already reviewed by Mark.
>
> I'm fixing and pulling the series, and will add Mark's Acked-by as soon as he
> will send it.
>
> Meanwhile some nits, I'm fixing myself this time :-)
>
> None of your subjects is following the same guideline and the repertory
> guideline...
>
> omap4: dts: Add node for AES
> omap4: dts: Add node for DES3DES module
> am33xx: dts: Fix AES interrupt number
> ARM: am437x: dts: Add AES node for am437x
> ARM: am437x: dts: Add DES node for am437x
>
> It should be ARM: dts: OMAPXXX or AMXXX...
Thanks & sorry about that.
I think Mark came back with some more comments on 2 of those patches. I will
work on those and repost.
-Joel
prev parent reply other threads:[~2013-10-04 14:51 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-30 15:12 [PATCH v2 0/9] ARM: dts: DT data for OMAP platforms for v3.13 Joel Fernandes
2013-09-30 15:12 ` [PATCH v2 1/9] omap4: dts: Add node for AES Joel Fernandes
2013-09-30 15:12 ` [PATCH v2 2/9] omap4: dts: Add node for DES3DES module Joel Fernandes
2013-09-30 15:13 ` [PATCH v2 3/9] ARM: dts: Add SHAM data and documentation for AM33XX Joel Fernandes
2013-10-04 14:26 ` Mark Rutland
2013-10-05 18:18 ` Joel Fernandes
2013-09-30 15:13 ` [PATCH v2 4/9] ARM: dts: Add AES " Joel Fernandes
[not found] ` <1380553986-15910-5-git-send-email-joelf-l0cyMroinI0@public.gmane.org>
2013-10-04 14:33 ` Mark Rutland
2013-10-05 18:29 ` Joel Fernandes
2013-09-30 15:13 ` [PATCH v2 5/9] am33xx: dts: Fix AES interrupt number Joel Fernandes
2013-10-04 14:19 ` Benoit Cousson
2013-09-30 15:13 ` [PATCH v2 6/9] ARM: am437x: dts: Add AES node for am437x Joel Fernandes
2013-09-30 15:13 ` [PATCH v2 7/9] ARM: am437x: dts: Add DES " Joel Fernandes
2013-09-30 15:13 ` [PATCH v2 8/9] ARM: dts: AM33XX: Add LCDC info into am335x-evm Joel Fernandes
2013-09-30 15:13 ` [PATCH v2 9/9] dts: boneblack: add pinmux and hdmi node to enable display Joel Fernandes
2013-10-03 13:25 ` [PATCH v2 0/9] ARM: dts: DT data for OMAP platforms for v3.13 Benoit Cousson
2013-10-04 2:00 ` Joel Fernandes
2013-10-04 14:10 ` Benoit Cousson
2013-10-04 14:50 ` Joel Fernandes [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=524ED5BD.2060504@ti.com \
--to=joelf@ti.com \
--cc=Pawel.Moll@arm.com \
--cc=bcousson@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=rob.herring@calxeda.com \
--cc=swarren@wwwdotorg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox