From: Zhang Haijun <b42677@freescale.com>
To: Haijun Zhang <Haijun.Zhang@freescale.com>, linux-mmc@vger.kernel.org
Cc: cbouatmailru@gmail.com, cjb@laptop.org, scottwood@freescale.com,
X.Xie@freescale.com, ulf.hansson@linaro.org
Subject: Re: [PATCH 1/2] mmc:sdhc: Add vendor specific interrupt and handle routine
Date: Mon, 21 Oct 2013 17:20:21 +0800 [thread overview]
Message-ID: <5264F1D5.3080403@freescale.com> (raw)
In-Reply-To: <1379395711-28462-2-git-send-email-Haijun.Zhang@freescale.com>
Hi, Ulf
Coud you give some advice on this patch?
Thanks.
于 2013/9/17 13:28, Haijun Zhang 写道:
> As spec detailed:
> Error Interrupt Status Register(Offset 032h)[15-12]
> Error Interrupt Status Enable Register (Offset 036h)[15-12]
> Error Interrupt Signal Enable Register (Offset 03Ah)[15-12]
>
> Bits above are specified by vendor itself.
> So add interface to handle this requirememt.
> Also share sdhci_dma_show in sdhc.h for platform usr.
>
> Signed-off-by: Haijun Zhang <Haijun.Zhang@freescale.com>
> ---
> drivers/mmc/host/sdhci.c | 25 +++++++++++++++++++------
> drivers/mmc/host/sdhci.h | 5 +++++
> 2 files changed, 24 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c
> index b4d7f27..2ba9c6d 100644
> --- a/drivers/mmc/host/sdhci.c
> +++ b/drivers/mmc/host/sdhci.c
> @@ -238,16 +238,25 @@ static void sdhci_set_ios(struct mmc_host *mmc, struct mmc_ios *ios);
>
> static void sdhci_init(struct sdhci_host *host, int soft)
> {
> + u32 pltm_irq = 0, irq = 0;
> +
> if (soft)
> sdhci_reset(host, SDHCI_RESET_CMD|SDHCI_RESET_DATA);
> else
> sdhci_reset(host, SDHCI_RESET_ALL);
>
> - sdhci_clear_set_irqs(host, SDHCI_INT_ALL_MASK,
> - SDHCI_INT_BUS_POWER | SDHCI_INT_DATA_END_BIT |
> + irq = SDHCI_INT_BUS_POWER | SDHCI_INT_DATA_END_BIT |
> SDHCI_INT_DATA_CRC | SDHCI_INT_DATA_TIMEOUT | SDHCI_INT_INDEX |
> SDHCI_INT_END_BIT | SDHCI_INT_CRC | SDHCI_INT_TIMEOUT |
> - SDHCI_INT_DATA_END | SDHCI_INT_RESPONSE);
> + SDHCI_INT_DATA_END | SDHCI_INT_RESPONSE;
> + /* Vendor Specific Error Status, Status enable and Signal Enable */
> + if (host->ops->get_platform_irq)
> + host->ops->get_platform_irq(host, &pltm_irq);
> +
> + if (pltm_irq)
> + irq |= pltm_irq;
> +
> + sdhci_clear_set_irqs(host, SDHCI_INT_ALL_MASK, irq);
>
> if (soft) {
> /* force clock reconfiguration */
> @@ -2241,6 +2250,9 @@ static void sdhci_cmd_irq(struct sdhci_host *host, u32 intmask)
> SDHCI_INT_INDEX))
> host->cmd->error = -EILSEQ;
>
> + if (host->ops->handle_platform_irq)
> + host->ops->handle_platform_irq(host, intmask);
> +
> if (host->cmd->error) {
> tasklet_schedule(&host->finish_tasklet);
> return;
> @@ -2273,7 +2285,7 @@ static void sdhci_cmd_irq(struct sdhci_host *host, u32 intmask)
> }
>
> #ifdef CONFIG_MMC_DEBUG
> -static void sdhci_show_adma_error(struct sdhci_host *host)
> +void sdhci_show_adma_error(struct sdhci_host *host)
> {
> const char *name = mmc_hostname(host->mmc);
> u8 *desc = host->adma_desc;
> @@ -2350,10 +2362,11 @@ static void sdhci_data_irq(struct sdhci_host *host, u32 intmask)
> pr_err("%s: ADMA error\n", mmc_hostname(host->mmc));
> sdhci_show_adma_error(host);
> host->data->error = -EIO;
> - if (host->ops->adma_workaround)
> - host->ops->adma_workaround(host, intmask);
> }
>
> + if (host->ops->handle_platform_irq)
> + host->ops->handle_platform_irq(host, intmask);
> +
> if (host->data->error)
> sdhci_finish_data(host);
> else {
> diff --git a/drivers/mmc/host/sdhci.h b/drivers/mmc/host/sdhci.h
> index b037f18..a0f1734 100644
> --- a/drivers/mmc/host/sdhci.h
> +++ b/drivers/mmc/host/sdhci.h
> @@ -292,6 +292,8 @@ struct sdhci_ops {
> void (*hw_reset)(struct sdhci_host *host);
> void (*platform_suspend)(struct sdhci_host *host);
> void (*platform_resume)(struct sdhci_host *host);
> + void (*get_platform_irq)(struct sdhci_host *host, u32 *irq);
> + void (*handle_platform_irq)(struct sdhci_host *host, u32 intmask);
> void (*adma_workaround)(struct sdhci_host *host, u32 intmask);
> void (*platform_init)(struct sdhci_host *host);
> void (*card_event)(struct sdhci_host *host);
> @@ -405,4 +407,7 @@ extern int sdhci_runtime_suspend_host(struct sdhci_host *host);
> extern int sdhci_runtime_resume_host(struct sdhci_host *host);
> #endif
>
> +#ifdef CONFIG_MMC_DEBUG
> +extern void sdhci_show_adma_error(struct sdhci_host *host);
> +#endif
> #endif /* __SDHCI_HW_H */
--
Thanks & Regards
Haijun.
prev parent reply other threads:[~2013-10-21 9:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-17 5:28 [PATCH 2/2] mmc:esdhc: Enable DMA err bit for eSDHC host Haijun Zhang
2013-09-17 5:28 ` [PATCH 1/2] mmc:sdhc: Add vendor specific interrupt and handle routine Haijun Zhang
2013-10-21 9:20 ` Zhang Haijun [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5264F1D5.3080403@freescale.com \
--to=b42677@freescale.com \
--cc=Haijun.Zhang@freescale.com \
--cc=X.Xie@freescale.com \
--cc=cbouatmailru@gmail.com \
--cc=cjb@laptop.org \
--cc=linux-mmc@vger.kernel.org \
--cc=scottwood@freescale.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).