* [PATCH] mmc: dw_mmc: exynos: Revert the sdr_timing assignment
@ 2013-10-22 9:11 Yuvaraj Kumar C D
2013-10-22 10:12 ` Jaehoon Chung
2013-10-27 2:38 ` Chris Ball
0 siblings, 2 replies; 6+ messages in thread
From: Yuvaraj Kumar C D @ 2013-10-22 9:11 UTC (permalink / raw)
To: cjb, jh80.chung, tgih.jun, linux-mmc, thomas.ab, grundler
Cc: dianders, sonnyrao, Yuvaraj Kumar C D
commit 4ad602c9df1e3b04979c260b5612141b4b892257 was wrongly assigning
ddr_timing value to sdr_timing.This patch fix's this by reverting
the sdr_timing assignment statement to the earlier location.
Signed-off-by: Yuvaraj Kumar C D <yuvaraj.cd@samsung.com>
---
drivers/mmc/host/dw_mmc-exynos.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/mmc/host/dw_mmc-exynos.c b/drivers/mmc/host/dw_mmc-exynos.c
index d42e664..3423c5e 100644
--- a/drivers/mmc/host/dw_mmc-exynos.c
+++ b/drivers/mmc/host/dw_mmc-exynos.c
@@ -251,12 +251,13 @@ static int dw_mci_exynos_parse_dt(struct dw_mci *host)
if (ret)
return ret;
+ priv->sdr_timing = SDMMC_CLKSEL_TIMING(timing[0], timing[1], div);
+
ret = of_property_read_u32_array(np,
"samsung,dw-mshc-ddr-timing", timing, 2);
if (ret)
return ret;
- priv->sdr_timing = SDMMC_CLKSEL_TIMING(timing[0], timing[1], div);
priv->ddr_timing = SDMMC_CLKSEL_TIMING(timing[0], timing[1], div);
host->priv = priv;
return 0;
--
1.7.9.5
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] mmc: dw_mmc: exynos: Revert the sdr_timing assignment
2013-10-22 9:11 [PATCH] mmc: dw_mmc: exynos: Revert the sdr_timing assignment Yuvaraj Kumar C D
@ 2013-10-22 10:12 ` Jaehoon Chung
2013-10-23 11:27 ` Seungwon Jeon
2013-10-27 2:38 ` Chris Ball
1 sibling, 1 reply; 6+ messages in thread
From: Jaehoon Chung @ 2013-10-22 10:12 UTC (permalink / raw)
To: Yuvaraj Kumar C D, cjb, tgih.jun, linux-mmc, thomas.ab, grundler
Cc: dianders, sonnyrao, Yuvaraj Kumar C D
Acked-by: Jaehoon Chung <jh80.chung@samsung.com>
Reported-by: Grant Grundler <grundler@chromium.org>
On 10/22/2013 06:11 PM, Yuvaraj Kumar C D wrote:
> commit 4ad602c9df1e3b04979c260b5612141b4b892257 was wrongly assigning
> ddr_timing value to sdr_timing.This patch fix's this by reverting
> the sdr_timing assignment statement to the earlier location.
>
> Signed-off-by: Yuvaraj Kumar C D <yuvaraj.cd@samsung.com>
> ---
> drivers/mmc/host/dw_mmc-exynos.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/dw_mmc-exynos.c b/drivers/mmc/host/dw_mmc-exynos.c
> index d42e664..3423c5e 100644
> --- a/drivers/mmc/host/dw_mmc-exynos.c
> +++ b/drivers/mmc/host/dw_mmc-exynos.c
> @@ -251,12 +251,13 @@ static int dw_mci_exynos_parse_dt(struct dw_mci *host)
> if (ret)
> return ret;
>
> + priv->sdr_timing = SDMMC_CLKSEL_TIMING(timing[0], timing[1], div);
> +
> ret = of_property_read_u32_array(np,
> "samsung,dw-mshc-ddr-timing", timing, 2);
> if (ret)
> return ret;
>
> - priv->sdr_timing = SDMMC_CLKSEL_TIMING(timing[0], timing[1], div);
> priv->ddr_timing = SDMMC_CLKSEL_TIMING(timing[0], timing[1], div);
> host->priv = priv;
> return 0;
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: [PATCH] mmc: dw_mmc: exynos: Revert the sdr_timing assignment
2013-10-22 10:12 ` Jaehoon Chung
@ 2013-10-23 11:27 ` Seungwon Jeon
0 siblings, 0 replies; 6+ messages in thread
From: Seungwon Jeon @ 2013-10-23 11:27 UTC (permalink / raw)
To: 'Jaehoon Chung', 'Yuvaraj Kumar C D', cjb,
linux-mmc, thomas.ab, grundler
Cc: dianders, sonnyrao, 'Yuvaraj Kumar C D'
On Tue, October 22, 2013, Jaehoon Chung wrote:
> Acked-by: Jaehoon Chung <jh80.chung@samsung.com>
> Reported-by: Grant Grundler <grundler@chromium.org>
Acked-by: Seungwon Jeon <tgih.jun@samsung.com>
Thanks,
Seungwon Jeon
>
> On 10/22/2013 06:11 PM, Yuvaraj Kumar C D wrote:
> > commit 4ad602c9df1e3b04979c260b5612141b4b892257 was wrongly assigning
> > ddr_timing value to sdr_timing.This patch fix's this by reverting
> > the sdr_timing assignment statement to the earlier location.
> >
> > Signed-off-by: Yuvaraj Kumar C D <yuvaraj.cd@samsung.com>
> > ---
> > drivers/mmc/host/dw_mmc-exynos.c | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/mmc/host/dw_mmc-exynos.c b/drivers/mmc/host/dw_mmc-exynos.c
> > index d42e664..3423c5e 100644
> > --- a/drivers/mmc/host/dw_mmc-exynos.c
> > +++ b/drivers/mmc/host/dw_mmc-exynos.c
> > @@ -251,12 +251,13 @@ static int dw_mci_exynos_parse_dt(struct dw_mci *host)
> > if (ret)
> > return ret;
> >
> > + priv->sdr_timing = SDMMC_CLKSEL_TIMING(timing[0], timing[1], div);
> > +
> > ret = of_property_read_u32_array(np,
> > "samsung,dw-mshc-ddr-timing", timing, 2);
> > if (ret)
> > return ret;
> >
> > - priv->sdr_timing = SDMMC_CLKSEL_TIMING(timing[0], timing[1], div);
> > priv->ddr_timing = SDMMC_CLKSEL_TIMING(timing[0], timing[1], div);
> > host->priv = priv;
> > return 0;
> >
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] mmc: dw_mmc: exynos: Revert the sdr_timing assignment
2013-10-22 9:11 [PATCH] mmc: dw_mmc: exynos: Revert the sdr_timing assignment Yuvaraj Kumar C D
2013-10-22 10:12 ` Jaehoon Chung
@ 2013-10-27 2:38 ` Chris Ball
2013-10-28 5:18 ` Yuvaraj Kumar
1 sibling, 1 reply; 6+ messages in thread
From: Chris Ball @ 2013-10-27 2:38 UTC (permalink / raw)
To: Yuvaraj Kumar C D
Cc: jh80.chung, tgih.jun, linux-mmc, thomas.ab, grundler, dianders,
sonnyrao, Yuvaraj Kumar C D
Hi Yuvaraj,
On Tue, Oct 22 2013, Yuvaraj Kumar C D wrote:
> commit 4ad602c9df1e3b04979c260b5612141b4b892257 was wrongly assigning
> ddr_timing value to sdr_timing.This patch fix's this by reverting
> the sdr_timing assignment statement to the earlier location.
4ad602c9df1e3 doesn't exist in mainline. Do you mean e6c784eded7b3
("mmc: dw_mmc: exynos: move the exynos private init")?
Thanks,
- Chris.
--
Chris Ball <cjb@laptop.org> <http://printf.net/>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] mmc: dw_mmc: exynos: Revert the sdr_timing assignment
2013-10-27 2:38 ` Chris Ball
@ 2013-10-28 5:18 ` Yuvaraj Kumar
2013-11-08 19:29 ` Chris Ball
0 siblings, 1 reply; 6+ messages in thread
From: Yuvaraj Kumar @ 2013-10-28 5:18 UTC (permalink / raw)
To: Chris Ball
Cc: Jaehoon Chung, Seungwon Jeon, linux-mmc, thomas.ab,
Grant Grundler, Doug Anderson, Sonny Rao, Yuvaraj Kumar C D
On Sun, Oct 27, 2013 at 8:08 AM, Chris Ball <cjb@laptop.org> wrote:
> Hi Yuvaraj,
>
> On Tue, Oct 22 2013, Yuvaraj Kumar C D wrote:
>> commit 4ad602c9df1e3b04979c260b5612141b4b892257 was wrongly assigning
>> ddr_timing value to sdr_timing.This patch fix's this by reverting
>> the sdr_timing assignment statement to the earlier location.
>
> 4ad602c9df1e3 doesn't exist in mainline. Do you mean e6c784eded7b3
> ("mmc: dw_mmc: exynos: move the exynos private init")?
Yes Chris, thats the one.
Do you want me to respin this patch with the updated commit message?
>
> Thanks,
>
> - Chris.
> --
> Chris Ball <cjb@laptop.org> <http://printf.net/>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] mmc: dw_mmc: exynos: Revert the sdr_timing assignment
2013-10-28 5:18 ` Yuvaraj Kumar
@ 2013-11-08 19:29 ` Chris Ball
0 siblings, 0 replies; 6+ messages in thread
From: Chris Ball @ 2013-11-08 19:29 UTC (permalink / raw)
To: Yuvaraj Kumar
Cc: Jaehoon Chung, Seungwon Jeon, linux-mmc, thomas.ab,
Grant Grundler, Doug Anderson, Sonny Rao, Yuvaraj Kumar C D
Hi Yuvaraj,
On Mon, Oct 28 2013, Yuvaraj Kumar wrote:
> On Sun, Oct 27, 2013 at 8:08 AM, Chris Ball <cjb@laptop.org> wrote:
>> Hi Yuvaraj,
>>
>> On Tue, Oct 22 2013, Yuvaraj Kumar C D wrote:
>>> commit 4ad602c9df1e3b04979c260b5612141b4b892257 was wrongly assigning
>>> ddr_timing value to sdr_timing.This patch fix's this by reverting
>>> the sdr_timing assignment statement to the earlier location.
>>
>> 4ad602c9df1e3 doesn't exist in mainline. Do you mean e6c784eded7b3
>> ("mmc: dw_mmc: exynos: move the exynos private init")?
> Yes Chris, thats the one.
> Do you want me to respin this patch with the updated commit message?
No, that's okay, I fixed it and pushed to mmc-next for 3.13.
Thanks,
- Chris.
--
Chris Ball <cjb@laptop.org> <http://printf.net/>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2013-11-08 19:29 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-10-22 9:11 [PATCH] mmc: dw_mmc: exynos: Revert the sdr_timing assignment Yuvaraj Kumar C D
2013-10-22 10:12 ` Jaehoon Chung
2013-10-23 11:27 ` Seungwon Jeon
2013-10-27 2:38 ` Chris Ball
2013-10-28 5:18 ` Yuvaraj Kumar
2013-11-08 19:29 ` Chris Ball
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox