From: Dinh Nguyen <dinh.linux@gmail.com>
To: "Heiko Stübner" <heiko@sntech.de>
Cc: dinguyen@altera.com, arnd@arndb.de, cjb@laptop.org,
jh80.chung@samsung.com, tgih.jun@samsung.com,
dianders@chromium.org, alim.akhtar@samsung.com,
bzhao@marvell.com, linux-mmc@vger.kernel.org
Subject: Re: [PATCH 2/2] mmc: dw_mmc-pltm: Remove Rockchip's custom dw_mmc driver structure
Date: Fri, 06 Dec 2013 17:27:01 -0600 [thread overview]
Message-ID: <52A25D45.7000500@gmail.com> (raw)
In-Reply-To: <201312070022.03414.heiko@sntech.de>
On 12/6/13 5:22 PM, Heiko Stübner wrote:
> Am Samstag, 7. Dezember 2013, 00:18:07 schrieb Dinh Nguyen:
>> On 12/6/13 5:14 PM, Heiko Stübner wrote:
>>> Am Freitag, 6. Dezember 2013, 17:10:23 schrieb dinguyen@altera.com:@@ -42,7 +42,7 @@
>>> /* Common flag combinations */
>>> #define DW_MCI_DATA_ERROR_FLAGS (SDMMC_INT_DRTO | SDMMC_INT_DCRC | \
>>> SDMMC_INT_HTO | SDMMC_INT_SBE | \
>>> - SDMMC_INT_EBE)
>>> + SDMMC_INT_EBE | SDMMC_INT_FRUN)
>>> #define DW_MCI_CMD_ERROR_FLAGS (SDMMC_INT_RTO | SDMMC_INT_RCRC | \
>>>> From: Dinh Nguyen <dinguyen@altera.com>
>>>>
>>>> Rockchip's implementation of the dw_mmc controller only requires the
>>>> setting of the SDMMC_CMD_USE_HOLD_REG on every command. With the patch
>>>> to set the SDMMC_CMD_USE_HOLD_REG by checking the slot's speed mode,
>>>> this Rockchip custom driver structure is no longer necessary.
>>>>
>>>> Signed-off-by: Dinh Nguyen <dinguyen@altera.com>
>>> hmm, testing will need a bit more time, as it seems one of the changes
>>> merged during the 3.13 merge window broke the dw-mmc on the rockchip.
>> Thanks Heiko. Don't bother with v1, I overlooked another aspect of using
>> the hold
>> reg. Let me send out a v2 for you to test.
> Don't worry ... as I've said, first I need to find the current issue :-)
What behavior are you seeing? I had to do this apply this for 3.13 when the
SD driver is using IDMAC:
--- a/drivers/mmc/host/dw_mmc.c
+++ b/drivers/mmc/host/dw_mmc.c
@@ -42,7 +42,7 @@
/* Common flag combinations */
#define DW_MCI_DATA_ERROR_FLAGS (SDMMC_INT_DRTO | SDMMC_INT_DCRC | \
SDMMC_INT_HTO | SDMMC_INT_SBE | \
- SDMMC_INT_EBE)
+ SDMMC_INT_EBE | SDMMC_INT_FRUN)
#define DW_MCI_CMD_ERROR_FLAGS (SDMMC_INT_RTO | SDMMC_INT_RCRC | \
SDMMC_INT_RESP_ERR)
#define DW_MCI_ERROR_FLAGS (DW_MCI_DATA_ERROR_FLAGS | \
>
> Heiko
>
next prev parent reply other threads:[~2013-12-06 23:27 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-06 16:10 [PATCH 0/2] mmc: dw_mmc: Make the use of the hold reg generic dinguyen
2013-12-06 16:10 ` [PATCH 1/2] mmc: dw_mmc: Enable the hold reg for certain speed modes dinguyen
2013-12-06 16:10 ` [PATCH 2/2] mmc: dw_mmc-pltm: Remove Rockchip's custom dw_mmc driver structure dinguyen
2013-12-06 23:14 ` Heiko Stübner
2013-12-06 23:18 ` Dinh Nguyen
2013-12-06 23:22 ` Heiko Stübner
2013-12-06 23:27 ` Dinh Nguyen [this message]
2013-12-07 0:12 ` Heiko Stübner
2013-12-06 17:36 ` [PATCH 0/2] mmc: dw_mmc: Make the use of the hold reg generic Arnd Bergmann
2013-12-06 21:09 ` Dinh Nguyen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52A25D45.7000500@gmail.com \
--to=dinh.linux@gmail.com \
--cc=alim.akhtar@samsung.com \
--cc=arnd@arndb.de \
--cc=bzhao@marvell.com \
--cc=cjb@laptop.org \
--cc=dianders@chromium.org \
--cc=dinguyen@altera.com \
--cc=heiko@sntech.de \
--cc=jh80.chung@samsung.com \
--cc=linux-mmc@vger.kernel.org \
--cc=tgih.jun@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).