From: Jaehoon Chung <jh80.chung@samsung.com>
To: Ulf Hansson <ulf.hansson@linaro.org>,
Jaehoon Chung <jh80.chung@samsung.com>
Cc: "linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
Chris Ball <chris@printf.net>,
Seungwon Jeon <tgih.jun@samsung.com>,
Olof Johansson <olof@lixom.net>
Subject: Re: [PATCH v3 1/8] mmc: core: add the property for hs200
Date: Mon, 17 Feb 2014 12:17:37 +0900 [thread overview]
Message-ID: <53017F51.7020308@samsung.com> (raw)
In-Reply-To: <CAPDyKFoxqHsurFicOiE=EQV4JoA3Og0_=m9Fr3kG6is1qUX7Qg@mail.gmail.com>
Hi Ulf,
On 02/14/2014 09:30 PM, Ulf Hansson wrote:
> On 14 February 2014 12:31, Ulf Hansson <ulf.hansson@linaro.org> wrote:
>> On 3 February 2014 12:15, Jaehoon Chung <jh80.chung@samsung.com> wrote:
>>> mmc-hs200-1.8v and mmc-hs200-1.2v can be used to the general capability.
>>>
>>> Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com>
>>
>> Acked-by: Ulf Hansson <ulf.hansson@linaro.org>
>
> Hi Jaehoon,
>
> While I was adding some more DT bindings for mmc, I decided to rebase
> and fold in this patch into my patchset.
>
> Hope your fine with it, otherwise just let me know.
Thanks for adding patch at your patchset.
Best Regards,
Jaehoon Chung
>
> Kind regards
> Ulf Hansson
>
>
>>
>>> ---
>>> Changelog V3:
>>> - Use the "len" instead of "NULL"
>>> Changelog V2:
>>> - Rename the mmc-hs200-1_8v/1_2v instead of "_caps2_"
>>> - Add the properties into Documentation/devicetree/bindings/mmc/mmc.txt
>>>
>>> Documentation/devicetree/bindings/mmc/mmc.txt | 2 ++
>>> drivers/mmc/core/host.c | 4 ++++
>>> 2 files changed, 6 insertions(+)
>>>
>>> diff --git a/Documentation/devicetree/bindings/mmc/mmc.txt b/Documentation/devicetree/bindings/mmc/mmc.txt
>>> index 458b57f..4bb3894 100644
>>> --- a/Documentation/devicetree/bindings/mmc/mmc.txt
>>> +++ b/Documentation/devicetree/bindings/mmc/mmc.txt
>>> @@ -29,6 +29,8 @@ Optional properties:
>>> - cap-power-off-card: powering off the card is safe
>>> - cap-sdio-irq: enable SDIO IRQ signalling on this interface
>>> - full-pwr-cycle: full power cycle of the card is supported
>>> +- mmc-hs200-1_8v: HS200 mode(1.8V I/O) is supported
>>> +- mmc-hs200-1_2v: HS200 mode(1.2V I/O) is supported
>>>
>>> *NOTE* on CD and WP polarity. To use common for all SD/MMC host controllers line
>>> polarity properties, we have to fix the meaning of the "normal" and "inverted"
>>> diff --git a/drivers/mmc/core/host.c b/drivers/mmc/core/host.c
>>> index 49bc403..4b81c93 100644
>>> --- a/drivers/mmc/core/host.c
>>> +++ b/drivers/mmc/core/host.c
>>> @@ -429,6 +429,10 @@ int mmc_of_parse(struct mmc_host *host)
>>> host->pm_caps |= MMC_PM_KEEP_POWER;
>>> if (of_find_property(np, "enable-sdio-wakeup", &len))
>>> host->pm_caps |= MMC_PM_WAKE_SDIO_IRQ;
>>> + if (of_find_property(np, "mmc-hs200-1_8v", &len))
>>> + host->caps2 |= MMC_CAP2_HS200_1_8V_SDR;
>>> + if (of_find_property(np, "mmc-hs200-1_2v", &len))
>>> + host->caps2 |= MMC_CAP2_HS200_1_2V_SDR;
>>>
>>> return 0;
>>>
>>> --
>>> 1.7.9.5
> --
> To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
prev parent reply other threads:[~2014-02-17 3:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-03 11:15 [PATCH v3 1/8] mmc: core: add the property for hs200 Jaehoon Chung
2014-02-14 11:31 ` Ulf Hansson
2014-02-14 12:30 ` Ulf Hansson
2014-02-17 3:17 ` Jaehoon Chung [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53017F51.7020308@samsung.com \
--to=jh80.chung@samsung.com \
--cc=chris@printf.net \
--cc=linux-mmc@vger.kernel.org \
--cc=olof@lixom.net \
--cc=tgih.jun@samsung.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).