linux-mmc.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Balaji T K <balajitk@ti.com>
To: Daniel Mack <zonque@gmail.com>
Cc: chris@printf.net, linux-mmc@vger.kernel.org, linux-omap@vger.kernel.org
Subject: Re: [PATCH] mmc: omap_hsmmc: support more DT properties
Date: Tue, 18 Feb 2014 20:06:36 +0530	[thread overview]
Message-ID: <53036FF4.2000906@ti.com> (raw)
In-Reply-To: <1392636993-15864-1-git-send-email-zonque@gmail.com>

On Monday 17 February 2014 05:06 PM, Daniel Mack wrote:
> This should probably be done implicitly through mmc_of_parse(), but that
> doesn't play well along with the multi-slot model the hsmmc driver
> features. Hence, for now, do it manually. The properties are already
> documented in Documentation/devicetree/bindings/mmc/mmc.txt.
>
> Signed-off-by: Daniel Mack <zonque@gmail.com>

looks good to me
Acked-by: Balaji T K <balajitk@ti.com>

> ---
>   drivers/mmc/host/omap_hsmmc.c | 6 ++++++
>   1 file changed, 6 insertions(+)
>
> diff --git a/drivers/mmc/host/omap_hsmmc.c b/drivers/mmc/host/omap_hsmmc.c
> index 2815de6..a5a38cc 100644
> --- a/drivers/mmc/host/omap_hsmmc.c
> +++ b/drivers/mmc/host/omap_hsmmc.c
> @@ -1765,6 +1765,12 @@ static struct omap_mmc_platform_data *of_get_hsmmc_pdata(struct device *dev)
>   	if (of_find_property(np, "ti,needs-special-hs-handling", NULL))
>   		pdata->slots[0].features |= HSMMC_HAS_HSPE_SUPPORT;
>
> +	if (of_find_property(np, "keep-power-in-suspend", NULL))
> +		pdata->slots[0].pm_caps |= MMC_PM_KEEP_POWER;
> +
> +	if (of_find_property(np, "enable-sdio-wakeup", NULL))
> +		pdata->slots[0].pm_caps |= MMC_PM_WAKE_SDIO_IRQ;
> +
>   	return pdata;
>   }
>   #else
>


  reply	other threads:[~2014-02-18 14:36 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-17 11:36 [PATCH] mmc: omap_hsmmc: support more DT properties Daniel Mack
2014-02-18 14:36 ` Balaji T K [this message]
2014-02-24 15:31   ` Daniel Mack

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53036FF4.2000906@ti.com \
    --to=balajitk@ti.com \
    --cc=chris@printf.net \
    --cc=linux-mmc@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=zonque@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).