* [PATCH v4 5/7] mmc: dw_mmc: remove the unnecessary function.
@ 2014-03-03 2:36 Jaehoon Chung
2014-03-06 7:32 ` Ulf Hansson
0 siblings, 1 reply; 2+ messages in thread
From: Jaehoon Chung @ 2014-03-03 2:36 UTC (permalink / raw)
To: linux-mmc@vger.kernel.org; +Cc: Chris Ball, Ulf Hansson, Seungwon Jeon
Remove unnecessary function.
This function didn't re-use anywhere.
Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com>
---
Changelog V4:
- None
Changelog V3:
- None
Changelog V2:
- None
drivers/mmc/host/dw_mmc.c | 8 +-------
1 file changed, 1 insertion(+), 7 deletions(-)
diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c
index ac16308..1418d33 100644
--- a/drivers/mmc/host/dw_mmc.c
+++ b/drivers/mmc/host/dw_mmc.c
@@ -235,12 +235,6 @@ err:
}
#endif /* defined(CONFIG_DEBUG_FS) */
-static void dw_mci_set_timeout(struct dw_mci *host)
-{
- /* timeout (maximum) */
- mci_writel(host, TMOUT, 0xffffffff);
-}
-
static u32 dw_mci_prepare_command(struct mmc_host *mmc, struct mmc_command *cmd)
{
struct mmc_data *data;
@@ -861,7 +855,7 @@ static void __dw_mci_start_request(struct dw_mci *host,
data = cmd->data;
if (data) {
- dw_mci_set_timeout(host);
+ mci_writel(host, TMOUT, 0xFFFFFFFF);
mci_writel(host, BYTCNT, data->blksz*data->blocks);
mci_writel(host, BLKSIZ, data->blksz);
}
--
1.7.9.5
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH v4 5/7] mmc: dw_mmc: remove the unnecessary function.
2014-03-03 2:36 [PATCH v4 5/7] mmc: dw_mmc: remove the unnecessary function Jaehoon Chung
@ 2014-03-06 7:32 ` Ulf Hansson
0 siblings, 0 replies; 2+ messages in thread
From: Ulf Hansson @ 2014-03-06 7:32 UTC (permalink / raw)
To: Jaehoon Chung; +Cc: linux-mmc@vger.kernel.org, Chris Ball, Seungwon Jeon
On 3 March 2014 03:36, Jaehoon Chung <jh80.chung@samsung.com> wrote:
> Remove unnecessary function.
> This function didn't re-use anywhere.
>
> Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com>
Acked-by: Ulf Hansson <ulf.hansson@linaro.org>
> ---
> Changelog V4:
> - None
> Changelog V3:
> - None
> Changelog V2:
> - None
>
> drivers/mmc/host/dw_mmc.c | 8 +-------
> 1 file changed, 1 insertion(+), 7 deletions(-)
>
> diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c
> index ac16308..1418d33 100644
> --- a/drivers/mmc/host/dw_mmc.c
> +++ b/drivers/mmc/host/dw_mmc.c
> @@ -235,12 +235,6 @@ err:
> }
> #endif /* defined(CONFIG_DEBUG_FS) */
>
> -static void dw_mci_set_timeout(struct dw_mci *host)
> -{
> - /* timeout (maximum) */
> - mci_writel(host, TMOUT, 0xffffffff);
> -}
> -
> static u32 dw_mci_prepare_command(struct mmc_host *mmc, struct mmc_command *cmd)
> {
> struct mmc_data *data;
> @@ -861,7 +855,7 @@ static void __dw_mci_start_request(struct dw_mci *host,
>
> data = cmd->data;
> if (data) {
> - dw_mci_set_timeout(host);
> + mci_writel(host, TMOUT, 0xFFFFFFFF);
> mci_writel(host, BYTCNT, data->blksz*data->blocks);
> mci_writel(host, BLKSIZ, data->blksz);
> }
> --
> 1.7.9.5
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-03-06 7:32 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-03-03 2:36 [PATCH v4 5/7] mmc: dw_mmc: remove the unnecessary function Jaehoon Chung
2014-03-06 7:32 ` Ulf Hansson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).