From: Franky Lin <frankyl@broadcom.com>
To: chris@printf.net, ulf.hansson@linaro.org
Cc: linux-mmc@vger.kernel.org
Subject: Re: [PATCH] mmc: sdhci: only invoke clock re-tuning for adtc type commands
Date: Sat, 15 Mar 2014 12:16:29 -0700 [thread overview]
Message-ID: <5324A70D.6080501@broadcom.com> (raw)
In-Reply-To: <531A23E1.8060400@broadcom.com>
Hi Chris and Ulf,
On 03/07/2014 11:54 AM, Franky Lin wrote:
> On 02/24/2014 11:57 AM, Franky Lin wrote:
>> Hi Chris,
>>
>> On 01/07/2014 10:37 AM, Franky Lin wrote:
>>> For high clock frequency modes, ie. SDR104 and possibly SDR50, the data
>>> window on the CMD and DAT lines needs to be tuned. Once tuned to a
>>> sample clock rate, a re-tuning might required because of drifted signal
>>> on different lines. This re-tuning is needed and only necessary for
>>> commands using the DAT lines, ie. adtc type commands. This patch is an
>>> optimization by adding the condition of the requested command being adtc
>>> type in order to execute the re-tuning procedure.
>>>
>>> Signed-off-by: Franky Lin <frankyl@broadcom.com>
>>> ---
>>
>> Is this still in your queue? Any remarks on it?
>>
>> Thanks,
>> Franky
>>
>
> Ping?
Need to try my luck again. :) Could you please share your thought about
this patch?
Thanks,
Franky
>
>>> drivers/mmc/host/sdhci.c | 3 ++-
>>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c
>>> index cc00bed..f301cd6 100644
>>> --- a/drivers/mmc/host/sdhci.c
>>> +++ b/drivers/mmc/host/sdhci.c
>>> @@ -1389,7 +1389,8 @@ static void sdhci_request(struct mmc_host *mmc,
>>> struct mmc_request *mrq)
>>> * tuning procedure before sending command.
>>> */
>>> if ((host->flags & SDHCI_NEEDS_RETUNING) &&
>>> - !(present_state & (SDHCI_DOING_WRITE |
>>> SDHCI_DOING_READ))) {
>>> + !(present_state & (SDHCI_DOING_WRITE |
>>> SDHCI_DOING_READ)) &&
>>> + mmc_cmd_type(mrq->cmd) == MMC_CMD_ADTC) {
>>> if (mmc->card) {
>>> /* eMMC uses cmd21 but sd and sdio use cmd19 */
>>> tuning_opcode =
>>>
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2014-03-15 19:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1389119511-26228-1-git-send-email-frankyl@broadcom.com>
2014-01-07 18:37 ` [PATCH] mmc: sdhci: only invoke clock re-tuning for adtc type commands Franky Lin
2014-02-24 19:57 ` Franky Lin
2014-03-07 19:54 ` Franky Lin
2014-03-15 19:16 ` Franky Lin [this message]
2014-03-17 9:12 ` Ulf Hansson
2014-03-17 16:51 ` Franky Lin
2014-03-26 16:49 ` Franky Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5324A70D.6080501@broadcom.com \
--to=frankyl@broadcom.com \
--cc=chris@printf.net \
--cc=linux-mmc@vger.kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).