From: Aaron Lu <aaron.lu@intel.com>
To: Arend van Spriel <arend@broadcom.com>, Chris Ball <chris@printf.net>
Cc: linux-mmc@vger.kernel.org, Dong Aisheng <dongas86@gmail.com>
Subject: Re: RESEND:[PATCH V3] sdhci: only reprogram retuning timer when flag is set
Date: Thu, 20 Mar 2014 13:32:55 +0800 [thread overview]
Message-ID: <532A7D87.4000009@intel.com> (raw)
In-Reply-To: <1393012782-23917-1-git-send-email-arend@broadcom.com>
On 02/22/2014 03:59 AM, Arend van Spriel wrote:
> When the host->tuning_count is zero it means that the
> retuning is disabled. This is checked on the first
> run of sdhci_execute_tuning() by the if statement below:
>
> if (!(host->flags & SDHCI_NEEDS_RETUNING) && host->tuning_count &&
> (host->tuning_mode == SDHCI_TUNING_MODE_1)) {
>
> So only when tuning_count is non-zero it will set the host
> flag SDHCI_USING_RETUNING_TIMER. The else statement is only
> for re-programming the timer, which means that flag must be
> set. Because that is not checked the else statement is executed
> in the first run when tuning_count is zero.
>
> This was seen on a host controller which indicated
> SDHCI_TUNING_MODE_1 (0) and tuning_count being zero. Suspect
> that (one of) these registers is not properly set.
>
> Cc: Dong Aisheng <dongas86@gmail.com>
> Cc: Aaron Lu <aaron.lwe@gmail.com>
> Signed-off-by: Arend van Spriel <arend@broadcom.com>
In addition to solve your problem, this patch also makes sense in the
common case, so:
Reviewed-by: Aaron Lu <aaron.lu@intel.com>
next prev parent reply other threads:[~2014-03-20 5:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-21 19:59 RESEND:[PATCH V3] sdhci: only reprogram retuning timer when flag is set Arend van Spriel
2014-03-06 9:29 ` Arend van Spriel
2014-03-07 4:06 ` Ulf Hansson
2014-03-18 21:02 ` Arend van Spriel
2014-03-20 5:32 ` Aaron Lu [this message]
2014-03-25 20:49 ` Arend van Spriel
2014-03-25 20:56 ` Chris Ball
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=532A7D87.4000009@intel.com \
--to=aaron.lu@intel.com \
--cc=arend@broadcom.com \
--cc=chris@printf.net \
--cc=dongas86@gmail.com \
--cc=linux-mmc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).