From: Lars-Peter Clausen <lars@metafoo.de>
To: Ulf Hansson <ulf.hansson@linaro.org>
Cc: Alex Smith <alex.smith@imgtec.com>,
linux-mmc <linux-mmc@vger.kernel.org>,
Chris Ball <chris@printf.net>,
James Hogan <james.hogan@imgtec.com>
Subject: Re: [PATCH] mmc: jz4740: don't wait for PRG_DONE after stop command with R1 response
Date: Tue, 29 Apr 2014 13:28:23 +0200 [thread overview]
Message-ID: <535F8CD7.9060703@metafoo.de> (raw)
In-Reply-To: <CAPDyKFpAbLzhHBuzCnpTjRR9XC=H1uB71wFDkDg9drHfBMeMyw@mail.gmail.com>
On 04/29/2014 01:07 PM, Ulf Hansson wrote:
> On 29 April 2014 10:32, Alex Smith <alex.smith@imgtec.com> wrote:
>> As of commit bcc3e1726d ("mmc: block: Use R1 responses for stop cmds for
>> read requests"), stop commands for reads do not have MMC_RSP_BUSY set.
>> In this case we should not wait for a PRG_DONE IRQ after sending the
>> stop command: it will not get raised when the busy flag is not set,
>> causing the request to fail with a timeout.
>>
>> Signed-off-by: Alex Smith <alex.smith@imgtec.com>
>> Cc: Lars-Peter Clausen <lars@metafoo.de>
>> Cc: Ulf Hansson <ulf.hansson@linaro.org>
>> Cc: Chris Ball <chris@printf.net>
>> Cc: James Hogan <james.hogan@imgtec.com>
>
> Acked-by: Ulf Hansson <ulf.hansson@linaro.org>
>
Acked-by: Lars-Peter Clausen <lars@metafoo.de>
next prev parent reply other threads:[~2014-04-29 11:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-29 8:32 [PATCH] mmc: jz4740: don't wait for PRG_DONE after stop command with R1 response Alex Smith
2014-04-29 11:07 ` Ulf Hansson
2014-04-29 11:28 ` Lars-Peter Clausen [this message]
2014-04-29 12:11 ` Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=535F8CD7.9060703@metafoo.de \
--to=lars@metafoo.de \
--cc=alex.smith@imgtec.com \
--cc=chris@printf.net \
--cc=james.hogan@imgtec.com \
--cc=linux-mmc@vger.kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox