linux-mmc.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jaehoon Chung <jh80.chung@samsung.com>
To: Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
	Seungwon Jeon <tgih.jun@samsung.com>,
	Jaehoon Chung <jh80.chung@samsung.com>
Cc: Chris Ball <chris@printf.net>,
	Ulf Hansson <ulf.hansson@linaro.org>,
	linux-mmc@vger.kernel.org
Subject: Re: [PATCH 2/2] mmc: dw_mmc: print card frequency in debug level
Date: Thu, 01 May 2014 17:42:28 +0900	[thread overview]
Message-ID: <536208F4.2060900@samsung.com> (raw)
In-Reply-To: <1398865484-527-2-git-send-email-bigeasy@linutronix.de>

Hi, Sebastian.

You have to work on latest mmc-next repository.
And that message is useful information for debugging.
I didn't want to change message level.

Best Regards,
Jaehoon Chung

On 04/30/2014 10:44 PM, Sebastian Andrzej Siewior wrote:
> Printing this at info level can be very noisy the CD is not working and
> we poll for the card.
> 
> Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
> ---
>  drivers/mmc/host/dw_mmc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c
> index 82f5ea2..b8afc70 100644
> --- a/drivers/mmc/host/dw_mmc.c
> +++ b/drivers/mmc/host/dw_mmc.c
> @@ -800,7 +800,7 @@ static void dw_mci_setup_bus(struct dw_mci_slot *slot, bool force_clkinit)
>  		div = (host->bus_hz != clock) ? DIV_ROUND_UP(div, 2) : 0;
>  
>  		if ((clock << div) != slot->__clk_old || force_clkinit)
> -			dev_info(&slot->mmc->class_dev,
> +			dev_dbg(&slot->mmc->class_dev,
>  				 "Bus speed (slot %d) = %dHz (slot req %dHz, actual %dHZ div = %d)\n",
>  				 slot->id, host->bus_hz, clock,
>  				 div ? ((host->bus_hz / div) >> 1) :
> 


  reply	other threads:[~2014-05-01  8:42 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-30 13:44 [PATCH 1/2] mmc: dw_mmc: poll if CD is broken Sebastian Andrzej Siewior
2014-04-30 13:44 ` [PATCH 2/2] mmc: dw_mmc: print card frequency in debug level Sebastian Andrzej Siewior
2014-05-01  8:42   ` Jaehoon Chung [this message]
     [not found] ` <CAELcNGT7Ei35tmZzAJ4iCdwMCamd5tC-onRmNG3JL+78_6B0-w@mail.gmail.com>
2014-04-30 15:17   ` [PATCH 1/2] mmc: dw_mmc: poll if CD is broken Sebastian Andrzej Siewior
2014-05-01  8:38     ` Jaehoon Chung

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=536208F4.2060900@samsung.com \
    --to=jh80.chung@samsung.com \
    --cc=bigeasy@linutronix.de \
    --cc=chris@printf.net \
    --cc=linux-mmc@vger.kernel.org \
    --cc=tgih.jun@samsung.com \
    --cc=ulf.hansson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).