Re: [PATCH 3/5] mmc: dw_mmc-exynos: add the MMC_CAP_ERASE by default.

Jaehoon Chung
2014-05-13T12:27:03Z

Hi, Seungwon.

On 05/13/2014 08:15 PM, Seungwon Jeon wrote:
> Hi Jaehoon,
>
> I think we can remove MMC_CAP_ERASE from host's cap.
Thanks for reminding. :)
It's my mistake..Confused with linux-3.10.

Best Regards,
Jaehoon Chung

>
> Can you check below patch?
> [PATCH v4] mmc: remove MMC_CAP_ERASE to enable trim in eMMC/SD Device
>
> Thanks,
> Seungwon Jeon
>
> On Mon, May 12, 2014, Jaehoon Chung wrote:
>> To use the erase command, add the MMC_CAP_ERASE capability by default.
>>
>> Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com>
>> ---
>> drivers/mmc/host/dw_mmc-exynos.c | 9 +++++----
>> 1 file changed, 5 insertions(+), 4 deletions(-)
>>
>> diff --git a/drivers/mmc/host/dw_mmc-exynos.c b/drivers/mmc/host/dw_mmc-exynos.c
>> index 0fbc53a..46fafd8 100644
>> --- a/drivers/mmc/host/dw_mmc-exynos.c
>> +++ b/drivers/mmc/host/dw_mmc-exynos.c
>> @@ -386,10 +386,11 @@ static int dw_mci_exynos_execute_tuning(struct dw_mci_slot *slot, u32 opcode,
>>
>> /* Common capabilities of Exynos4/Exynos5 SoC */
>> static unsigned long exynos_dwmmc_caps[4] = {
>> - MMC_CAP_1_8V_DDR | MMC_CAP_8_BIT_DATA | MMC_CAP_CMD23,
>> - MMC_CAP_CMD23,
>> - MMC_CAP_CMD23,
>> - MMC_CAP_CMD23,
>> + MMC_CAP_1_8V_DDR | MMC_CAP_8_BIT_DATA | MMC_CAP_CMD23 |
>> + MMC_CAP_ERASE,
>> + MMC_CAP_CMD23 | MMC_CAP_ERASE,
>> + MMC_CAP_CMD23 | MMC_CAP_ERASE,
>> + MMC_CAP_CMD23 | MMC_CAP_ERASE,
>> };
>>
>> static const struct dw_mci_drv_data exynos_drv_data = {
>> --
>> 1.7.9.5
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
>